From: David Hildenbrand <david@redhat.com>
To: Chen Wandun <chenwandun@huawei.com>,
akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz,
osalvador@suse.de, mgorman@techsingularity.net,
rppt@linux.ibm.com, dan.j.williams@intel.com,
alexander.h.duyck@linux.intel.com, anshuman.khandual@arm.com,
pavel.tatashin@microsoft.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/page_alloc: fix gcc compile warning
Date: Wed, 23 Oct 2019 15:44:56 +0200 [thread overview]
Message-ID: <d5398c86-82f6-ed1a-73ff-f668ebdaf96e@redhat.com> (raw)
In-Reply-To: <1571838508-117928-1-git-send-email-chenwandun@huawei.com>
On 23.10.19 15:48, Chen Wandun wrote:
> From: Chenwandun <chenwandun@huawei.com>
>
> mm/page_alloc.o: In function `page_alloc_init_late':
> mm/page_alloc.c:1956: undefined reference to `zone_pcp_update'
> mm/page_alloc.o:(.debug_addr+0x8350): undefined reference to `zone_pcp_update'
> make: *** [vmlinux] Error 1
>
> zone_pcp_update is defined in CONFIG_MEMORY_HOTPLUG,
> so add ifdef when calling zone_pcp_update.
>
> Signed-off-by: Chenwandun <chenwandun@huawei.com>
> ---
> mm/page_alloc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index f9488ef..8513150 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -1952,8 +1952,10 @@ void __init page_alloc_init_late(void)
> * so the pcpu batch and high limits needs to be updated or the limits
> * will be artificially small.
> */
> +#ifdef CONFIG_MEMORY_HOTPLUG
> for_each_populated_zone(zone)
> zone_pcp_update(zone);
> +#endif
>
> /*
> * We initialized the rest of the deferred pages. Permanently disable
>
See
https://lkml.org/lkml/2019/10/23/206
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2019-10-23 13:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 13:48 [PATCH] mm/page_alloc: fix gcc compile warning Chen Wandun
2019-10-23 13:44 ` David Hildenbrand [this message]
2019-10-23 14:38 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5398c86-82f6-ed1a-73ff-f668ebdaf96e@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.h.duyck@linux.intel.com \
--cc=anshuman.khandual@arm.com \
--cc=chenwandun@huawei.com \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=pavel.tatashin@microsoft.com \
--cc=rppt@linux.ibm.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).