From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7BF6C433F5 for ; Tue, 21 Sep 2021 07:31:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3D7F160ED5 for ; Tue, 21 Sep 2021 07:31:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3D7F160ED5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 8F53E6B0071; Tue, 21 Sep 2021 03:31:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A50D6B0072; Tue, 21 Sep 2021 03:31:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 79413900002; Tue, 21 Sep 2021 03:31:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0075.hostedemail.com [216.40.44.75]) by kanga.kvack.org (Postfix) with ESMTP id 670426B0071 for ; Tue, 21 Sep 2021 03:31:33 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 170478249980 for ; Tue, 21 Sep 2021 07:31:33 +0000 (UTC) X-FDA: 78610760466.10.6DAC0E3 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by imf30.hostedemail.com (Postfix) with ESMTP id CF34FE001982 for ; Tue, 21 Sep 2021 07:31:32 +0000 (UTC) Received: by mail-pl1-f176.google.com with SMTP id l6so8005084plh.9 for ; Tue, 21 Sep 2021 00:31:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=iT/A7saFWdSRDEDmu/VTK8EiZ0qLpHBdaDox0oesTUg=; b=gDTXZuETD2SrveG2tnn6mLAaK2DRY8v2YdE0Z7B0hKnnlfXnZ2hk+2wW1OwZ6x56xY Y88fiHi8iF1Pvxk0TsSR868FvnZHjFX2O8cprwraKRVgxBbl2gNM75eQl/KJds7yp5MB gtMYE8OXZHyykH7gCNkTCRBUnJfNHxLwWADCy5nmfn6g0DHgahBiLssTYUlTBM3PkYzA rKmgK+CnKGmPz1MoGpNQxlDx+Bz501MppVqPuNLFyLxXIG2A9URiJjn2oGOgLi2h4hX8 39vGn15EYJG+HwqLZ6mGFgdH18p7vIwqga5bVekEViFweHBDFnt0tR9cmrgiIn6Yb/8K mQyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=iT/A7saFWdSRDEDmu/VTK8EiZ0qLpHBdaDox0oesTUg=; b=2gb2kNHQY0wcWgzFN3myLuhSwDb0S+oHq199rLR6IpZGY1jKgHM77wj9dryP5jgAwi uBH/Hj0COkcKZJKtq/Ya4gStoQ3Y3zZR58XvPsImKHeBSi3czipOUeIg/uc+LmRqHAcf RBAyQ4AxaztBSTRlcpRIIFMNrwsZQxf7tzDCJYOu8ExNdPmhM5mvwNq70LJDIxRMfHM9 +xjCAzUElRe7RleNioXqnfyzGiDwShgZ2fFUmPy/z9znYGmCB4HCfuHlZGAbwIdt3+7u IE5JLQYlnTwoRKOHLlJOL2PQKmPv47EI/3rvoPWROXgI5hHTt7vD9Def584/2ufY2itN oeAg== X-Gm-Message-State: AOAM533HF6NBoNniWjU8jjT78R6I2ilwdeXSMuEUoh/GutQgs8iQzqge pfz6BAnp4V4EbT3ETJCHT8Q= X-Google-Smtp-Source: ABdhPJyPWVA16UxUHFcNGd2HYDeNHwaIxj84SZUFfQ+9V5Vht1lQ67OKECMEgHpldsZweSXbpYRE4w== X-Received: by 2002:a17:903:4094:b0:13c:86b0:3050 with SMTP id z20-20020a170903409400b0013c86b03050mr26129372plc.58.1632209491760; Tue, 21 Sep 2021 00:31:31 -0700 (PDT) Received: from owniadeMacBook-Pro.local ([103.97.201.31]) by smtp.gmail.com with ESMTPSA id g19sm1568094pjl.25.2021.09.21.00.31.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Sep 2021 00:31:31 -0700 (PDT) Subject: Re: [PATCH v2 2/2] mm/debug: sync up latest migrate_reason to migrate_reason_names To: "Huang, Ying" Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Anshuman Khandual , Michal Hocko , John Hubbard , Pavel Tatashin , Yang Shi , Zi Yan , Dave Hansen , Minchan Kim , Mina Almasry , "Matthew Wilcox (Oracle)" , Oscar Salvador , Wei Xu References: <20210921064553.293905-1-o451686892@gmail.com> <20210921064553.293905-3-o451686892@gmail.com> <87mto676fq.fsf@yhuang6-desk2.ccr.corp.intel.com> From: Weizhao Ouyang Message-ID: Date: Tue, 21 Sep 2021 15:31:27 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <87mto676fq.fsf@yhuang6-desk2.ccr.corp.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Content-Language: en-US Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=gDTXZuET; spf=pass (imf30.hostedemail.com: domain of o451686892@gmail.com designates 209.85.214.176 as permitted sender) smtp.mailfrom=o451686892@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: CF34FE001982 X-Stat-Signature: jnm4in17weaq6bkzr518p9gcy88tf631 X-HE-Tag: 1632209492-361808 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2021/9/21 15:07, Huang, Ying wrote: > Weizhao Ouyang writes: > >> Sync up MR_DEMOTION to migrate_reason_names and add a synch prompt. >> >> Fixes: 26aa2d199d6f ("mm/migrate: demote pages during reclaim") >> Signed-off-by: Weizhao Ouyang >> Reviewed-by: "Huang, Ying" >> --- >> include/linux/migrate.h | 6 +++++- >> mm/debug.c | 1 + >> 2 files changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/include/linux/migrate.h b/include/linux/migrate.h >> index 326250996b4e..c8077e936691 100644 >> --- a/include/linux/migrate.h >> +++ b/include/linux/migrate.h >> @@ -19,6 +19,11 @@ struct migration_target_control; >> */ >> #define MIGRATEPAGE_SUCCESS 0 >> >> +/* >> + * Keep sync with: >> + * - macro MIGRATE_REASON in include/trace/events/migrate.h >> + * - migrate_reason_names[MR_TYPES] in mm/debug.c >> + */ >> enum migrate_reason { >> MR_COMPACTION, >> MR_MEMORY_FAILURE, >> @@ -32,7 +37,6 @@ enum migrate_reason { >> MR_TYPES >> }; >> >> -/* In mm/debug.c; also keep sync with include/trace/events/migrate.h */ >> extern const char *migrate_reason_names[MR_TYPES]; >> >> #ifdef CONFIG_MIGRATION >> diff --git a/mm/debug.c b/mm/debug.c >> index e61037cded98..fae0f81ad831 100644 >> --- a/mm/debug.c >> +++ b/mm/debug.c >> @@ -26,6 +26,7 @@ const char *migrate_reason_names[MR_TYPES] = { >> "numa_misplaced", >> "contig_range", >> "longterm_pin", >> + "demotion", >> }; >> >> const struct trace_print_flags pageflag_names[] = { > Can we add BUILD_BUG_ON() somewhere to capture at least some > synchronization issue? Hi Huang, we discussed this in the v1 thread with you and John, seems you missed it. Now we just add a comment to do the synchronization, and we can figure out a more general way to use strings which in trace_events straight. Thanks, Weizhao