From: Eric Dumazet <erdnetdev@gmail.com>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
linux-mm@kvack.org, netdev@vger.kernel.org,
Dongli Zhang <dongli.zhang@oracle.com>
Cc: Aruna Ramakrishna <aruna.ramakrishna@oracle.com>,
Bert Barbe <bert.barbe@oracle.com>,
Rama Nichanamatlu <rama.nichanamatlu@oracle.com>,
Venkat Venkatsubra <venkat.x.venkatsubra@oracle.com>,
Manjunath Patil <manjunath.b.patil@oracle.com>,
Joe Jin <joe.jin@oracle.com>, SRINIVAS <srinivas.eeda@oracle.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] page_frag: Recover from memory pressure
Date: Thu, 5 Nov 2020 14:21:25 +0100 [thread overview]
Message-ID: <d673308e-c9a6-85a7-6c22-0377dd33c019@gmail.com> (raw)
In-Reply-To: <20201105042140.5253-1-willy@infradead.org>
On 11/5/20 5:21 AM, Matthew Wilcox (Oracle) wrote:
> When the machine is under extreme memory pressure, the page_frag allocator
> signals this to the networking stack by marking allocations with the
> 'pfmemalloc' flag, which causes non-essential packets to be dropped.
> Unfortunately, even after the machine recovers from the low memory
> condition, the page continues to be used by the page_frag allocator,
> so all allocations from this page will continue to be dropped.
>
> Fix this by freeing and re-allocating the page instead of recycling it.
>
> Reported-by: Dongli Zhang <dongli.zhang@oracle.com>
> Cc: Aruna Ramakrishna <aruna.ramakrishna@oracle.com>
> Cc: Bert Barbe <bert.barbe@oracle.com>
> Cc: Rama Nichanamatlu <rama.nichanamatlu@oracle.com>
> Cc: Venkat Venkatsubra <venkat.x.venkatsubra@oracle.com>
> Cc: Manjunath Patil <manjunath.b.patil@oracle.com>
> Cc: Joe Jin <joe.jin@oracle.com>
> Cc: SRINIVAS <srinivas.eeda@oracle.com>
> Cc: stable@vger.kernel.org
> Fixes: 79930f5892e ("net: do not deplete pfmemalloc reserve")
Your patch looks fine, although this Fixes: tag seems incorrect.
79930f5892e ("net: do not deplete pfmemalloc reserve") was propagating
the page pfmemalloc status into the skb, and seems correct to me.
The bug was the page_frag_alloc() was keeping a problematic page for
an arbitrary period of time ?
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> ---
> mm/page_alloc.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 778e815130a6..631546ae1c53 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -5139,6 +5139,10 @@ void *page_frag_alloc(struct page_frag_cache *nc,
>
> if (!page_ref_sub_and_test(page, nc->pagecnt_bias))
> goto refill;
> + if (nc->pfmemalloc) {
if (unlikely(nc->pfmemalloc)) {
> + free_the_page(page, compound_order(page));
> + goto refill;
> + }
>
> #if (PAGE_SIZE < PAGE_FRAG_CACHE_MAX_SIZE)
> /* if size can vary use size else just use PAGE_SIZE */
>
next prev parent reply other threads:[~2020-11-05 13:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 4:21 [PATCH] page_frag: Recover from memory pressure Matthew Wilcox (Oracle)
2020-11-05 11:56 ` Vlastimil Babka
2020-11-05 12:05 ` Matthew Wilcox
2020-11-05 12:09 ` Vlastimil Babka
2020-11-05 13:21 ` Eric Dumazet [this message]
2020-11-05 14:02 ` Matthew Wilcox
2020-11-09 14:32 ` Matthew Wilcox
2020-11-09 14:37 ` Eric Dumazet
2020-11-15 6:47 ` Dongli Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d673308e-c9a6-85a7-6c22-0377dd33c019@gmail.com \
--to=erdnetdev@gmail.com \
--cc=aruna.ramakrishna@oracle.com \
--cc=bert.barbe@oracle.com \
--cc=dongli.zhang@oracle.com \
--cc=joe.jin@oracle.com \
--cc=linux-mm@kvack.org \
--cc=manjunath.b.patil@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=rama.nichanamatlu@oracle.com \
--cc=srinivas.eeda@oracle.com \
--cc=stable@vger.kernel.org \
--cc=venkat.x.venkatsubra@oracle.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).