From: David Hildenbrand <david@redhat.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Michal Hocko <mhocko@suse.com>, Evan Green <evgreen@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>,
Alex Shi <alexs@kernel.org>, Alistair Popple <apopple@nvidia.com>,
Jens Axboe <axboe@kernel.dk>,
Johannes Weiner <hannes@cmpxchg.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
Miaohe Lin <linmiaohe@huawei.com>,
Minchan Kim <minchan@kernel.org>,
Vlastimil Babka <vbabka@suse.cz>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-api@vger.kernel.org
Subject: Re: [PATCH v2] mm: Enable suspend-only swap spaces
Date: Tue, 27 Jul 2021 14:19:02 +0200 [thread overview]
Message-ID: <d6f7b7a4-c27f-5ccb-c605-c16f6a7ea2e6@redhat.com> (raw)
In-Reply-To: <20210727120413.GB32265@duo.ucw.cz>
On 27.07.21 14:04, Pavel Machek wrote:
> Hi!
>
>> Let's take a look at hibernate() callers:
>>
>> drivers/mfd/tps65010.c: calls hibernate() from IRQ contex, based on HW
>> event
>
> No it does not. Look again.
>
Oh, dead code :)
>> kernel/power/autosleep.c: calls hibernate() when it thinks it might be
>> a good time to go to sleep
>
> Ok, you are right, it is there. But I don't believe anyone uses this
> configuration.
If it's dead code, we might want to look into deprecating and removing
it. It was introduced around 2012:
https://lwn.net/Articles/479841/
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2021-07-27 12:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-09 17:50 [PATCH v2] mm: Enable suspend-only swap spaces Evan Green
2021-07-09 22:20 ` Andrew Morton
2021-07-09 23:23 ` Evan Green
2021-07-09 23:33 ` Andrew Morton
2021-07-12 21:36 ` Evan Green
2021-07-12 7:03 ` Michal Hocko
2021-07-12 7:41 ` David Hildenbrand
2021-07-14 5:43 ` Michal Hocko
2021-07-14 7:51 ` David Hildenbrand
2021-07-14 8:00 ` Michal Hocko
2021-07-27 12:04 ` Pavel Machek
2021-07-27 12:19 ` David Hildenbrand [this message]
2021-07-27 12:01 ` Pavel Machek
2021-07-12 21:32 ` Evan Green
2021-07-14 5:41 ` Michal Hocko
2021-07-14 22:39 ` Evan Green
2021-07-27 12:10 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6f7b7a4-c27f-5ccb-c605-c16f6a7ea2e6@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alexs@kernel.org \
--cc=apopple@nvidia.com \
--cc=axboe@kernel.dk \
--cc=evgreen@chromium.org \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linmiaohe@huawei.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=pavel@ucw.cz \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).