Linux-mm Archive on lore.kernel.org
 help / color / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Wei Yang <richard.weiyang@gmail.com>, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mm/page_alloc.c: leverage compiler to zero out used_mask
Date: Fri, 27 Mar 2020 10:32:45 +0100
Message-ID: <d712ce2d-78a9-afcc-64d4-1102638f2fc0@redhat.com> (raw)
In-Reply-To: <20200326222445.18781-1-richard.weiyang@gmail.com>

On 26.03.20 23:24, Wei Yang wrote:
> Since we always clear used_mask before getting node order, we can
> leverage compiler to do this instead of at run time.
> 
> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
> ---
>  mm/page_alloc.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 0e823bca3f2f..2144b6ceb119 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -5587,14 +5587,13 @@ static void build_zonelists(pg_data_t *pgdat)
>  {
>  	static int node_order[MAX_NUMNODES];
>  	int node, load, nr_nodes = 0;
> -	nodemask_t used_mask;
> +	nodemask_t used_mask = {.bits = {0}};
>  	int local_node, prev_node;
>  
>  	/* NUMA-aware ordering of nodes */
>  	local_node = pgdat->node_id;
>  	load = nr_online_nodes;
>  	prev_node = local_node;
> -	nodes_clear(used_mask);
>  
>  	memset(node_order, 0, sizeof(node_order));
>  	while ((node = find_next_best_node(local_node, &used_mask)) >= 0) {
> 

t480s: ~/git/linux default_online_type $ git grep "nodemask_t " | grep "="
arch/x86/mm/numa.c:     nodemask_t reserved_nodemask = NODE_MASK_NONE;
arch/x86/mm/numa_emulation.c:   nodemask_t physnode_mask = numa_nodes_parsed;
arch/x86/mm/numa_emulation.c:   nodemask_t physnode_mask = numa_nodes_parsed;
arch/x86/mm/numa_emulation.c:           nodemask_t physnode_mask = numa_nodes_parsed;
drivers/acpi/numa/srat.c:static nodemask_t nodes_found_map = NODE_MASK_NONE;
kernel/irq/affinity.c:  nodemask_t nodemsk = NODE_MASK_NONE;
kernel/sched/fair.c:            nodemask_t max_group = NODE_MASK_NONE;
mm/memory_hotplug.c:    nodemask_t nmask = node_states[N_MEMORY];
mm/mempolicy.c:         nodemask_t mems = cpuset_mems_allowed(current);
mm/mempolicy.c: nodemask_t nodes = NODE_MASK_NONE;
mm/oom_kill.c:  const nodemask_t *mask = oc->nodemask;
mm/page_alloc.c:nodemask_t node_states[NR_NODE_STATES] __read_mostly = {
mm/page_alloc.c:        nodemask_t saved_node_state = node_states[N_MEMORY];

Should this be NODE_MASK_NONE?

-- 
Thanks,

David / dhildenb



  parent reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-26 22:24 Wei Yang
2020-03-26 22:24 ` [PATCH 2/2] mm/page_alloc.c: define node_order with all zero Wei Yang
2020-03-26 22:36 ` [PATCH 1/2] mm/page_alloc.c: leverage compiler to zero out used_mask Jason Gunthorpe
2020-03-27 13:27   ` Wei Yang
2020-03-27  9:32 ` David Hildenbrand [this message]
2020-03-27 13:21   ` Wei Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d712ce2d-78a9-afcc-64d4-1102638f2fc0@redhat.com \
    --to=david@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=richard.weiyang@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-mm Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mm/0 linux-mm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mm linux-mm/ https://lore.kernel.org/linux-mm \
		linux-mm@kvack.org
	public-inbox-index linux-mm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kvack.linux-mm


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git