From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCC88C433E2 for ; Thu, 28 May 2020 19:23:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6412B207BC for ; Thu, 28 May 2020 19:23:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="Om+LVat9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6412B207BC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BC12D800B6; Thu, 28 May 2020 15:23:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B6F5F8001A; Thu, 28 May 2020 15:23:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A8480800B6; Thu, 28 May 2020 15:23:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0089.hostedemail.com [216.40.44.89]) by kanga.kvack.org (Postfix) with ESMTP id 8DD398001A for ; Thu, 28 May 2020 15:23:30 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 511D87591 for ; Thu, 28 May 2020 19:23:30 +0000 (UTC) X-FDA: 76867101780.13.tiger23_75dc70fe57213 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id 3162D18140B69 for ; Thu, 28 May 2020 19:23:30 +0000 (UTC) X-HE-Tag: tiger23_75dc70fe57213 X-Filterd-Recvd-Size: 3910 Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by imf10.hostedemail.com (Postfix) with ESMTP for ; Thu, 28 May 2020 19:23:29 +0000 (UTC) Received: by mail-pg1-f194.google.com with SMTP id f21so39480pgg.12 for ; Thu, 28 May 2020 12:23:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=0gA7Ac+73j/XnZFQi1m6vn3pC8smRbdUm5Fe8cbDyhk=; b=Om+LVat92f7RfQwrzgyYFTaU+jb22Q8KiUAmJI9TaxaK/Z2+G02Sv/9APyzywDHAQn Ln7QkPtqftmBgBAB4LCMNXyvhNZcFe8XgdR+LctT7cHTb7V1DqY9dhhRoe985ljMbbmu jnAscOpB5boyeZ/+SkqORtmWOqSkQoGaXxGTGvwSDDd1XkBBBQGdLBLlrKaHV2mH2EMx P/kfVgurkkRRin6rXHRfXKstHnWkUQmCEWiv4r734Ng8gwmHlxhUggxP37jQ0QixIPnG 2WV+sl52+rHWgakZ+AFjDeD7H5Vru2/of/jrruf+PyAE9qImbd6R88VyiHjemZDp27+0 GdJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0gA7Ac+73j/XnZFQi1m6vn3pC8smRbdUm5Fe8cbDyhk=; b=SccHMunP+P/K256rglBp009hz3PIQ9UZZZjpJinaGxXfYbREWEuHQ3LUiAK0ez3wuV rWvHb1P53WbYvRWiS3B8AOm0l6iPCtS3fbBvcezBmUrO8JRJAdVbqtaOu3+omIhEEDL9 dCHBV52mMS4rwQ1KKfD/nY/m23BlcF4vuvs0Eu+Vix/U//T3KrZWGAeSD6JZuhyVoj66 /MkZpa5VS6pptwBI98T6PHPCsJjBNnWvl6NFXyNVmlqWN/UIOLYl4kir3EgoBd8kUVw4 U10BpHIeg0L7XNRyipu9w2mw/Xtc0XwhQZa0phENTSczb4mOPPSVTWbY6lqMQYJzLth2 DSJg== X-Gm-Message-State: AOAM531IIjhLkBXeh3QiMcEkFXaMlkvVa5ar0xhaeR/qeZD1hlkibMI4 rSG5DcDtnlJ3TM7FsfjiHfz4Kg== X-Google-Smtp-Source: ABdhPJxvks363x29yek8RaALXXC0cYu2SwUDsZ1gCb7momK0fY3oVgT+N23LBhPU5BtU9iTGBDhkUg== X-Received: by 2002:a63:c5a:: with SMTP id 26mr4386530pgm.270.1590693808617; Thu, 28 May 2020 12:23:28 -0700 (PDT) Received: from [192.168.1.159] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id t2sm5089134pgh.89.2020.05.28.12.23.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 May 2020 12:23:28 -0700 (PDT) Subject: Re: [PATCH 09/12] xfs: flag files as supporting buffered async reads To: "Darrick J. Wong" Cc: io-uring@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org References: <20200526195123.29053-1-axboe@kernel.dk> <20200526195123.29053-10-axboe@kernel.dk> <20200528175353.GB8204@magnolia> From: Jens Axboe Message-ID: Date: Thu, 28 May 2020 13:23:26 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200528175353.GB8204@magnolia> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 3162D18140B69 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/28/20 11:53 AM, Darrick J. Wong wrote: > On Tue, May 26, 2020 at 01:51:20PM -0600, Jens Axboe wrote: >> XFS uses generic_file_read_iter(), which already supports this. >> >> Signed-off-by: Jens Axboe > > Er... I guess that looks ok? Assuming you've done enough qa on > io_uring to be able to tell if this breaks anything, since touching the > mm always feels murky to me: > The mm bits should be fine, haven't seen anything odd in testing. And it's not like the mm changes are super complicated, I think they turned out pretty clean and straight forward. > Acked-by: Darrick J. Wong Thanks! -- Jens Axboe