From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84FACC47082 for ; Tue, 8 Jun 2021 09:41:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 23DDA610FB for ; Tue, 8 Jun 2021 09:41:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 23DDA610FB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B18D66B006C; Tue, 8 Jun 2021 05:41:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AA1C56B006E; Tue, 8 Jun 2021 05:41:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F40F6B0070; Tue, 8 Jun 2021 05:41:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0068.hostedemail.com [216.40.44.68]) by kanga.kvack.org (Postfix) with ESMTP id 5FF5E6B006C for ; Tue, 8 Jun 2021 05:41:49 -0400 (EDT) Received: from smtpin40.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 05CE3180AD802 for ; Tue, 8 Jun 2021 09:41:49 +0000 (UTC) X-FDA: 78230064738.40.C38C7BA Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf07.hostedemail.com (Postfix) with ESMTP id 14142A0001A9 for ; Tue, 8 Jun 2021 09:41:44 +0000 (UTC) Received: from imap.suse.de (imap-alt.suse-dmz.suse.de [192.168.254.47]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1C572219C0; Tue, 8 Jun 2021 09:41:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1623145307; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HRJmshlKzh06hRuJq6zblAZqJa6EKi5x5hSc419U1NA=; b=2o8p8DznDE8mXnw4gkvTJmmxmIHrK6X0jtY8nCyAN1rR8KzdYeCq4LoBb02Q8xtfkvXrRr f6iAE094/uu1vg2MEWoEZib5g36tkeblVoIDsUSF0QUIihLWytgQedO1ebF7ZF2s6cDpKd t5k4cYHCJQs52+12z6ySLpAWooUNugs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1623145307; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HRJmshlKzh06hRuJq6zblAZqJa6EKi5x5hSc419U1NA=; b=CN1/zWOKjD3oT5SA8p3wGOzPUI8lBXPxUPYYhOD6GZgzdijPkZ/0MeQgohLEtasG4tmuLo m80/hTBReMdxX2Bg== Received: from imap3-int (imap-alt.suse-dmz.suse.de [192.168.254.47]) by imap.suse.de (Postfix) with ESMTP id ED591118DD; Tue, 8 Jun 2021 09:41:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1623145307; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HRJmshlKzh06hRuJq6zblAZqJa6EKi5x5hSc419U1NA=; b=2o8p8DznDE8mXnw4gkvTJmmxmIHrK6X0jtY8nCyAN1rR8KzdYeCq4LoBb02Q8xtfkvXrRr f6iAE094/uu1vg2MEWoEZib5g36tkeblVoIDsUSF0QUIihLWytgQedO1ebF7ZF2s6cDpKd t5k4cYHCJQs52+12z6ySLpAWooUNugs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1623145307; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HRJmshlKzh06hRuJq6zblAZqJa6EKi5x5hSc419U1NA=; b=CN1/zWOKjD3oT5SA8p3wGOzPUI8lBXPxUPYYhOD6GZgzdijPkZ/0MeQgohLEtasG4tmuLo m80/hTBReMdxX2Bg== Received: from director2.suse.de ([192.168.254.72]) by imap3-int with ESMTPSA id dfwOOVo7v2CbZQAALh3uQQ (envelope-from ); Tue, 08 Jun 2021 09:41:46 +0000 Subject: Re: [PATCH v11] mm: slub: move sysfs slab alloc/free interfaces to debugfs To: Faiyaz Mohammed , cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, greg@kroah.com, glittao@gmail.com, andy.shevchenko@gmail.com Cc: vinmenon@codeaurora.org References: <1623141934-7699-1-git-send-email-faiyazm@codeaurora.org> From: Vlastimil Babka Message-ID: Date: Tue, 8 Jun 2021 11:41:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <1623141934-7699-1-git-send-email-faiyazm@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=2o8p8Dzn; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="CN1/zWOK"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=2o8p8Dzn; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="CN1/zWOK"; dmarc=none; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz X-Stat-Signature: otdar839btxihtu1kef6nreyaby6ux4p X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 14142A0001A9 X-HE-Tag: 1623145304-345242 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/8/21 10:45 AM, Faiyaz Mohammed wrote: > alloc_calls and free_calls implementation in sysfs have two issues, > one is PAGE_SIZE limitation of sysfs and other is it does not adhere > to "one value per file" rule. > > To overcome this issues, move the alloc_calls and free_calls > implementation to debugfs. > > Debugfs cache will be created if SLAB_STORE_USER flag is set. > > Rename the alloc_calls/free_calls to alloc_traces/free_traces, > to be inline with what it does. > > Signed-off-by: Faiyaz Mohammed Reviewed-by: Vlastimil Babka Thanks!