From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08436C433F5 for ; Fri, 28 Jan 2022 17:30:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 802A86B0112; Fri, 28 Jan 2022 12:30:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 78A9B6B0114; Fri, 28 Jan 2022 12:30:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 604536B0115; Fri, 28 Jan 2022 12:30:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0065.hostedemail.com [216.40.44.65]) by kanga.kvack.org (Postfix) with ESMTP id 4B2796B0112 for ; Fri, 28 Jan 2022 12:30:56 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 0E3F9181DD43E for ; Fri, 28 Jan 2022 17:30:56 +0000 (UTC) X-FDA: 79080386112.20.3245F1C Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by imf25.hostedemail.com (Postfix) with ESMTP id B4BEBA0010 for ; Fri, 28 Jan 2022 17:30:55 +0000 (UTC) Received: by mail-lf1-f53.google.com with SMTP id z19so13094095lfq.13 for ; Fri, 28 Jan 2022 09:30:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=5GJA2cUd2TCYXeUPgHGgIRWvVU4WCZd/rHlFfGUmSng=; b=E377hvYxX8QvVlmBEXZa2Jdh1SyBKQzj1wweYxTJeQKZzRv0JPbislEPnx7QrLyHEl pbEAcdtTwf1OhRifMLiMaXINEvP6CUR36DPAKcO9GjQRZj23uWU9kNAs1fMV51ANDqyE iq4iB1AKwYtIyg23tlzdegn2cDvCawQizlfUpUh0y+48MARNEVbTGe3gJWKH0HT/86Oy kGG7lAXivyYGVif3F6ErJAsvjOtjc9b37V7zG+9m9T+sjcRuijLGVQVDWhF3knNSomvC 9K08wD9VSR/SLHuOTdQjUsDr44HdmFLrMNf++K4ELbMBZejkVT0sFymDtwp9kIA3gbwA hwYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=5GJA2cUd2TCYXeUPgHGgIRWvVU4WCZd/rHlFfGUmSng=; b=gqgmXE1iWyvhqG0XlEK7BAw6lm0tFbYojn/c7phjAohFfBCvPp/Xu3hVb5C5c7KoBu w34nf+GyvHYgTZ56mm+TdHkwYti1NIoxz+h3o4fDwmPGjfiF0lJUDbwdeXOLvoC2TtUF LVH/EVT2MWQD5cM1S0HxzG17UkiDXebS1Qs/1Yn6XSrqMsFPc5Coe86qeAdCv0vHLgyE vH7k5vlEFt7mE9iO7ZPXvsccD8p3mWbSFdj/ypCE+VMhUC8dXxWGUWJgolKOB24mZHT9 UUk50nssHCH/IFrP+xO7maRZP7h33Zi9PZ/VDipbWGi4rNfkTD6s6NBCxLfcz0Px8UZD ZBSw== X-Gm-Message-State: AOAM533Dl7HOTXmJB4C7bRWsGEk+COze+abqY3tUtPzaXJSQJLVnAbI6 LFDZh4QdxwbZztAMa2Uk3FI= X-Google-Smtp-Source: ABdhPJzp/i6W1p1VqXHbHX1fC5gFzUFzHUBxhqGcN7+IUPSGbKWHGZ//AFlWyN2+V/P4o3Aa31Kxaw== X-Received: by 2002:a05:6512:4010:: with SMTP id br16mr7037217lfb.454.1643391054039; Fri, 28 Jan 2022 09:30:54 -0800 (PST) Received: from [192.168.50.104] (staticline-31-183-164-222.toya.net.pl. [31.183.164.222]) by smtp.gmail.com with ESMTPSA id j13sm1643757lfu.214.2022.01.28.09.30.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jan 2022 09:30:53 -0800 (PST) Message-ID: Subject: Re: [PATCH 01/16] tools: Move gfp.h and slab.h from radix-tree to lib From: Karolina Drobnik To: Matthew Wilcox Cc: linux-mm@kvack.org, akpm@linux-foundation.org, mike.rapoport@gmail.com, linux-kernel@vger.kernel.org Date: Fri, 28 Jan 2022 18:30:52 +0100 In-Reply-To: <4eee8241e35fac1fa05eee3525a10672396c18ec.camel@gmail.com> References: <777d0cfcf531357cfe39d53987aa964a3a42ce8b.1643206612.git.karolinadrobnik@gmail.com> <4eee8241e35fac1fa05eee3525a10672396c18ec.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: B4BEBA0010 X-Stat-Signature: y6dqf79whynnzt9wyxzija1ouk657bbo X-Rspam-User: nil Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=E377hvYx; spf=pass (imf25.hostedemail.com: domain of karolinadrobnik@gmail.com designates 209.85.167.53 as permitted sender) smtp.mailfrom=karolinadrobnik@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1643391055-686999 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.123947, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 2022-01-28 at 12:02 +0100, Karolina Drobnik wrote: > On Thu, 2022-01-27 at 13:36 +0000, Matthew Wilcox wrote: > > I don't think it makes much sense to move kmalloc() and not to move > > the kmem_cache* functions.=C2=A0 They're all provided by slab in the > > kernel > > proper, so while you don't use them, I think keeping all the memory > > allocation functions together is preferable. >=20 > I wasn't sure if these functions would be used by other test suites, > so > I left them here. But I can move them if you think it's better to > keep > them together. >=20 OK, now I can see why this wouldn't work - kmem_cache_alloc and kmem_cache_free operate on radix_tree_node struct, making it specific to this test suite. So, for this patch, I'm going to tidy up the gfp.h header but leave radix-tree/linux.c and lib/slab.c as they are now.