From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4569C54FCB for ; Wed, 22 Apr 2020 22:01:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8CACD2076E for ; Wed, 22 Apr 2020 22:01:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="GKxKz1Zp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8CACD2076E Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3B1D88E0007; Wed, 22 Apr 2020 18:01:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 362718E0003; Wed, 22 Apr 2020 18:01:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2510A8E0007; Wed, 22 Apr 2020 18:01:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0154.hostedemail.com [216.40.44.154]) by kanga.kvack.org (Postfix) with ESMTP id 0AF868E0003 for ; Wed, 22 Apr 2020 18:01:54 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id B3175612F for ; Wed, 22 Apr 2020 22:01:53 +0000 (UTC) X-FDA: 76736864106.04.drain76_84ebb80f17f11 X-HE-Tag: drain76_84ebb80f17f11 X-Filterd-Recvd-Size: 6293 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by imf02.hostedemail.com (Postfix) with ESMTP for ; Wed, 22 Apr 2020 22:01:53 +0000 (UTC) Received: by mail-wr1-f67.google.com with SMTP id k13so4446350wrw.7 for ; Wed, 22 Apr 2020 15:01:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=em+wcShpdUXMOwEuiMKWPovG1hGJ7vnjNO1+x5kgI0M=; b=GKxKz1ZpRtm0Zath9tELAqG/QrfcwqyTN791UFjljwVoF/QYBEfF5W5V877GGat3MF 4a+wKQQkqA6adYYwVLZzyz1N8RXUac6p5fJZq08vBjqmQFrTjYVDL79IV6jj1Qo+LZLQ 3120q21JUFdmW+FqSTo2C7aY1tviiDz+7tJT0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=em+wcShpdUXMOwEuiMKWPovG1hGJ7vnjNO1+x5kgI0M=; b=YiQWsCTaA3kZyTzG9jvKDwtDnagdsyIw3zjeeJnXaRcP/KjpKqLWqzmocVanZt8NiT /5nBKLPB1rsCAq5vTBQA3/9PA/EspWZ5HS0RMLk2yCneuELw1KNZgJT/tY5/KyqGJCQI 4eyIdkPDJV5mO6OvyrSlKGKNEerR2GyfY6zEls6lHkpUOzwpBii6mhecVAE9Q2Ej53VW tI7AF+6aizpCsago2hvwlhoZPIWWAE+aKh2uFYJDNTLLsEPW6DpupJlHDhdxefjIZtrf 7UMorjnZOR1hnDzDqD6HyQrKNU977oCca9ymP+chagxeGP7M5Uru6Dzdxh83l0fE9j1C EuOw== X-Gm-Message-State: AGi0PuYrhTvRVm5JwXtbWvQDkhD5lCj16pTgsuLqrh9U39y/DEmGBkhH WlrPEtnLSUfN054nSIq4ngrlhg== X-Google-Smtp-Source: APiQypKI8k4TySX2HxG45ANUOlTXZ016fEV88ihQ/i/kGs1Reh4zJF1QAgKUNB6iUGMJJTHVq4CGAw== X-Received: by 2002:adf:a309:: with SMTP id c9mr1154684wrb.97.1587592911938; Wed, 22 Apr 2020 15:01:51 -0700 (PDT) Received: from [10.136.13.65] ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id z10sm702728wrg.69.2020.04.22.15.01.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Apr 2020 15:01:50 -0700 (PDT) Subject: Re: [PATCH v3 6/7] misc: bcm-vk: add Broadcom VK driver From: Scott Branden To: Dan Carpenter , kbuild test robot Cc: Luis Chamberlain , Greg Kroah-Hartman , David Brown , Alexander Viro , Shuah Khan , bjorn.andersson@linaro.org, Arnd Bergmann , kbuild-all@lists.01.org, "Rafael J . Wysocki" , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-fsdevel@vger.kernel.org, BCM Kernel Feedback , Olof Johansson , Andrew Morton , Linux Memory Management List , Dan Carpenter References: <20200420162809.17529-7-scott.branden@broadcom.com> <202004221945.LY6x0DQD%lkp@intel.com> <20200422113558.GJ2659@kadam> Message-ID: Date: Wed, 22 Apr 2020 15:01:45 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2020-04-22 9:13 a.m., Scott Branden wrote: > > > On 2020-04-22 4:35 a.m., Dan Carpenter wrote: >> On Wed, Apr 22, 2020 at 07:17:34PM +0800, kbuild test robot wrote: >>> Hi Scott, >>> >>> I love your patch! Perhaps something to improve: >>> >>> [auto build test WARNING on driver-core/driver-core-testing] >>> [also build test WARNING on next-20200421] >>> [cannot apply to char-misc/char-misc-testing kselftest/next=20 >>> linus/master v5.7-rc2] >>> [if your patch is applied to the wrong git tree, please drop us a=20 >>> note to help >>> improve the system. BTW, we also suggest to use '--base' option to=20 >>> specify the >>> base tree in git format-patch, please see=20 >>> https://stackoverflow.com/a/37406982] >>> >>> url:=20 >>> https://github.com/0day-ci/linux/commits/Scott-Branden/firmware-add-p= artial-read-support-in-request_firmware_into_buf/20200422-114528 >>> base:=20 >>> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.gi= t=20 >>> 55623260bb33e2ab849af76edf2253bc04cb241f >>> reproduce: >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # apt-get install sp= arse >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # sparse version: v0= .6.1-191-gc51a0382-dirty >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 make ARCH=3Dx86_64 a= llmodconfig >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 make C=3D1 CF=3D'-fd= iagnostic-prefix -D__CHECK_ENDIAN__' >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^^^^^^^^^^^^^^^^^^^ >> >> Sorry, you asked me about this earlier.=C2=A0 You will need to add >> -D__CHECK_ENDIAN__ to enable these Sparse warnings. > This is strange.=C2=A0 I ran the sparse build and thought I had fixed a= ll=20 > the issues. > I'll have to try again. > > One other question with the sparse build.=C2=A0 I get many of the messa= ges=20 > printed but the build seems to go to the end (even without my patches=20 > applied): > ./arch/x86/include/asm/paravirt.h:333:9: error: got __inline > ./arch/x86/include/asm/paravirt.h:338:9: error: Expected ( after asm > ./arch/x86/include/asm/paravirt.h:338:9: error: got __inline > ./arch/x86/include/asm/paravirt.h:343:9: error: Expected ( after asm > ./arch/x86/include/asm/paravirt.h:343:9: error: got __inline > ./arch/x86/include/asm/paravirt.h:348:9: error: Expected ( after asm > ./arch/x86/include/asm/paravirt.h:348:9: error: too many errors > > Any way to suppress or I am doing something wrong?=C2=A0 I just run the= 2=20 > make commands: > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 make ARCH=3Dx86_64 allmodcon= fig > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 make C=3D1 CF=3D'-fdiagnosti= c-prefix -D__CHECK_ENDIAN__' I figured out the sparse utility on ubuntu 18.04 is out of date causing=20 the issue. > >> regards, >> dan carpenter >> >