From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F5DDC10F29 for ; Tue, 17 Mar 2020 17:10:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E326B20735 for ; Tue, 17 Mar 2020 17:10:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="e0QELHa5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E326B20735 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6227F6B0005; Tue, 17 Mar 2020 13:10:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D1B66B0006; Tue, 17 Mar 2020 13:10:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C0776B0007; Tue, 17 Mar 2020 13:10:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 34EAA6B0005 for ; Tue, 17 Mar 2020 13:10:00 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 1A3B4181AC9CB for ; Tue, 17 Mar 2020 17:10:00 +0000 (UTC) X-FDA: 76605491760.14.cent99_91749c565aa1d X-HE-Tag: cent99_91749c565aa1d X-Filterd-Recvd-Size: 5446 Received: from userp2130.oracle.com (userp2130.oracle.com [156.151.31.86]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Tue, 17 Mar 2020 17:09:59 +0000 (UTC) Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 02HH8rSW103617; Tue, 17 Mar 2020 17:09:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=MUKPIBA0PDdbrvWj4pjo/RZXdu0E5DptRou2F8z9uCo=; b=e0QELHa5F5vIaddPdvy3zHozX4NFti7jKHgwf+w1aIL9JfSl6xUwcLanY87VwkB/WleD Q8kC42HPY0CRHittaWie/sal6gpWmUyFDJtKHIgNEFd8W/Yp1lTrSNC3FEMD5nxeKr+D K68XEpL2Vn4o52d9MrSIS1kfqEjHJxVLLP1T+HL7LDxMaoKJr6g+wWaedI8DWeCHdzIf +ciogrQc8nAkfa3/FotzsSWwCm96RtqUybrEii87q7TR9O7fMEtINtsNcanK4xofl10l Py08khscEwk8Xp2EFitV+TjdsdpBlF1SpD8vSRjhLxDEm1Eu43Ou69SwH1ny4T3IlLw4 Mg== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2130.oracle.com with ESMTP id 2yrppr68ct-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 17 Mar 2020 17:09:52 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 02HGofcR015199; Tue, 17 Mar 2020 17:07:51 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3030.oracle.com with ESMTP id 2ys8rf9ew4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 17 Mar 2020 17:07:51 +0000 Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 02HH7ocw005107; Tue, 17 Mar 2020 17:07:50 GMT Received: from [192.168.1.206] (/71.63.128.209) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 17 Mar 2020 10:07:50 -0700 Subject: Re: [PATCH] mm/hugetlb: Fix build failure with HUGETLB_PAGE but not HUGEBTLBFS To: Christophe Leroy , Baoquan He Cc: Andrew Morton , Nishanth Aravamudan , Nick Piggin , Adam Litke , Andi Kleen , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org References: <7e8c3a3c9a587b9cd8a2f146df32a421b961f3a2.1584432148.git.christophe.leroy@c-s.fr> <20200317082550.GA3375@MiWiFi-R3L-srv> <60117fd7-46ff-326b-34f1-0c7087111ca7@c-s.fr> From: Mike Kravetz Message-ID: Date: Tue, 17 Mar 2020 10:07:48 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9563 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 phishscore=0 malwarescore=0 mlxscore=0 mlxlogscore=999 adultscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2003170068 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9563 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 suspectscore=0 lowpriorityscore=0 phishscore=0 adultscore=0 clxscore=1015 impostorscore=0 priorityscore=1501 spamscore=0 mlxlogscore=999 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2003170068 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/17/20 9:47 AM, Christophe Leroy wrote: >=20 >=20 > Le 17/03/2020 =C3=A0 17:40, Mike Kravetz a =C3=A9crit : >> On 3/17/20 1:43 AM, Christophe Leroy wrote: >>> >>> >>> Le 17/03/2020 =C3=A0 09:25, Baoquan He a =C3=A9crit : >>>> On 03/17/20 at 08:04am, Christophe Leroy wrote: >>>>> When CONFIG_HUGETLB_PAGE is set but not CONFIG_HUGETLBFS, the >>>>> following build failure is encoutered: >>>> >>>> From the definition of HUGETLB_PAGE, isn't it relying on HUGETLBFS= ? >>>> I could misunderstand the def_bool, please correct me if I am wrong. >>> >>> AFAIU, it means that HUGETLBFS rely on HUGETLB_PAGE, by default HUGET= LB_PAGE is not selected when HUGETLBFS is not. But it is still possible f= or an arch to select HUGETLB_PAGE without selecting HUGETLBFS when it use= s huge pages for other purpose than hugetlb file system. >>> >> >> Hi Christophe, >> >> Do you actually have a use case/example of using hugetlb pages without >> hugetlbfs? I can understand that there are some use cases which never >> use the filesystem interface. However, hugetlb support is so intertwi= ned >> with hugetlbfs, I am thinking there would be issues trying to use them >> separately. I will look into this further. >> >=20 > Hi Mike, >=20 > Series https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=3D= 164620 >=20 > And especially patch 39 to 41. >=20 Ah, ok. You are simply using a few interfaces in the hugetlb header file= s. The huge pages created in your mappings are not PageHuge() pages. --=20 Mike Kravetz