From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C715C433DB for ; Tue, 23 Mar 2021 10:24:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 321A0619AE for ; Tue, 23 Mar 2021 10:24:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 321A0619AE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BF8876B0143; Tue, 23 Mar 2021 06:24:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BCF346B0145; Tue, 23 Mar 2021 06:24:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A6F296B0147; Tue, 23 Mar 2021 06:24:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0208.hostedemail.com [216.40.44.208]) by kanga.kvack.org (Postfix) with ESMTP id 8DFF46B0143 for ; Tue, 23 Mar 2021 06:24:00 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 474B2180AD822 for ; Tue, 23 Mar 2021 10:24:00 +0000 (UTC) X-FDA: 77950753440.03.8B2FD93 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf19.hostedemail.com (Postfix) with ESMTP id F0B4990009D6 for ; Tue, 23 Mar 2021 10:23:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616495039; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PLZ5nMEJ4tec7irmbW0K+juMgN+jQFrKCu8kDdRqTRs=; b=iprKI4929KTE0cyxaLbcVnbmdjbYMxUdYi7hLJchMxmxie+k4k/hnfCY4vGQI6WB7rsWvQ RyKRugw67JrDT7OTEmK1xL4eVIcOEurl5p8q6fpvhtE13Hg1c+925J4yS0bmeVPJQT/f1H S4bzq7lpEXS13xLCxauN18S2pmNNDpA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-237-SVjAu0dwMkmQxUsQ-RPp5Q-1; Tue, 23 Mar 2021 06:23:57 -0400 X-MC-Unique: SVjAu0dwMkmQxUsQ-RPp5Q-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EE5958015BD; Tue, 23 Mar 2021 10:23:55 +0000 (UTC) Received: from [10.36.115.54] (ovpn-115-54.ams2.redhat.com [10.36.115.54]) by smtp.corp.redhat.com (Postfix) with ESMTP id 939CA59452; Tue, 23 Mar 2021 10:23:54 +0000 (UTC) Subject: Re: [PATCH 2/5] mm/migrate.c: remove unnecessary rc != MIGRATEPAGE_SUCCESS check in 'else' case To: Miaohe Lin , akpm@linux-foundation.org Cc: jglisse@redhat.com, shy828301@gmail.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20210320093701.12829-1-linmiaohe@huawei.com> <20210320093701.12829-3-linmiaohe@huawei.com> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: Date: Tue, 23 Mar 2021 11:23:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210320093701.12829-3-linmiaohe@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: F0B4990009D6 X-Stat-Signature: xhgq184qygd1jbefwhdc7wnypigo1bd5 Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf19; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=216.205.24.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616495038-605265 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 20.03.21 10:36, Miaohe Lin wrote: > It's guaranteed that in the 'else' case of the rc == MIGRATEPAGE_SUCCESS > check, rc does not equal to MIGRATEPAGE_SUCCESS. Remove this unnecessary > check. > > Signed-off-by: Miaohe Lin > --- > mm/migrate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index e4ca5ef508ea..20a3bf75270a 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -1374,7 +1374,7 @@ static int unmap_and_move_huge_page(new_page_t get_new_page, > out: > if (rc == MIGRATEPAGE_SUCCESS) > putback_active_hugepage(hpage); > - else if (rc != -EAGAIN && rc != MIGRATEPAGE_SUCCESS) > + else if (rc != -EAGAIN) > list_move_tail(&hpage->lru, ret); > > /* > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb