From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F467C433DB for ; Wed, 24 Feb 2021 17:56:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 89E4E64ECB for ; Wed, 24 Feb 2021 17:56:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 89E4E64ECB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C73A56B0005; Wed, 24 Feb 2021 12:56:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C22706B0006; Wed, 24 Feb 2021 12:56:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B5F6D6B006C; Wed, 24 Feb 2021 12:56:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0028.hostedemail.com [216.40.44.28]) by kanga.kvack.org (Postfix) with ESMTP id A1E956B0005 for ; Wed, 24 Feb 2021 12:56:19 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 6446D18144F7C for ; Wed, 24 Feb 2021 17:56:19 +0000 (UTC) X-FDA: 77853915678.18.8B721D6 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by imf26.hostedemail.com (Postfix) with ESMTP id D13E04080F46 for ; Wed, 24 Feb 2021 17:56:13 +0000 (UTC) IronPort-SDR: 1noHdXgdXt7373CfoJ0l9GbG2qYbEPLd67u8vVlT+rycaL9GZiUdoYA/6gbszS/vZXKANQJbOn HM17WhVO423w== X-IronPort-AV: E=McAfee;i="6000,8403,9905"; a="181828478" X-IronPort-AV: E=Sophos;i="5.81,203,1610438400"; d="scan'208";a="181828478" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2021 09:56:15 -0800 IronPort-SDR: YqNXWLdfdbMrk/tJAmUlXvygcJmEDG35gmknOvPRHqoirvT4udUb1v+3bX1fFs6ZUJKV/Imeip XRSLDAYPVYUw== X-IronPort-AV: E=Sophos;i="5.81,203,1610438400"; d="scan'208";a="391684126" Received: from yyu32-mobl1.amr.corp.intel.com (HELO [10.212.35.50]) ([10.212.35.50]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2021 09:56:14 -0800 Subject: Re: [PATCH v21 06/26] x86/cet: Add control-protection fault handler To: Borislav Petkov Cc: x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue , Dave Martin , Weijiang Yang , Pengfei Xu , Haitao Huang , Michael Kerrisk References: <20210217222730.15819-1-yu-cheng.yu@intel.com> <20210217222730.15819-7-yu-cheng.yu@intel.com> <20210224161343.GE20344@zn.tnic> <32ac05ef-b50b-c947-095d-bc31a42947a3@intel.com> <20210224165332.GF20344@zn.tnic> From: "Yu, Yu-cheng" Message-ID: Date: Wed, 24 Feb 2021 09:56:13 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210224165332.GF20344@zn.tnic> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Stat-Signature: x3pewxhjtcpsmnng5tcm8orrdprg698j X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: D13E04080F46 Received-SPF: none (intel.com>: No applicable sender policy available) receiver=imf26; identity=mailfrom; envelope-from=""; helo=mga11.intel.com; client-ip=192.55.52.93 X-HE-DKIM-Result: none/none X-HE-Tag: 1614189373-366565 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/24/2021 8:53 AM, Borislav Petkov wrote: > On Wed, Feb 24, 2021 at 08:44:45AM -0800, Yu, Yu-cheng wrote: >>>> + force_sig_fault(SIGSEGV, SEGV_CPERR, >>>> + (void __user *)uprobe_get_trap_addr(regs)); >>> >>> Why is this calling an uprobes function? >>> >> >> I will change it to error_get_trap_addr(). > > "/* > * Posix requires to provide the address of the faulting instruction for > * SIGILL (#UD) and SIGFPE (#DE) in the si_addr member of siginfo_t. > ..." > > Is yours SIGILL or SIGFPE? > No. Maybe I am doing too much. The GP fault sets si_addr to zero, for example. So maybe do the same here?