From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87387C433F5 for ; Thu, 14 Oct 2021 07:20:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2F9C760ED4 for ; Thu, 14 Oct 2021 07:20:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2F9C760ED4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csgroup.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id BC2D694001F; Thu, 14 Oct 2021 03:20:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B72B594001C; Thu, 14 Oct 2021 03:20:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A61AD94001F; Thu, 14 Oct 2021 03:20:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0129.hostedemail.com [216.40.44.129]) by kanga.kvack.org (Postfix) with ESMTP id 96F9D94001C for ; Thu, 14 Oct 2021 03:20:36 -0400 (EDT) Received: from smtpin32.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 5CF623017C for ; Thu, 14 Oct 2021 07:20:36 +0000 (UTC) X-FDA: 78694195272.32.4F7C181 Received: from pegase2.c-s.fr (pegase2.c-s.fr [93.17.235.10]) by imf27.hostedemail.com (Postfix) with ESMTP id EF85C70000A0 for ; Thu, 14 Oct 2021 07:20:34 +0000 (UTC) Received: from localhost (mailhub3.si.c-s.fr [172.26.127.67]) by localhost (Postfix) with ESMTP id 4HVLQp2MNRz9sSL; Thu, 14 Oct 2021 09:20:34 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from pegase2.c-s.fr ([172.26.127.65]) by localhost (pegase2.c-s.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jxIK-CDZ4PWD; Thu, 14 Oct 2021 09:20:34 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase2.c-s.fr (Postfix) with ESMTP id 4HVLQp1W5Tz9sSK; Thu, 14 Oct 2021 09:20:34 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 1D58A8B788; Thu, 14 Oct 2021 09:20:34 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id SMTWv46bj1yk; Thu, 14 Oct 2021 09:20:34 +0200 (CEST) Received: from PO20335.IDSI0.si.c-s.fr (unknown [192.168.202.231]) by messagerie.si.c-s.fr (Postfix) with ESMTP id EDB608B763; Thu, 14 Oct 2021 09:20:32 +0200 (CEST) Subject: Re: [PATCH v1 04/10] asm-generic: Use HAVE_DEREFERENCE_FUNCTION_DESCRIPTOR to define associated stubs To: Kees Cook Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Andrew Morton , "James E.J. Bottomley" , Helge Deller , Arnd Bergmann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org References: <8db2a3ca2b26a8325c671baa3e0492914597f079.1633964380.git.christophe.leroy@csgroup.eu> <202110122359.E59B90A@keescook> From: Christophe Leroy Message-ID: Date: Thu, 14 Oct 2021 09:20:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <202110122359.E59B90A@keescook> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr-FR X-Rspamd-Queue-Id: EF85C70000A0 X-Stat-Signature: ont6mrj74hjf3dp5y5ekksontuh6ydu9 Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf27.hostedemail.com: domain of christophe.leroy@csgroup.eu designates 93.17.235.10 as permitted sender) smtp.mailfrom=christophe.leroy@csgroup.eu X-Rspamd-Server: rspam02 X-HE-Tag: 1634196034-263441 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Le 13/10/2021 =C3=A0 09:00, Kees Cook a =C3=A9crit=C2=A0: > On Mon, Oct 11, 2021 at 05:25:31PM +0200, Christophe Leroy wrote: >> Use HAVE_DEREFERENCE_FUNCTION_DESCRIPTOR instead of 'dereference_funct= ion_descriptor' >> to know whether arch has function descriptors. >> >> Signed-off-by: Christophe Leroy >=20 > I'd mention the intentionally-empty #if/#else in the commit log, as I, > like Helge, mentally tripped over it in the review. :) >=20 > Reviewed-by: Kees Cook >=20 Ok, I did it in v2. I also renamed it HAVE_FUNCTION_DESCRIPTORS because behind the fact that=20 it has some functions to dereference function descriptor, the main fact=20 is that they have and use function descriptors. Christophe