From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A691C4361A for ; Sat, 5 Dec 2020 18:09:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 941BC23135 for ; Sat, 5 Dec 2020 18:09:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 941BC23135 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D66676B005C; Sat, 5 Dec 2020 13:09:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CF0276B005D; Sat, 5 Dec 2020 13:09:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB8CA6B0068; Sat, 5 Dec 2020 13:09:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0216.hostedemail.com [216.40.44.216]) by kanga.kvack.org (Postfix) with ESMTP id A29C46B005C for ; Sat, 5 Dec 2020 13:09:47 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 66B59180AD804 for ; Sat, 5 Dec 2020 18:09:47 +0000 (UTC) X-FDA: 77560016814.11.vein37_0e06e23273cf Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin11.hostedemail.com (Postfix) with ESMTP id 4B9FA180F8B81 for ; Sat, 5 Dec 2020 18:09:47 +0000 (UTC) X-HE-Tag: vein37_0e06e23273cf X-Filterd-Recvd-Size: 3841 Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) by imf36.hostedemail.com (Postfix) with ESMTP for ; Sat, 5 Dec 2020 18:09:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1607191783; bh=N9GCg08J3ohLvADFQt7oqTVcLqSFg7TB3duyllzNQY8=; h=X-UI-Sender-Class:Subject:From:To:Cc:Date:In-Reply-To:References; b=CnjXJ9PIyGR7XOpJGYpOJp3PyyesqIj6PCNpw1QE4t52DWxjJHyWrGRbW0s/YVrBA Rn/mcrCFG0Hq0ksp7SFItfAYy5xRTIFlSKsvordBAgxOMkgls0jnaCsIWjrkpVhLn7 qA2LzQtFhaTfK0XFNLrBlE5MRl/ugaXElwvHeWH8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from homer.fritz.box ([185.221.149.242]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MfHAB-1kDfAK3OcV-00gqDa; Sat, 05 Dec 2020 19:09:43 +0100 Message-ID: Subject: Re: [PATCH] z3fold: stricter locking and more careful reclaim From: Mike Galbraith To: Vitaly Wool Cc: Linux-MM , Sebastian Andrzej Siewior , Andrew Morton Date: Sat, 05 Dec 2020 19:09:42 +0100 In-Reply-To: References: <20201204200408.35009-1-vitaly.wool@konsulko.com> <3b8e33c3ba44e7ec4c090d68972015ef52ba1e7e.camel@gmx.de> Content-Type: text/plain; charset="ISO-8859-15" User-Agent: Evolution 3.34.4 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:hxKy+87dA6nEDJJeBfkXmW6tziFn+N74xF3emTc8gZLjUwac8wv Elau0bGNl1vRjv0BzbPJfB9+JKAKyD3KNxlkNPkiHRy94QZBEnrAoOsfP7bZl43kDs8geez b5Ci1ASl+MY1bp5ad5oGNAjgVxx+ONswwBuJJbuJ4XaZglVvmwpC4TdXvJdK6jKpiWgr6zB smlGW+F05f5aOWQN9/+2Q== X-UI-Out-Filterresults: notjunk:1;V03:K0:ERk84Bv2IJc=:nqXh5hhDOlKCK6dGF56mfs FF6wQymXEfSGvnC3DBtPm+eeIx9QNhbS9tY69M38/+bPPMt87F6at4Nc7c0iutGa5D4xf71uU TkUjsHC5NIhyK4sskaYmFYyABvx8tvvoesTyPhj2BryfcvBaLiN8J0TmwEoOTe2ogQUkC0JfK nw3W385vR7oYC/zTXVMpSLy4O9XKImGnxY0QK05P1BCNzVgcM69EwI3LUV4pR19u2jhH+Aoz3 Aj6YNKztnJXyBqknValQZyEiR3WDTzhLXsQs0L/HeLrUzq+LXD2SUSq/Pkj4AT+jinqdI8GiS fmjIXU85eCAfESv/M68hZttWwHzGxKk9+XzrS8AxIWOZUvjeV3GPpZhNdcoENtZdEgx/njbi2 PQ2Uug65Nz3IGJnjB+jhkdSGDcGGOusrCfLziAd7BqdegSlae8ASozeLEbsFRq0u5CEdPGW3H 1dvE/l/CoDwOu+07PKUfb3ouFd+UfAnfT3Vje0ePldeS3NDBSyl4jyNr/QDFrslFSvm8SLMsa c35qlx7OKCkB8SPlBYQzg76cvB6a/i+vnxB/iKQCmPRlmJJos7AWG1W38xmdytIxFUQwuYlrR Dnb8regSB7+0SItFRUSLzV5zxyFPcbCygxghIfR/SnphrtnHYGGwZj3xpS0zGovWX0RXLL8Ip zEqgYMt2qLvHV5D1gWcy0QmsqTfhdBVkl8XFHdnshCiUCLUZrh8VQBbE7n363smGtb09YufAs waVW6bOo9cObb/Keom5KaDUfN2NSkEZiXNNEwAllG1X9uhQdGPQ9h+YmU8hfhGSOaM4VbQpzN XevqiQSc0+lCQgr67zQ5Irr4ZoO4/ggA+WI+uIqcTAM7YBlQuqzbP0Ao5AmaZzKwy491DR1cA ZqRpp7uuY+2kZlLHObCQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 2020-12-05 at 12:38 +0100, Vitaly Wool wrote: > On Fri, Dec 4, 2020 at 10:47 PM Mike Galbraith wrote: > > > > On Fri, 2020-12-04 at 22:04 +0200, Vitaly Wool wrote: > > > Use temporary slots in reclaim function to avoid possible race when > > > freeing those. > > > > > > While at it, make sure we check CLAIMED flag under page lock in the > > > reclaim function to make sure we are not racing with z3fold_alloc(). > > > > > > Signed-off-by: Vitaly Wool > > > > FYI, with this applied, ltp::mm still crashes the RT kernel, with the > > same rwlock corruption being what takes it down. > > So sad it does, but thanks a lot for the quick response. Thanks for taking a poke at it. Intuitive switch to write_lock() in __release_z3fold_page() "fixed" the darn thing, but staring at it since has yet to inspire a clear "and that works because...". -Mike