From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37192C2BA19 for ; Mon, 13 Apr 2020 17:54:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id ED99D20732 for ; Mon, 13 Apr 2020 17:54:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="eetnw4pY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED99D20732 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7E8C98E0130; Mon, 13 Apr 2020 13:54:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 79A228E0104; Mon, 13 Apr 2020 13:54:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6AE838E0130; Mon, 13 Apr 2020 13:54:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0134.hostedemail.com [216.40.44.134]) by kanga.kvack.org (Postfix) with ESMTP id 555488E0104 for ; Mon, 13 Apr 2020 13:54:57 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 15D94181AEF23 for ; Mon, 13 Apr 2020 17:54:57 +0000 (UTC) X-FDA: 76703582634.17.meat69_482231f8e4d56 X-HE-Tag: meat69_482231f8e4d56 X-Filterd-Recvd-Size: 4240 Received: from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com [216.228.121.64]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Mon, 13 Apr 2020 17:54:55 +0000 (UTC) Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Mon, 13 Apr 2020 10:53:57 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Mon, 13 Apr 2020 10:54:54 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Mon, 13 Apr 2020 10:54:54 -0700 Received: from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 13 Apr 2020 17:54:54 +0000 Received: from [10.26.73.38] (10.124.1.5) by DRHQMAIL107.nvidia.com (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 13 Apr 2020 17:54:51 +0000 Subject: Re: [patch 32/35] drivers/dma/tegra20-apb-dma.c: fix platform_get_irq.cocci warnings To: Andrew Morton , , , , , , , , , , References: <20200410213403.Hq3FxdN1e%akpm@linux-foundation.org> From: Jon Hunter Message-ID: Date: Mon, 13 Apr 2020 18:54:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200410213403.Hq3FxdN1e%akpm@linux-foundation.org> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To DRHQMAIL107.nvidia.com (10.27.9.16) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1586800437; bh=yHHdEwH4MERVu8WjmYQ7nEMRJJpWDRF8n1OCj/JoKRo=; h=X-PGP-Universal:Subject:To:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=eetnw4pYf+ppQe6J9wFzsbNvrWJKR96bbii4/IsRNclFdEnDIhOhZUmKfMb4/ILBf 8iFc1sw5iKNJd0N+fr8o0Xq9Zjw5x9xC/XiUYLo9VDRphNeSYGJr7JhntIpCJDWLtA iBJKkkw8cL5P+5EO3SWAms4OP8V5h6QuvPJySY4mQ+xsMadt4dLhW/Vu8O3jb26Ded AULSu3TkuQr4P10dK7X7TeSD1NH+RTPrmapoHREeJ8BEAPRgrBsfsok2PZmjuoFfMI +MeWwaBvsWQJNpixmpZObuP7yEnxq7qzxt2hlY2WcBnKxOxRr+kTc/gr8NBIh7ouxS LNQtIGN6cuSJA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/04/2020 22:34, Andrew Morton wrote: > From: kbuild test robot > Subject: drivers/dma/tegra20-apb-dma.c: fix platform_get_irq.cocci warnings > > Remove dev_err() messages after platform_get_irq*() failures. > platform_get_irq() already prints an error. > > Generated by: scripts/coccinelle/api/platform_get_irq.cocci > > Link: http://lkml.kernel.org/r/alpine.DEB.2.21.2002271133450.2973@hadrien > Fixes: 6c41ac96ad92 ("dmaengine: tegra-apb: Support COMPILE_TEST") > Signed-off-by: kbuild test robot > Signed-off-by: Julia Lawall > Reviewed-by: Dmitry Osipenko > Acked-by: Thierry Reding > Cc: Laxman Dewangan > Cc: Vinod Koul > Cc: Stephen Warren > Cc: Jon Hunter > Signed-off-by: Andrew Morton > --- > > drivers/dma/tegra20-apb-dma.c | 1 - > 1 file changed, 1 deletion(-) > > --- a/drivers/dma/tegra20-apb-dma.c~dmaengine-tegra-apb-fix-platform_get_irqcocci-warnings > +++ a/drivers/dma/tegra20-apb-dma.c > @@ -1493,7 +1493,6 @@ static int tegra_dma_probe(struct platfo > irq = platform_get_irq(pdev, i); > if (irq < 0) { > ret = irq; > - dev_err(&pdev->dev, "No irq resource for chan %d\n", i); > goto err_pm_disable; > } > Thanks! Acked-by: Jon Hunter Cheers Jon -- nvpublic