linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Anshuman Khandual <anshuman.khandual@arm.com>
To: Randy Dunlap <rdunlap@infradead.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	broonie@kernel.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	linux-next@vger.kernel.org, mhocko@suse.cz,
	mm-commits@vger.kernel.org, sfr@canb.auug.org.au
Subject: Re: mmotm 2020-07-08-19-28 uploaded (mm/migrate.c)
Date: Thu, 9 Jul 2020 09:26:55 +0530	[thread overview]
Message-ID: <dc6430f5-19e6-2957-1060-1b43c67996be@arm.com> (raw)
In-Reply-To: <11c5e928-1227-286d-ef7d-6d6e554747db@infradead.org>



On 07/09/2020 09:17 AM, Randy Dunlap wrote:
> On 7/8/20 7:29 PM, Andrew Morton wrote:
>> The mm-of-the-moment snapshot 2020-07-08-19-28 has been uploaded to
>>
>>    http://www.ozlabs.org/~akpm/mmotm/
>>
>> mmotm-readme.txt says
>>
>> README for mm-of-the-moment:
>>
>> http://www.ozlabs.org/~akpm/mmotm/
>>
>> This is a snapshot of my -mm patch queue.  Uploaded at random hopefully
>> more than once a week.
>>
> 
> on i386:
> 
> CONFIG_MIGRATION=y
> # CONFIG_TRANSPARENT_HUGEPAGE is not set
> 
> ../mm/migrate.c: In function ‘migrate_pages’:
> ../mm/migrate.c:1528:19: error: ‘THP_MIGRATION_SUCCESS’ undeclared (first use in this function); did you mean ‘PGMIGRATE_SUCCESS’?
>    count_vm_events(THP_MIGRATION_SUCCESS, nr_thp_succeeded);
>                    ^~~~~~~~~~~~~~~~~~~~~
>                    PGMIGRATE_SUCCESS
> ../mm/migrate.c:1528:19: note: each undeclared identifier is reported only once for each function it appears in
> ../mm/migrate.c:1530:19: error: ‘THP_MIGRATION_FAILURE’ undeclared (first use in this function); did you mean ‘THP_MIGRATION_SUCCESS’?
>    count_vm_events(THP_MIGRATION_FAILURE, nr_thp_failed);
>                    ^~~~~~~~~~~~~~~~~~~~~
>                    THP_MIGRATION_SUCCESS
> ../mm/migrate.c:1532:19: error: ‘THP_MIGRATION_SPLIT’ undeclared (first use in this function); did you mean ‘THP_MIGRATION_FAILURE’?
>    count_vm_events(THP_MIGRATION_SPLIT, nr_thp_split);
>                    ^~~~~~~~~~~~~~~~~~~
>                    THP_MIGRATION_FAILURE

These events should always be available without any config dependency
including CONFIG_TRANSPARENT_HUGEPAGE. Will fix this and update the
patch.


  reply	other threads:[~2020-07-09  3:57 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-03 22:14 incoming Andrew Morton
2020-07-03 22:15 ` [patch 1/5] mm/hugetlb.c: fix pages per hugetlb calculation Andrew Morton
2020-07-03 22:15 ` [patch 2/5] samples/vfs: avoid warning in statx override Andrew Morton
2020-07-03 22:15 ` [patch 3/5] mm/cma.c: use exact_nid true to fix possible per-numa cma leak Andrew Morton
2020-07-03 22:15 ` [patch 4/5] vmalloc: fix the owner argument for the new __vmalloc_node_range callers Andrew Morton
2020-07-03 22:15 ` [patch 5/5] mm/page_alloc: fix documentation error Andrew Morton
2020-07-07  1:53 ` mmotm 2020-07-06-18-53 uploaded Andrew Morton
2020-07-07  5:44   ` mmotm 2020-07-06-18-53 uploaded (sound/soc/amd/renoir/rn-pci-acp3x.c:) Randy Dunlap
2020-07-07  6:15     ` Mukunda,Vijendar
2020-07-07  6:08       ` Randy Dunlap
2020-07-07 10:50         ` Mukunda,Vijendar
2020-07-09  2:29 ` mmotm 2020-07-08-19-28 uploaded Andrew Morton
2020-07-09  3:47   ` mmotm 2020-07-08-19-28 uploaded (mm/migrate.c) Randy Dunlap
2020-07-09  3:56     ` Anshuman Khandual [this message]
2020-07-10  4:00 ` mmotm 2020-07-09-21-00 uploaded Andrew Morton
2020-07-10 17:40   ` mmotm 2020-07-09-21-00 uploaded (drivers/net/ethernet/mellanox/mlx5/core/en_main.c) Randy Dunlap
2020-07-13  4:02     ` Stephen Rothwell
2020-07-13  4:17       ` Randy Dunlap
2020-07-14 23:58         ` Saeed Mahameed
2020-07-14  2:49 ` mmotm 2020-07-13-19-49 uploaded Andrew Morton
2020-07-17  5:53 ` mmotm 2020-07-16-22-52 uploaded Andrew Morton
2020-07-17 15:30   ` mmotm 2020-07-16-22-52 uploaded (net: IPVS) Randy Dunlap
2020-07-18  1:27     ` Stephen Rothwell
2020-07-17 15:35   ` mmotm 2020-07-16-22-52 uploaded (mm/hugetlb.c) Randy Dunlap
2020-07-18  1:32     ` Stephen Rothwell
2020-07-21  2:07 ` mmotm 2020-07-20-19-06 uploaded Andrew Morton
2020-07-21  6:09   ` mmotm 2020-07-20-19-06 uploaded (net/ipv6/ip6_vti.o) Randy Dunlap
2020-07-21  6:14     ` Steffen Klassert
2020-07-21  6:54     ` Stephen Rothwell
2020-07-21  6:55       ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dc6430f5-19e6-2957-1060-1b43c67996be@arm.com \
    --to=anshuman.khandual@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=broonie@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-next@vger.kernel.org \
    --cc=mhocko@suse.cz \
    --cc=mm-commits@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=sfr@canb.auug.org.au \
    --subject='Re: mmotm 2020-07-08-19-28 uploaded (mm/migrate.c)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox