From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67115C433E0 for ; Thu, 9 Jul 2020 03:57:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0D59B20786 for ; Thu, 9 Jul 2020 03:57:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D59B20786 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6E94F6B0003; Wed, 8 Jul 2020 23:57:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C9D96B0005; Wed, 8 Jul 2020 23:57:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5AFC06B0006; Wed, 8 Jul 2020 23:57:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0103.hostedemail.com [216.40.44.103]) by kanga.kvack.org (Postfix) with ESMTP id 46C636B0003 for ; Wed, 8 Jul 2020 23:57:38 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id CAAFF1EE6 for ; Thu, 9 Jul 2020 03:57:37 +0000 (UTC) X-FDA: 77017178154.17.crack84_1814ec626ec2 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin17.hostedemail.com (Postfix) with ESMTP id 983FB180D0185 for ; Thu, 9 Jul 2020 03:57:37 +0000 (UTC) X-HE-Tag: crack84_1814ec626ec2 X-Filterd-Recvd-Size: 3141 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Thu, 9 Jul 2020 03:57:37 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2392F31B; Wed, 8 Jul 2020 20:57:36 -0700 (PDT) Received: from [192.168.0.129] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CC4053F71E; Wed, 8 Jul 2020 20:57:32 -0700 (PDT) Subject: Re: mmotm 2020-07-08-19-28 uploaded (mm/migrate.c) To: Randy Dunlap , Andrew Morton , broonie@kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-next@vger.kernel.org, mhocko@suse.cz, mm-commits@vger.kernel.org, sfr@canb.auug.org.au References: <20200709022901.FTEvQ122j%akpm@linux-foundation.org> <11c5e928-1227-286d-ef7d-6d6e554747db@infradead.org> From: Anshuman Khandual Message-ID: Date: Thu, 9 Jul 2020 09:26:55 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <11c5e928-1227-286d-ef7d-6d6e554747db@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Rspamd-Queue-Id: 983FB180D0185 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 07/09/2020 09:17 AM, Randy Dunlap wrote: > On 7/8/20 7:29 PM, Andrew Morton wrote: >> The mm-of-the-moment snapshot 2020-07-08-19-28 has been uploaded to >> >> http://www.ozlabs.org/~akpm/mmotm/ >> >> mmotm-readme.txt says >> >> README for mm-of-the-moment: >> >> http://www.ozlabs.org/~akpm/mmotm/ >> >> This is a snapshot of my -mm patch queue. Uploaded at random hopefull= y >> more than once a week. >> >=20 > on i386: >=20 > CONFIG_MIGRATION=3Dy > # CONFIG_TRANSPARENT_HUGEPAGE is not set >=20 > ../mm/migrate.c: In function =E2=80=98migrate_pages=E2=80=99: > ../mm/migrate.c:1528:19: error: =E2=80=98THP_MIGRATION_SUCCESS=E2=80=99= undeclared (first use in this function); did you mean =E2=80=98PGMIGRATE= _SUCCESS=E2=80=99? > count_vm_events(THP_MIGRATION_SUCCESS, nr_thp_succeeded); > ^~~~~~~~~~~~~~~~~~~~~ > PGMIGRATE_SUCCESS > ../mm/migrate.c:1528:19: note: each undeclared identifier is reported o= nly once for each function it appears in > ../mm/migrate.c:1530:19: error: =E2=80=98THP_MIGRATION_FAILURE=E2=80=99= undeclared (first use in this function); did you mean =E2=80=98THP_MIGRA= TION_SUCCESS=E2=80=99? > count_vm_events(THP_MIGRATION_FAILURE, nr_thp_failed); > ^~~~~~~~~~~~~~~~~~~~~ > THP_MIGRATION_SUCCESS > ../mm/migrate.c:1532:19: error: =E2=80=98THP_MIGRATION_SPLIT=E2=80=99 u= ndeclared (first use in this function); did you mean =E2=80=98THP_MIGRATI= ON_FAILURE=E2=80=99? > count_vm_events(THP_MIGRATION_SPLIT, nr_thp_split); > ^~~~~~~~~~~~~~~~~~~ > THP_MIGRATION_FAILURE These events should always be available without any config dependency including CONFIG_TRANSPARENT_HUGEPAGE. Will fix this and update the patch.