From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33E9CECAAA1 for ; Wed, 7 Sep 2022 01:59:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9F4816B0073; Tue, 6 Sep 2022 21:59:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A35E6B0074; Tue, 6 Sep 2022 21:59:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 892958D0001; Tue, 6 Sep 2022 21:59:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7A3756B0073 for ; Tue, 6 Sep 2022 21:59:51 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 551BD120F7A for ; Wed, 7 Sep 2022 01:59:51 +0000 (UTC) X-FDA: 79883633382.20.82C7B9C Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf14.hostedemail.com (Postfix) with ESMTP id 7CFD0100067 for ; Wed, 7 Sep 2022 01:59:50 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.53]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4MMlht6bQvz1P702; Wed, 7 Sep 2022 09:55:58 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 7 Sep 2022 09:59:46 +0800 Subject: Re: [PATCH -next] mm/hwpoison: add __init/__exit annotations to module init/exit funcs To: Xiu Jianfeng CC: , , , References: <20220906093530.243262-1-xiujianfeng@huawei.com> From: Miaohe Lin Message-ID: Date: Wed, 7 Sep 2022 09:59:46 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20220906093530.243262-1-xiujianfeng@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662515991; a=rsa-sha256; cv=none; b=W2DMF4LzoNDZT/ue8zbatcn/55rOW2zMq67seA2bt8RmDXCfsNWlK+2vcXLiqgABRCfRAD zIh2hyeUh+EoNrPqUP5/2LkxmbB+I9wG5v3gPKK+Jp0n+6rVpRrbgGyhCJGgAQe5xxG+CB gZ3oKU95Rj993db9dbzLwi4Dt/LczOI= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662515991; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z+j2336WzceenNmGDabzmF61VMsQR+YKwzderuWDfWE=; b=Md6b8ZZq4Yw337P1o4tt5eWKDs9e9TX2jH8HItI3RtkUxpRoPS0diMstbeCRRYWgHzHl7D YbYtAfbAv5tAaEtjZAJOOc9AEX4ZrNOcg33sQL+ECMH4ThE0BxXyTTIkF57DQv4LOKRvji PTJdQ0R9j31wiGJZqA/uWt4Yix1Ta98= X-Stat-Signature: pwxfmdgkzu35673ruui6j1gnxkzbrfy7 X-Rspamd-Queue-Id: 7CFD0100067 X-Rspam-User: Authentication-Results: imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Rspamd-Server: rspam08 X-HE-Tag: 1662515990-97231 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/9/6 17:35, Xiu Jianfeng wrote: > Add missing __init/__exit annotations to module init/exit funcs. > > Signed-off-by: Xiu Jianfeng LGTM. Thanks. Reviewed-by: Miaohe Lin Thanks, Miaohe Lin > --- > mm/hwpoison-inject.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/hwpoison-inject.c b/mm/hwpoison-inject.c > index 65e242b5a432..d0548e382b6b 100644 > --- a/mm/hwpoison-inject.c > +++ b/mm/hwpoison-inject.c > @@ -63,13 +63,13 @@ static int hwpoison_unpoison(void *data, u64 val) > DEFINE_DEBUGFS_ATTRIBUTE(hwpoison_fops, NULL, hwpoison_inject, "%lli\n"); > DEFINE_DEBUGFS_ATTRIBUTE(unpoison_fops, NULL, hwpoison_unpoison, "%lli\n"); > > -static void pfn_inject_exit(void) > +static void __exit pfn_inject_exit(void) > { > hwpoison_filter_enable = 0; > debugfs_remove_recursive(hwpoison_dir); > } > > -static int pfn_inject_init(void) > +static int __init pfn_inject_init(void) > { > hwpoison_dir = debugfs_create_dir("hwpoison", NULL); > >