From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2EFEC4361B for ; Fri, 18 Dec 2020 22:18:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6348523B98 for ; Fri, 18 Dec 2020 22:18:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6348523B98 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6F4DB6B00B7; Fri, 18 Dec 2020 17:18:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 67C538D0003; Fri, 18 Dec 2020 17:18:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 51D846B00B9; Fri, 18 Dec 2020 17:18:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0203.hostedemail.com [216.40.44.203]) by kanga.kvack.org (Postfix) with ESMTP id 395E56B00B7 for ; Fri, 18 Dec 2020 17:18:18 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id F0723180CCDE1 for ; Fri, 18 Dec 2020 22:18:17 +0000 (UTC) X-FDA: 77607817434.30.title88_2815dea27440 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin30.hostedemail.com (Postfix) with ESMTP id C7536180CD32D for ; Fri, 18 Dec 2020 22:18:17 +0000 (UTC) X-HE-Tag: title88_2815dea27440 X-Filterd-Recvd-Size: 3457 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Fri, 18 Dec 2020 22:18:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:To:Subject:Sender: Reply-To:Cc:Content-ID:Content-Description; bh=pc6txyVvOlrwNWi3sTdmcTTPq0af6atkBqUO7tGbAbI=; b=IMNQDtx8i5A3tfvsJG6/d/CoOW 92oHH4C5HtPBDJNFJRagR7k02yyXTVI8ZZ+/Uu3w9HrXyP7rsvCypdlGuwTbf9l/P5NyxG3DuJb37 9phde+5iwa3vjesFuMfIEfkudaX5sTZ1hqLxGRE+wv9h2XUHE6ad3DwbkraUCfRSPBf4jEPYsLCu3 RIZ3RAIuvgOPcQYZdpypukp+bAm3Iq7I5z9t0/pnYKLMbrpj2eiXIQbMvqje6IBTz6b7f2qnB91vA I5hJYI9eqv08ccLVhC3BOXcT12KPZme+iyXi4QITTLSCLHwY+luIahhp9gOxGJul1I1L6ZHZKhKEc kYMlvq5w==; Received: from [2601:1c0:6280:3f0::64ea] by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kqO4g-00071O-IR; Fri, 18 Dec 2020 22:18:11 +0000 Subject: Re: [patch 01/12] zlib: export S390 symbols for zlib modules To: Zaslonko Mikhail , Andrew Morton , borntraeger@de.ibm.com, gor@linux.ibm.com, hca@linux.ibm.com, iii@linux.ibm.com, linux-mm@kvack.org, lkp@intel.com, mm-commits@vger.kernel.org, torvalds@linux-foundation.org References: <20201206061438.EIlu-Bvu8%akpm@linux-foundation.org> <13e195ba-413a-ebba-ea90-c3a15ad514ea@linux.ibm.com> <45544373-754c-ad37-e020-f4864b963852@infradead.org> <1d4cccc2-5e71-d09b-9b1b-03f30427af56@linux.ibm.com> From: Randy Dunlap Message-ID: Date: Fri, 18 Dec 2020 14:18:05 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <1d4cccc2-5e71-d09b-9b1b-03f30427af56@linux.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12/8/20 12:19 AM, Zaslonko Mikhail wrote: > > > On 08.12.2020 01:45, Randy Dunlap wrote: >> On 12/7/20 1:03 AM, Zaslonko Mikhail wrote: >>> Hello, >>> >>> should we probably put these to lib/zlib_dfltcc/dfltcc_syms.c along with the other EXPORT_SYMBOL statements? >> >> Hi, >> I didn't know about that file. :) >> >> That change makes sense. At least that's how some modules used >> to do it. Not so much nowadays, but this one might as well >> consistent within itself. >> >> Do you want to fix it or should I? > > Please, go ahead. > > Thanks. Hi, How do you feel about eliminating the dfltcc_syms.c file and putting the EXPORT_SYMBOL()s in the source file(s) where they occur? as expressed in coding-style.rst: In source files, separate functions with one blank line. If the function is exported, the **EXPORT** macro for it should follow immediately after the closing function brace line. (also move the MODULE_LICENSE() to a different source file.) >> >> Thanks. >> >>> Reviewed-by: Mikhail Zaslonko >>> >>> On 06.12.2020 07:14, Andrew Morton wrote: >>>> From: Randy Dunlap >>>> Subject: zlib: export S390 symbols for zlib modules >>>> >>>> Fix build errors when ZLIB_INFLATE=m and ZLIB_DEFLATE=m and ZLIB_DFLTCC=y >>>> by exporting the 2 needed symbols in dfltcc_inflate.c. thanks. -- ~Randy