From: Anshuman Khandual <anshuman.khandual@arm.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org,
Christoph Hellwig <hch@infradead.org>,
linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org, sparclinux@vger.kernel.org,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
Will Deacon <will@kernel.org>
Subject: Re: [PATCH V4 3/7] arm64/mm: Enable ARCH_HAS_VM_GET_PAGE_PROT
Date: Fri, 8 Apr 2022 16:49:36 +0530 [thread overview]
Message-ID: <dcd6ffe0-9ee2-a862-4ed7-5d04505e6144@arm.com> (raw)
In-Reply-To: <YlAOO2H/Ay/y9HOv@arm.com>
On 4/8/22 15:58, Catalin Marinas wrote:
> On Thu, Apr 07, 2022 at 04:02:47PM +0530, Anshuman Khandual wrote:
>> diff --git a/arch/arm64/mm/mmap.c b/arch/arm64/mm/mmap.c
>> index 77ada00280d9..307534fcec00 100644
>> --- a/arch/arm64/mm/mmap.c
>> +++ b/arch/arm64/mm/mmap.c
>> @@ -55,3 +55,36 @@ static int __init adjust_protection_map(void)
>> return 0;
>> }
>> arch_initcall(adjust_protection_map);
>> +
>> +static pgprot_t arm64_arch_vm_get_page_prot(unsigned long vm_flags)
>> +{
>> + pteval_t prot = 0;
>> +
>> + if (vm_flags & VM_ARM64_BTI)
>> + prot |= PTE_GP;
>> +
>> + /*
>> + * There are two conditions required for returning a Normal Tagged
>> + * memory type: (1) the user requested it via PROT_MTE passed to
>> + * mmap() or mprotect() and (2) the corresponding vma supports MTE. We
>> + * register (1) as VM_MTE in the vma->vm_flags and (2) as
>> + * VM_MTE_ALLOWED. Note that the latter can only be set during the
>> + * mmap() call since mprotect() does not accept MAP_* flags.
>> + * Checking for VM_MTE only is sufficient since arch_validate_flags()
>> + * does not permit (VM_MTE & !VM_MTE_ALLOWED).
>> + */
>> + if (vm_flags & VM_MTE)
>> + prot |= PTE_ATTRINDX(MT_NORMAL_TAGGED);
>> +
>> + return __pgprot(prot);
>> +}
>> +
>> +pgprot_t vm_get_page_prot(unsigned long vm_flags)
>> +{
>> + pgprot_t ret = __pgprot(pgprot_val(protection_map[vm_flags &
>> + (VM_READ|VM_WRITE|VM_EXEC|VM_SHARED)]) |
>> + pgprot_val(arm64_arch_vm_get_page_prot(vm_flags)));
>> +
>> + return ret;
>> +}
>> +EXPORT_SYMBOL(vm_get_page_prot);
>
> Could you write all this in a single function? I think I mentioned it in
> a previous series (untested):
Right, missed that.
>
> pgprot_t vm_get_page_prot(unsigned long vm_flags)
> {
> pteval_t prot = pgprot_val(protection_map[vm_flags &
> (VM_READ|VM_WRITE|VM_EXEC|VM_SHARED)]);
>
> if (vm_flags & VM_ARM64_BTI)
> prot |= PTE_GP;
>
> /*
> * There are two conditions required for returning a Normal Tagged
> * memory type: (1) the user requested it via PROT_MTE passed to
> * mmap() or mprotect() and (2) the corresponding vma supports MTE. We
> * register (1) as VM_MTE in the vma->vm_flags and (2) as
> * VM_MTE_ALLOWED. Note that the latter can only be set during the
> * mmap() call since mprotect() does not accept MAP_* flags.
> * Checking for VM_MTE only is sufficient since arch_validate_flags()
> * does not permit (VM_MTE & !VM_MTE_ALLOWED).
> */
> if (vm_flags & VM_MTE)
> prot |= PTE_ATTRINDX(MT_NORMAL_TAGGED);
>
> return __pgprot(prot);
> }
> EXPORT_SYMBOL(vm_get_page_prot);
>
> With that:
Sure, will change them into a single function.
>
> Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
>
next prev parent reply other threads:[~2022-04-08 11:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 10:32 [PATCH V4 0/7] mm/mmap: Drop arch_vm_get_page_prot() and arch_filter_pgprot() Anshuman Khandual
2022-04-07 10:32 ` [PATCH V4 1/7] mm/mmap: Add new config ARCH_HAS_VM_GET_PAGE_PROT Anshuman Khandual
2022-04-08 9:58 ` Catalin Marinas
2022-04-07 10:32 ` [PATCH V4 2/7] powerpc/mm: Enable ARCH_HAS_VM_GET_PAGE_PROT Anshuman Khandual
2022-04-08 12:53 ` Christophe Leroy
2022-04-09 11:36 ` Christophe Leroy
2022-04-11 5:31 ` Anshuman Khandual
2022-04-11 5:44 ` Christophe Leroy
2022-04-07 10:32 ` [PATCH V4 3/7] arm64/mm: " Anshuman Khandual
2022-04-08 10:28 ` Catalin Marinas
2022-04-08 11:19 ` Anshuman Khandual [this message]
2022-04-07 10:32 ` [PATCH V4 4/7] sparc/mm: " Anshuman Khandual
2022-04-07 15:22 ` Khalid Aziz
2022-04-07 10:32 ` [PATCH V4 5/7] x86/mm: " Anshuman Khandual
2022-04-07 10:32 ` [PATCH V4 6/7] mm/mmap: Drop arch_filter_pgprot() Anshuman Khandual
2022-04-08 10:28 ` Catalin Marinas
2022-04-07 10:32 ` [PATCH V4 7/7] mm/mmap: Drop arch_vm_get_page_pgprot() Anshuman Khandual
2022-04-08 10:29 ` Catalin Marinas
2022-04-07 23:20 ` [PATCH V4 0/7] mm/mmap: Drop arch_vm_get_page_prot() and arch_filter_pgprot() Andrew Morton
2022-04-08 2:41 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dcd6ffe0-9ee2-a862-4ed7-5d04505e6144@arm.com \
--to=anshuman.khandual@arm.com \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=hch@infradead.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=sparclinux@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).