From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AB05C433E3 for ; Mon, 20 Jul 2020 09:05:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6370522482 for ; Mon, 20 Jul 2020 09:05:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6370522482 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E164C6B0003; Mon, 20 Jul 2020 05:05:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D9F356B0005; Mon, 20 Jul 2020 05:05:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C8FA56B0006; Mon, 20 Jul 2020 05:05:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0067.hostedemail.com [216.40.44.67]) by kanga.kvack.org (Postfix) with ESMTP id AF34E6B0003 for ; Mon, 20 Jul 2020 05:05:06 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 53CF618022D10 for ; Mon, 20 Jul 2020 09:05:06 +0000 (UTC) X-FDA: 77057869812.29.burst80_5c0a20026f23 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin29.hostedemail.com (Postfix) with ESMTP id C968C18382ECA for ; Mon, 20 Jul 2020 09:04:54 +0000 (UTC) X-HE-Tag: burst80_5c0a20026f23 X-Filterd-Recvd-Size: 2251 Received: from out30-132.freemail.mail.aliyun.com (out30-132.freemail.mail.aliyun.com [115.124.30.132]) by imf02.hostedemail.com (Postfix) with ESMTP for ; Mon, 20 Jul 2020 09:04:53 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R201e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e01422;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=18;SR=0;TI=SMTPD_---0U3FgSDJ_1595235887; Received: from IT-FVFX43SYHV2H.local(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0U3FgSDJ_1595235887) by smtp.aliyun-inc.com(127.0.0.1); Mon, 20 Jul 2020 17:04:48 +0800 Subject: Re: [PATCH v16 14/22] mm/thp: add tail pages into lru anyway in split_huge_page() To: "Kirill A. Shutemov" Cc: akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, yang.shi@linux.alibaba.com, willy@infradead.org, hannes@cmpxchg.org, lkp@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, shakeelb@google.com, iamjoonsoo.kim@lge.com, richard.weiyang@gmail.com, =?UTF-8?Q?Mika_Penttil=c3=a4?= References: <1594429136-20002-1-git-send-email-alex.shi@linux.alibaba.com> <1594429136-20002-15-git-send-email-alex.shi@linux.alibaba.com> <20200720084931.jusstogio6j74uhs@box> From: Alex Shi Message-ID: Date: Mon, 20 Jul 2020 17:04:46 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200720084931.jusstogio6j74uhs@box> Content-Type: text/plain; charset=gbk X-Rspamd-Queue-Id: C968C18382ECA X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000028, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: =D4=DA 2020/7/20 =CF=C2=CE=E74:49, Kirill A. Shutemov =D0=B4=B5=C0: >> >> Split_huge_page() must start with PageLRU(head), and we are holding th= e >> lru_lock here. If the head was cleared lru bit unexpected, tracking it= . >> >> Signed-off-by: Alex Shi > Reviewed-by: Kirill A. Shutemov Hi Kirill, Millions thanks for review! Alex