From: Anshuman Khandual <anshuman.khandual@arm.com>
To: Mel Gorman <mgorman@techsingularity.net>,
Daniel Jordan <daniel.m.jordan@oracle.com>
Cc: Bruce ZHANG <bo.zhang@nxp.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"guro@fb.com" <guro@fb.com>, "mhocko@suse.com" <mhocko@suse.com>,
"vbabka@suse.cz" <vbabka@suse.cz>,
"jannh@google.com" <jannh@google.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH] mm,vmstat: correct pagetypeinfo statistics when show
Date: Fri, 17 May 2019 12:14:08 +0530 [thread overview]
Message-ID: <ddaeff3a-3de3-2969-9ef4-9bf0b2db8e8d@arm.com> (raw)
In-Reply-To: <20190513085304.GJ18914@techsingularity.net>
On 05/13/2019 02:23 PM, Mel Gorman wrote:
> On Fri, May 10, 2019 at 02:49:00PM -0400, Daniel Jordan wrote:
>> On Fri, May 10, 2019 at 12:36:48PM +0000, Bruce ZHANG wrote:
>>> The "Free pages count per migrate type at order" are shown with the
>>> order from 0 ~ (MAX_ORDER-1), while "Page block order" just print
>>> pageblock_order. If the macro CONFIG_HUGETLB_PAGE is defined, the
>>> pageblock_order may not be equal to (MAX_ORDER-1).
>>
>> All of this is true, but why do you think it's wrong?
>>
>
> Indeed, why is this wrong?
>
>> It makes sense that "Page block order" corresponds to pageblock_order,
>> regardless of whether pageblock_order == MAX_ORDER-1.
>>
>
> Page block order is related to the PMD huge page size, it's not directly
> related to MAX_ORDER other than MAX_ORDER is larger than
> pageblock_order.
Right.
>
>> Cc Mel, who added these two lines.
>>
>>> Signed-off-by: Zhang Bo <bo.zhang@nxp.com>
>
> What's there is correct so unless there is a great explanation as to why
> it should be different;
Agreed.
next prev parent reply other threads:[~2019-05-17 6:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 12:36 [PATCH] mm,vmstat: correct pagetypeinfo statistics when show Bruce ZHANG
2019-05-10 18:49 ` Daniel Jordan
2019-05-13 8:53 ` Mel Gorman
2019-05-17 6:44 ` Anshuman Khandual [this message]
2019-05-10 20:13 ` Daniel Jordan
2019-05-10 21:24 ` Daniel Jordan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ddaeff3a-3de3-2969-9ef4-9bf0b2db8e8d@arm.com \
--to=anshuman.khandual@arm.com \
--cc=akpm@linux-foundation.org \
--cc=bo.zhang@nxp.com \
--cc=daniel.m.jordan@oracle.com \
--cc=guro@fb.com \
--cc=jannh@google.com \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).