From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DFA7C43461 for ; Thu, 15 Apr 2021 08:39:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1769E611CD for ; Thu, 15 Apr 2021 08:39:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1769E611CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8F4F16B0036; Thu, 15 Apr 2021 04:39:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 87D6E6B006C; Thu, 15 Apr 2021 04:39:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A90D6B0070; Thu, 15 Apr 2021 04:39:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0146.hostedemail.com [216.40.44.146]) by kanga.kvack.org (Postfix) with ESMTP id 4AD4C6B0036 for ; Thu, 15 Apr 2021 04:39:58 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 0FC195DD7 for ; Thu, 15 Apr 2021 08:39:58 +0000 (UTC) X-FDA: 78033953676.30.0744165 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by imf15.hostedemail.com (Postfix) with ESMTP id E6FFFA00038D for ; Thu, 15 Apr 2021 08:39:55 +0000 (UTC) Received: by mail-pg1-f169.google.com with SMTP id g35so16389119pgg.9 for ; Thu, 15 Apr 2021 01:39:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3tRTg0shzbghpK8s5KkDpORVJgOU6nXvQDc4YptWxp4=; b=dzupOljK/n2OhOKq3IFzO/jpubmmgifqonI7cIVcK57nYONTDn0gN+SMqd+LVuhEue vSOJmf26iaOeofbY33+7llZWIbG92xNXaeesFkp0AroekPl+iUY+XDIvyc5flXvsoEht MVOKE1W2f9eGWDOGOYFjhcZC1B0OTfJfA7W2qzrPcXDekA8tmSlR2QPNB5MryIIYQZbz ssdKILAwuvYxQTVduNjgdr6acCBmQgkipEXGjIFt51ycr+XxjnOqTeHVyfVVJxloaLud HhtVRgp39rFZsswxe1bP3XX88qm2K7hfI04uSV4FuUyBP6bcWcG9umfpyC/scl3ngPhd V10Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3tRTg0shzbghpK8s5KkDpORVJgOU6nXvQDc4YptWxp4=; b=mjnGs9fuVyNo3KZDsooUKu4CeBfOgOIupgULPZPnq2LutiVD0RLoa8N/j4R4O+d4Eg ix2ojBs/K8ei+m3f9r8jWcDHkI8C2HjUMDkXRM3blKfROj1+G94heZOQHJ6sAjpHFhcH 77ZLqItcwyhogy7093k0EJR1J7pTPQiHiptNqn4xWB34sWf3BcT/5G84pASMzRvHrCX8 duXSD7arqPWhM/ogfBkU/J1QeqpRxENwpIyykZ20nqUfPkTPTgVbmYafB6tLf6ztW0yF xd8fadn7axC6owJKyNfbzgFDwiYeKeGSB3F2/0xwRy+V8O2LQ507PS6GWwmaO+uRbnre rJrQ== X-Gm-Message-State: AOAM5326P5ByjXthDXvZprukmskX1LCdd0O4Ct/IQBeYbmZylbOIBvpu EtHaLqcxsFc/nAyCUcGuHXg= X-Google-Smtp-Source: ABdhPJz/E8YagRoaQfmGydf9eGCq3z8Im0ouKOCNMw/9TlVzNQ5NsPj3ODCpxu/cZ1XaZZeQpmJi/Q== X-Received: by 2002:a62:e119:0:b029:245:8e0:820 with SMTP id q25-20020a62e1190000b029024508e00820mr2092886pfh.4.1618475996564; Thu, 15 Apr 2021 01:39:56 -0700 (PDT) Received: from ?IPv6:2404:f801:0:6:8000::a31c? ([2404:f801:9000:1a:efeb::a31c]) by smtp.gmail.com with ESMTPSA id t67sm1573474pfb.210.2021.04.15.01.39.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Apr 2021 01:39:56 -0700 (PDT) Subject: Re: [Resend RFC PATCH V2 11/12] HV/Netvsc: Add Isolation VM support for netvsc driver To: Christoph Hellwig Cc: kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com, wei.liu@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, arnd@arndb.de, akpm@linux-foundation.org, gregkh@linuxfoundation.org, konrad.wilk@oracle.com, m.szyprowski@samsung.com, robin.murphy@arm.com, joro@8bytes.org, will@kernel.org, davem@davemloft.net, kuba@kernel.org, jejb@linux.ibm.com, martin.petersen@oracle.com, Tianyu Lan , iommu@lists.linux-foundation.org, linux-arch@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-scsi@vger.kernel.org, netdev@vger.kernel.org, vkuznets@redhat.com, thomas.lendacky@amd.com, brijesh.singh@amd.com, sunilmut@microsoft.com References: <20210414144945.3460554-1-ltykernel@gmail.com> <20210414144945.3460554-12-ltykernel@gmail.com> <20210414155016.GE32045@lst.de> From: Tianyu Lan Message-ID: Date: Thu, 15 Apr 2021 16:39:45 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <20210414155016.GE32045@lst.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: E6FFFA00038D X-Stat-Signature: 5zjp4jp9t5pxemrtwkczhn5e7x7czc9k Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf15; identity=mailfrom; envelope-from=""; helo=mail-pg1-f169.google.com; client-ip=209.85.215.169 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618475995-27868 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/14/2021 11:50 PM, Christoph Hellwig wrote: >> +struct dma_range { >> + dma_addr_t dma; >> + u32 mapping_size; >> +}; > > That's a rather generic name that is bound to create a conflict sooner > or later. Good point. Will update. > >> #include "hyperv_net.h" >> #include "netvsc_trace.h" >> +#include "../../hv/hyperv_vmbus.h" > > Please move public interfaces out of the private header rather than doing > this. OK. Will update. > >> + if (hv_isolation_type_snp()) { >> + area = get_vm_area(buf_size, VM_IOREMAP); > > Err, no. get_vm_area is private a for a reason. > >> + if (!area) >> + goto cleanup; >> + >> + vaddr = (unsigned long)area->addr; >> + for (i = 0; i < buf_size / HV_HYP_PAGE_SIZE; i++) { >> + extra_phys = (virt_to_hvpfn(net_device->recv_buf + i * HV_HYP_PAGE_SIZE) >> + << HV_HYP_PAGE_SHIFT) + ms_hyperv.shared_gpa_boundary; >> + ret |= ioremap_page_range(vaddr + i * HV_HYP_PAGE_SIZE, >> + vaddr + (i + 1) * HV_HYP_PAGE_SIZE, >> + extra_phys, PAGE_KERNEL_IO); >> + } >> + >> + if (ret) >> + goto cleanup; > > And this is not something a driver should ever do. I think you are badly > reimplementing functionality that should be in the dma coherent allocator > here. > OK. I will try hiding these in the Hyper-V dma ops callback. Thanks.