From: Vlastimil Babka <vbabka@suse.cz>
To: Hyeonggon Yoo <42.hyeyoo@gmail.com>
Cc: Matthew Wilcox <willy@infradead.org>,
cl@linux.com, penberg@kernel.org, rientjes@google.com,
iamjoonsoo.kim@lge.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm: kmalloc_index: make compiler break when size is not supported
Date: Tue, 11 May 2021 10:36:01 +0200 [thread overview]
Message-ID: <de465c4a-d99b-b9da-49c7-6c767918fe78@suse.cz> (raw)
In-Reply-To: <20210510153846.GA77398@hyeyoo>
On 5/10/21 5:38 PM, Hyeonggon Yoo wrote:
> On Mon, May 10, 2021 at 05:19:58PM +0200, Vlastimil Babka wrote:
>
>> I'd rephrase the subject:
>> mm, slub: change run-time assertion in kmalloc_index() to compile-time
>>
>
>> "... compiler will generate a run-time BUG() while a compile-time error is also
>> possible, and better"
>
>> "there's no need to..."
>> kmalloc-32M
>
>
> Vlastimil Babka and Christoph Lameter, thank you for reviewing the patch.
>
> I'm not familiar with kernel community yet. should I send patch v3 again,
> or can you update it directly?
I think it would be best if you sent v3, the way you did with v1 - inline. With
v2 it looked like a mail body with you message and patch as attachment. We want
the testing bots to pick it up and they might work only with inline patch. Thanks.
next prev parent reply other threads:[~2021-05-11 8:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-08 22:13 [PATCH] mm: kmalloc_index: remove case when size is more than 32MB Hyeonggon Yoo
2021-05-08 23:19 ` Matthew Wilcox
2021-05-09 5:33 ` Hyeonggon Yoo
2021-05-10 10:09 ` Vlastimil Babka
2021-05-10 13:58 ` Hyeonggon Yoo
2021-05-10 14:04 ` Vlastimil Babka
2021-05-10 15:02 ` [PATCH v2] mm: kmalloc_index: make compiler break when size is not supported Hyeonggon Yoo
2021-05-10 15:15 ` Christoph Lameter
2021-05-10 15:21 ` Vlastimil Babka
2021-05-11 3:09 ` Hyeonggon Yoo
2021-05-10 15:19 ` Vlastimil Babka
2021-05-10 15:38 ` Hyeonggon Yoo
2021-05-11 8:36 ` Vlastimil Babka [this message]
2021-05-11 8:37 ` Vlastimil Babka
2021-05-11 9:14 ` Hyeonggon Yoo
2021-05-11 2:59 ` [PATCH v3] mm: change run-time assertion in kmalloc_index() to compile-time Hyeonggon Yoo
2021-05-10 15:44 ` [PATCH v2] mm: kmalloc_index: make compiler break when size is not supported Matthew Wilcox
2021-05-11 3:03 ` Hyeonggon Yoo
2021-05-11 8:33 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de465c4a-d99b-b9da-49c7-6c767918fe78@suse.cz \
--to=vbabka@suse.cz \
--cc=42.hyeyoo@gmail.com \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).