From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f71.google.com (mail-oi0-f71.google.com [209.85.218.71]) by kanga.kvack.org (Postfix) with ESMTP id 29F436B0010 for ; Wed, 1 Aug 2018 18:01:54 -0400 (EDT) Received: by mail-oi0-f71.google.com with SMTP id 13-v6so187008oiq.1 for ; Wed, 01 Aug 2018 15:01:54 -0700 (PDT) Received: from www262.sakura.ne.jp (www262.sakura.ne.jp. [202.181.97.72]) by mx.google.com with ESMTPS id w22-v6si62063oiw.390.2018.08.01.15.01.52 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 Aug 2018 15:01:52 -0700 (PDT) Subject: Re: [PATCH v13 0/7] cgroup-aware OOM killer References: <0d018c7e-a3de-a23a-3996-bed8b28b1e4a@i-love.sakura.ne.jp> <20180716220918.GA3898@castle.DHCP.thefacebook.com> <201807170055.w6H0tHn5075670@www262.sakura.ne.jp> <20180801163718.GA23539@castle> From: Tetsuo Handa Message-ID: Date: Thu, 2 Aug 2018 07:01:28 +0900 MIME-Version: 1.0 In-Reply-To: <20180801163718.GA23539@castle> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Roman Gushchin , Andrew Morton Cc: David Rientjes , Michal Hocko , Vladimir Davydov , Johannes Weiner , Tejun Heo , kernel-team@fb.com, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org On 2018/08/02 1:37, Roman Gushchin wrote: > On Tue, Jul 31, 2018 at 11:14:01PM +0900, Tetsuo Handa wrote: >> Can we temporarily drop cgroup-aware OOM killer from linux-next.git and >> apply my cleanup patch? Since the merge window is approaching, I really want to >> see how next -rc1 would look like... > > Hi Tetsuo! > > Has this cleanup patch been acked by somebody? Not yet. But since Michal considers this cleanup as "a nice shortcut" ( https://marc.info/?i=20180607112836.GN32433@dhcp22.suse.cz ), I assume that I will get an ACK regarding this cleanup. > Which problem does it solve? It simplifies tricky out_of_memory() return value decision, and it also fixes a bug in your series which syzbot is pointing out. > Dropping patches for making a cleanup (if it's a cleanup) sounds a bit strange. What I need is a git tree which I can use as a baseline for making this cleanup. linux.git is not suitable because it does not include Michal's fix, but linux-next.git is not suitable because Michal's fix is overwritten by your series. I want a git tree which includes Michal's fix and does not include your series. > > Anyway, there is a good chance that current cgroup-aware OOM killer > implementation will be replaced by a lightweight version (memory.oom.group). > Please, take a look at it, probably your cleanup will not conflict with it > at all. Then, please drop current cgroup-aware OOM killer implementation from linux-next.git . I want to see how next -rc1 would look like (for testing purpose) and want to use linux-next.git as a baseline (for making this cleanup). > > Thanks! > >