From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AD27C433DB for ; Tue, 23 Mar 2021 21:29:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9CFA061601 for ; Tue, 23 Mar 2021 21:29:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CFA061601 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2CCB66B01B1; Tue, 23 Mar 2021 17:29:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 27C3B6B01B3; Tue, 23 Mar 2021 17:29:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0CE9C6B01F0; Tue, 23 Mar 2021 17:29:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E05A86B01B1 for ; Tue, 23 Mar 2021 17:29:12 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 9F2008249980 for ; Tue, 23 Mar 2021 21:29:12 +0000 (UTC) X-FDA: 77952429744.28.588F041 Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) by imf17.hostedemail.com (Postfix) with ESMTP id 1027D407F8DF for ; Tue, 23 Mar 2021 21:29:10 +0000 (UTC) Received: by mail-lj1-f169.google.com with SMTP id f16so27616533ljm.1 for ; Tue, 23 Mar 2021 14:29:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=VB2Rli/wp6daf+0Rl+O8aL5+Mm/3G7ESffCZbqZfaRQ=; b=bxDavkCcCIproe94KQdt2CLKc783cy7xaHhrY0V88/NYN2lAYcrnTgAY9DBnGA1eHk 4iW+FyT+Rl+KNFwyF7uR82uJ3oSY0K5ts4XzMy6HWqzE02GGP4FPO6dqniqVqwU3e0nR VEgqcTZz9zHZ1imNYYcjTYPEpNS1Zs8hjtwssRp6xU+ZVQeoHl4h0u9zXtPj47UCFgsa 1plWTGRur+Y0v4NbZoI+i41n9ig3khbb22ReZEwnleyKySlS3kTDGA7QCqCxLM2L6Gsz tavKBcP0GK5JLnxKWJKqu/j2sjlaPk5plubvCFUAWTpCPUU4Z2ru9VCEoWQVEODHdCXY xesg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=VB2Rli/wp6daf+0Rl+O8aL5+Mm/3G7ESffCZbqZfaRQ=; b=qh2Bp+nxOqG7KUUrQeBCJGRpwO5IU0/+FNHEn5fuR54AxyIeBxnvBLlo7LmdrFAA+U C9MvENsY1mozvf9YQPGOEJoEViR0tHwX1u71OQlvV6827094gkYf2B0y5JyLHqqg9HmT rrzsxqU8LcUyKvsbAvc+f7APCcPcQYtZrvATwj5CL7oP1WnU15f6kItMIYp02j5i3y9b +qrf3mQGk4uowKUyG1XoFAjzci573PGxiH2afKaR90M9jnF6enS/zdTpfoFBSpmckcO5 ZWb/ovGoICpgzfgsEBZmArCUAlAgywLDx0qGwGZjzLd11IRIwIPmLcuuum6w1/mcNTbU hTzA== X-Gm-Message-State: AOAM530jW/InzSRlEiK2JFgLC27tAYlgjnN6UPEZDaK/vaexyXgZqKTT /12acMP4sdmE3KDIlfUrWr4= X-Google-Smtp-Source: ABdhPJzQdnAsy7VZg8KomuQlbi0mPfgseYVlud4b9LsW2PI38hauzoucu+o27SlQHTOOZ+lCy1eJHw== X-Received: by 2002:a2e:8709:: with SMTP id m9mr4195319lji.483.1616534950847; Tue, 23 Mar 2021 14:29:10 -0700 (PDT) Received: from [192.168.2.145] (109-252-193-60.dynamic.spd-mgts.ru. [109.252.193.60]) by smtp.googlemail.com with ESMTPSA id m22sm26095lfa.170.2021.03.23.14.29.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Mar 2021 14:29:10 -0700 (PDT) Subject: Re: [PATCH v5] mm: cma: support sysfs From: Dmitry Osipenko To: Minchan Kim , Andrew Morton Cc: linux-mm , LKML , gregkh@linuxfoundation.org, surenb@google.com, joaodias@google.com, jhubbard@nvidia.com, willy@infradead.org References: <20210323195050.2577017-1-minchan@kernel.org> Message-ID: Date: Wed, 24 Mar 2021 00:29:09 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Stat-Signature: cbzegpj8js589po97r8a9ohdu5oj1ox3 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 1027D407F8DF Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf17; identity=mailfrom; envelope-from=""; helo=mail-lj1-f169.google.com; client-ip=209.85.208.169 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616534950-537059 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 24.03.2021 00:19, Dmitry Osipenko =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >> + if (!kobj) >> + goto out; >> + >> + kobj->cma =3D cma; >> + cma->kobj =3D kobj; >> + if (kobject_init_and_add(&cma->kobj->kobj, &cma_ktype, >> + cma_kobj_root, "%s", cma->name)) { >> + kobject_put(&cma->kobj->kobj); >> + goto out; >> + } >> + } >> + >> + return 0; >> +out: >> + kobject_put(cma_kobj_root); >> + >> + return -ENOMEM; > kobject_init_and_add returns a error code, it could be different from > ENOMEM. Won't hurt to propagate the proper error code. >=20 I think it will be cleaner to write it like this: cma_kobj =3D kzalloc(sizeof(*cma_kobj), GFP_KERNEL); if (!cma_kobj) { kobject_put(cma_kobj_root); return -ENOMEM; } cma_kobj->cma =3D cma; err =3D kobject_init_and_add(&cma_kobj->kobj, &cma_ktype, cma_kobj_root, "%s", cma->name); =20 if (err) { kobject_put(&cma_kobj->kobj); kobject_put(cma_kobj_root); return err; } } return 0; }