From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACBACC433DF for ; Thu, 21 May 2020 07:42:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 83A3220759 for ; Thu, 21 May 2020 07:42:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 83A3220759 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1E9398001D; Thu, 21 May 2020 03:42:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 199B680007; Thu, 21 May 2020 03:42:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D6128001D; Thu, 21 May 2020 03:42:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0190.hostedemail.com [216.40.44.190]) by kanga.kvack.org (Postfix) with ESMTP id E6BB680007 for ; Thu, 21 May 2020 03:42:06 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id A75E8180AD822 for ; Thu, 21 May 2020 07:42:06 +0000 (UTC) X-FDA: 76839932652.10.pen18_86cfe678bcd3a X-HE-Tag: pen18_86cfe678bcd3a X-Filterd-Recvd-Size: 2498 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Thu, 21 May 2020 07:42:06 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id DF51FAD78; Thu, 21 May 2020 07:42:06 +0000 (UTC) Subject: Re: [PATCH v6 12/12] mmap locking API: convert mmap_sem comments To: Michel Lespinasse , Andrew Morton , linux-mm Cc: LKML , Peter Zijlstra , Laurent Dufour , Matthew Wilcox , Liam Howlett , Jerome Glisse , Davidlohr Bueso , David Rientjes , Hugh Dickins , Ying Han , Jason Gunthorpe , Daniel Jordan , John Hubbard References: <20200520052908.204642-1-walken@google.com> <20200520052908.204642-13-walken@google.com> From: Vlastimil Babka Message-ID: Date: Thu, 21 May 2020 09:41:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200520052908.204642-13-walken@google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/20/20 7:29 AM, Michel Lespinasse wrote: > Convert comments that reference mmap_sem to reference mmap_lock instead. > > Signed-off-by: Michel Lespinasse Reviewed-by: Vlastimil Babka But: > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > index a1247d3553da..1bf46e2e0cec 100644 > --- a/mm/mempolicy.c > +++ b/mm/mempolicy.c > @@ -224,7 +224,7 @@ static int mpol_new_bind(struct mempolicy *pol, const nodemask_t *nodes) > * handle an empty nodemask with MPOL_PREFERRED here. > * > * Must be called holding task's alloc_lock to protect task's mems_allowed > - * and mempolicy. May also be called holding the mmap_semaphore for write. > + * and mempolicy. May also be called holding the mmap_lockaphore for write. > */ > static int mpol_set_nodemask(struct mempolicy *pol, > const nodemask_t *nodes, struct nodemask_scratch *nsc) :)