* [PATCH] mm: khugepaged: add trace status description for SCAN_PAGE_HAS_PRIVATE
@ 2019-11-25 18:27 Yang Shi
2019-11-26 8:57 ` Anshuman Khandual
0 siblings, 1 reply; 3+ messages in thread
From: Yang Shi @ 2019-11-25 18:27 UTC (permalink / raw)
To: songliubraving, kirill.shutemov, akpm; +Cc: yang.shi, linux-mm, linux-kernel
The commit 99cb0dbd47a15d395bf3faa78dc122bc5efe3fc0 ("mm,thp: add
read-only THP support for (non-shmem) FS") instroduced a new khugepaged
scan result: SCAN_PAGE_HAS_PRIVATE, but the corresponding description
for trance events were not added.
Cc: Song Liu <songliubraving@fb.com>
Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Signed-off-by: Yang Shi <yang.shi@linux.alibaba.com>
---
include/trace/events/huge_memory.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/trace/events/huge_memory.h b/include/trace/events/huge_memory.h
index dd4db33..d49fbce 100644
--- a/include/trace/events/huge_memory.h
+++ b/include/trace/events/huge_memory.h
@@ -31,7 +31,8 @@
EM( SCAN_ALLOC_HUGE_PAGE_FAIL, "alloc_huge_page_failed") \
EM( SCAN_CGROUP_CHARGE_FAIL, "ccgroup_charge_failed") \
EM( SCAN_EXCEED_SWAP_PTE, "exceed_swap_pte") \
- EMe(SCAN_TRUNCATED, "truncated") \
+ EM( SCAN_TRUNCATED, "truncated") \
+ EMe(SCAN_PAGE_HAS_PRIVATE, "has_private") \
#undef EM
#undef EMe
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mm: khugepaged: add trace status description for SCAN_PAGE_HAS_PRIVATE
2019-11-25 18:27 [PATCH] mm: khugepaged: add trace status description for SCAN_PAGE_HAS_PRIVATE Yang Shi
@ 2019-11-26 8:57 ` Anshuman Khandual
2019-11-26 17:38 ` Yang Shi
0 siblings, 1 reply; 3+ messages in thread
From: Anshuman Khandual @ 2019-11-26 8:57 UTC (permalink / raw)
To: Yang Shi, songliubraving, kirill.shutemov, akpm; +Cc: linux-mm, linux-kernel
On 11/25/2019 11:57 PM, Yang Shi wrote:
> The commit 99cb0dbd47a15d395bf3faa78dc122bc5efe3fc0 ("mm,thp: add
Reduce the commit SHA ID here to just 12 digits instead ?
> read-only THP support for (non-shmem) FS") instroduced a new khugepaged
s/instroduced/introduced/
> scan result: SCAN_PAGE_HAS_PRIVATE, but the corresponding description
> for trance events were not added.
s/trance/trace/
>
> Cc: Song Liu <songliubraving@fb.com>
> Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Signed-off-by: Yang Shi <yang.shi@linux.alibaba.com>
> ---
> include/trace/events/huge_memory.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/trace/events/huge_memory.h b/include/trace/events/huge_memory.h
> index dd4db33..d49fbce 100644
> --- a/include/trace/events/huge_memory.h
> +++ b/include/trace/events/huge_memory.h
> @@ -31,7 +31,8 @@
> EM( SCAN_ALLOC_HUGE_PAGE_FAIL, "alloc_huge_page_failed") \
> EM( SCAN_CGROUP_CHARGE_FAIL, "ccgroup_charge_failed") \
> EM( SCAN_EXCEED_SWAP_PTE, "exceed_swap_pte") \
> - EMe(SCAN_TRUNCATED, "truncated") \
> + EM( SCAN_TRUNCATED, "truncated") \
> + EMe(SCAN_PAGE_HAS_PRIVATE, "has_private") \
Majority of the SCAN_PAGE_* scan results have page_ in the front. Hence we
should just follow same pattern here and make it 'page_has_private' instead.
>
> #undef EM
> #undef EMe
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm: khugepaged: add trace status description for SCAN_PAGE_HAS_PRIVATE
2019-11-26 8:57 ` Anshuman Khandual
@ 2019-11-26 17:38 ` Yang Shi
0 siblings, 0 replies; 3+ messages in thread
From: Yang Shi @ 2019-11-26 17:38 UTC (permalink / raw)
To: Anshuman Khandual, songliubraving, kirill.shutemov, akpm
Cc: linux-mm, linux-kernel
On 11/26/19 12:57 AM, Anshuman Khandual wrote:
>
> On 11/25/2019 11:57 PM, Yang Shi wrote:
>> The commit 99cb0dbd47a15d395bf3faa78dc122bc5efe3fc0 ("mm,thp: add
> Reduce the commit SHA ID here to just 12 digits instead ?
Yes, sure.
>
>> read-only THP support for (non-shmem) FS") instroduced a new khugepaged
> s/instroduced/introduced/
Will fix.
>
>> scan result: SCAN_PAGE_HAS_PRIVATE, but the corresponding description
>> for trance events were not added.
> s/trance/trace/
My fat finger :-(
>
>> Cc: Song Liu <songliubraving@fb.com>
>> Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
>> Signed-off-by: Yang Shi <yang.shi@linux.alibaba.com>
>> ---
>> include/trace/events/huge_memory.h | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/trace/events/huge_memory.h b/include/trace/events/huge_memory.h
>> index dd4db33..d49fbce 100644
>> --- a/include/trace/events/huge_memory.h
>> +++ b/include/trace/events/huge_memory.h
>> @@ -31,7 +31,8 @@
>> EM( SCAN_ALLOC_HUGE_PAGE_FAIL, "alloc_huge_page_failed") \
>> EM( SCAN_CGROUP_CHARGE_FAIL, "ccgroup_charge_failed") \
>> EM( SCAN_EXCEED_SWAP_PTE, "exceed_swap_pte") \
>> - EMe(SCAN_TRUNCATED, "truncated") \
>> + EM( SCAN_TRUNCATED, "truncated") \
>> + EMe(SCAN_PAGE_HAS_PRIVATE, "has_private") \
> Majority of the SCAN_PAGE_* scan results have page_ in the front. Hence we
> should just follow same pattern here and make it 'page_has_private' instead.
Some do start with "page_", anyway either is fine to me.
>
>>
>> #undef EM
>> #undef EMe
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-26 17:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-25 18:27 [PATCH] mm: khugepaged: add trace status description for SCAN_PAGE_HAS_PRIVATE Yang Shi
2019-11-26 8:57 ` Anshuman Khandual
2019-11-26 17:38 ` Yang Shi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).