From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9D71C432C3 for ; Tue, 26 Nov 2019 17:38:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6A2CF2073F for ; Tue, 26 Nov 2019 17:38:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6A2CF2073F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CD8936B032E; Tue, 26 Nov 2019 12:38:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C618F6B032F; Tue, 26 Nov 2019 12:38:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B51B76B0330; Tue, 26 Nov 2019 12:38:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0002.hostedemail.com [216.40.44.2]) by kanga.kvack.org (Postfix) with ESMTP id 998256B032E for ; Tue, 26 Nov 2019 12:38:15 -0500 (EST) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id 3D78F181AEF2A for ; Tue, 26 Nov 2019 17:38:15 +0000 (UTC) X-FDA: 76199137350.01.skirt96_8228e9637c917 X-HE-Tag: skirt96_8228e9637c917 X-Filterd-Recvd-Size: 3108 Received: from out30-133.freemail.mail.aliyun.com (out30-133.freemail.mail.aliyun.com [115.124.30.133]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Tue, 26 Nov 2019 17:38:14 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R171e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e07486;MF=yang.shi@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0Tj9oAor_1574789888; Received: from US-143344MP.local(mailfrom:yang.shi@linux.alibaba.com fp:SMTPD_---0Tj9oAor_1574789888) by smtp.aliyun-inc.com(127.0.0.1); Wed, 27 Nov 2019 01:38:10 +0800 Subject: Re: [PATCH] mm: khugepaged: add trace status description for SCAN_PAGE_HAS_PRIVATE To: Anshuman Khandual , songliubraving@fb.com, kirill.shutemov@linux.intel.com, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <1574706428-36212-1-git-send-email-yang.shi@linux.alibaba.com> <729623eb-df56-c436-2ca3-8f73772f539c@arm.com> From: Yang Shi Message-ID: Date: Tue, 26 Nov 2019 09:38:06 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <729623eb-df56-c436-2ca3-8f73772f539c@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/26/19 12:57 AM, Anshuman Khandual wrote: > > On 11/25/2019 11:57 PM, Yang Shi wrote: >> The commit 99cb0dbd47a15d395bf3faa78dc122bc5efe3fc0 ("mm,thp: add > Reduce the commit SHA ID here to just 12 digits instead ? Yes, sure. > >> read-only THP support for (non-shmem) FS") instroduced a new khugepaged > s/instroduced/introduced/ Will fix. > >> scan result: SCAN_PAGE_HAS_PRIVATE, but the corresponding description >> for trance events were not added. > s/trance/trace/ My fat finger :-( > >> Cc: Song Liu >> Cc: Kirill A. Shutemov >> Signed-off-by: Yang Shi >> --- >> include/trace/events/huge_memory.h | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/include/trace/events/huge_memory.h b/include/trace/events/huge_memory.h >> index dd4db33..d49fbce 100644 >> --- a/include/trace/events/huge_memory.h >> +++ b/include/trace/events/huge_memory.h >> @@ -31,7 +31,8 @@ >> EM( SCAN_ALLOC_HUGE_PAGE_FAIL, "alloc_huge_page_failed") \ >> EM( SCAN_CGROUP_CHARGE_FAIL, "ccgroup_charge_failed") \ >> EM( SCAN_EXCEED_SWAP_PTE, "exceed_swap_pte") \ >> - EMe(SCAN_TRUNCATED, "truncated") \ >> + EM( SCAN_TRUNCATED, "truncated") \ >> + EMe(SCAN_PAGE_HAS_PRIVATE, "has_private") \ > Majority of the SCAN_PAGE_* scan results have page_ in the front. Hence we > should just follow same pattern here and make it 'page_has_private' instead. Some do start with "page_", anyway either is fine to me. > >> >> #undef EM >> #undef EMe >>