From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A654C433EF for ; Mon, 6 Sep 2021 09:40:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2C0F060F3A for ; Mon, 6 Sep 2021 09:40:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2C0F060F3A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id C34ED6B0071; Mon, 6 Sep 2021 05:40:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BE54D6B0072; Mon, 6 Sep 2021 05:40:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AACDD900002; Mon, 6 Sep 2021 05:40:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0059.hostedemail.com [216.40.44.59]) by kanga.kvack.org (Postfix) with ESMTP id 9E40F6B0071 for ; Mon, 6 Sep 2021 05:40:36 -0400 (EDT) Received: from smtpin32.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 56BB31DAF0 for ; Mon, 6 Sep 2021 09:40:36 +0000 (UTC) X-FDA: 78556653672.32.21385C9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf26.hostedemail.com (Postfix) with ESMTP id E970F20019CF for ; Mon, 6 Sep 2021 09:40:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630921235; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cYA37SlRuRPHoIjk69T5OroCeNXU9xA4x0HI4zeLbQw=; b=fQooczqeJXs2aC1UJIraPXSnb0G2SczOonlPt6vo9Dk0zQNnCfRfuTvxwXZ4U5O5rCCfgG ccyGSiZTLRzNzwDK4/nksmWyElqg+rlEGPdQ1OTHj7XfhgFySOCaaRptmlRjFgfcRXEbsy RJQ8THDsJcVM1tD9WUfkPdet9YWWWEA= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-427-7J1YLJ4fN-2ZdP04KrGPhg-1; Mon, 06 Sep 2021 05:40:32 -0400 X-MC-Unique: 7J1YLJ4fN-2ZdP04KrGPhg-1 Received: by mail-wm1-f70.google.com with SMTP id k5-20020a7bc3050000b02901e081f69d80so2130042wmj.8 for ; Mon, 06 Sep 2021 02:40:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=cYA37SlRuRPHoIjk69T5OroCeNXU9xA4x0HI4zeLbQw=; b=nDJ03ijBxR+QTQowFYFdzBiK9AZtwlCQwSDl8YRJo5zxOokyrm5oXKKAcT+Iii5meg 2DHZghVIzk+jXVp4sN6R8rP9UHAvVOKNL2GBtlE1QXM/SQDkSk1ZLRI3PG/5Ctj9NdO6 2iINkaHqiUNDbI5vEiYzZ49S/vfbkd+P0fTC7Q+sdjksLIowahU6ZNVTAZEpdHgwj8ah s6hL0RDkHWq90nytjzmuSXpmE4MTDOJJPx3Y1ucaCssbDsXhd8rL9FRxvMYTzjBYqU1X fJCIaRuS/FoJlsH/MYK8o4ZcXFDtoWtu1q7ko+UzRum+2kHIEpa4tSMJ2SzG/+eaozAn UXHw== X-Gm-Message-State: AOAM530HxKQoaAS8BcW+HAvVtzIKhxQnEMHGgMUna/YNTYfgz5Xyl4HP RNpOWHFkBOsRO66EoJhNzYP+6QliA5T0ZuMhFvh3m14cCzOBBtqPUjW2z0WYJM/LiPtI8BKUX7P ARg+4Gk0Rf7o= X-Received: by 2002:a1c:4cd:: with SMTP id 196mr10331362wme.10.1630921231167; Mon, 06 Sep 2021 02:40:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwBtZlHsLGYFzWRzJ5Y5Nuo0pZbnJi5t0VUGtyWpg9J5ZrFUPZmKp16fwujCtQNaoe5gTaa5w== X-Received: by 2002:a1c:4cd:: with SMTP id 196mr10331346wme.10.1630921230940; Mon, 06 Sep 2021 02:40:30 -0700 (PDT) Received: from [192.168.3.132] (p5b0c6323.dip0.t-ipconnect.de. [91.12.99.35]) by smtp.gmail.com with ESMTPSA id f20sm6656589wmb.32.2021.09.06.02.40.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Sep 2021 02:40:30 -0700 (PDT) Subject: Re: [PATCH] mm/page_isolation: don't putback unisolated page To: Miaohe Lin , akpm@linux-foundation.org Cc: vbabka@suse.cz, iamjoonsoo.kim@lge.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20210904091839.20270-1-linmiaohe@huawei.com> From: David Hildenbrand Organization: Red Hat Message-ID: Date: Mon, 6 Sep 2021 11:40:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210904091839.20270-1-linmiaohe@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fQooczqe; spf=none (imf26.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Stat-Signature: ndzrsmnhdypohayay549wf73gmpwxdqm X-Rspamd-Queue-Id: E970F20019CF X-Rspamd-Server: rspam04 X-HE-Tag: 1630921235-76112 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 04.09.21 11:18, Miaohe Lin wrote: > If __isolate_free_page() failed, due to zone watermark check, the page is > still on the free list. But this page will be put back to free list again > via __putback_isolated_page() now. This may trigger page->flags checks in > __free_one_page() if PageReported is set. Or we will corrupt the free list > because list_add() will be called for pages already on another list. > > Fixes: 3c605096d315 ("mm/page_alloc: restrict max order of merging on isolated pageblock") > Signed-off-by: Miaohe Lin > --- > mm/page_isolation.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/mm/page_isolation.c b/mm/page_isolation.c > index 9bb562d5d194..7d70d772525c 100644 > --- a/mm/page_isolation.c > +++ b/mm/page_isolation.c > @@ -93,10 +93,8 @@ static void unset_migratetype_isolate(struct page *page, unsigned migratetype) > buddy_pfn = __find_buddy_pfn(pfn, order); > buddy = page + (buddy_pfn - pfn); > > - if (!is_migrate_isolate_page(buddy)) { > - __isolate_free_page(page, order); > - isolated_page = true; > - } > + if (!is_migrate_isolate_page(buddy)) > + isolated_page = !!__isolate_free_page(page, order); > } > } > > Shouldn't we much rather force to ignore watermarks here and make sure __isolate_free_page() never fails? -- Thanks, David / dhildenb