From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0229AC433E0 for ; Fri, 19 Mar 2021 14:49:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8813164F18 for ; Fri, 19 Mar 2021 14:49:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8813164F18 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 28A536B0073; Fri, 19 Mar 2021 10:49:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 212D06B0078; Fri, 19 Mar 2021 10:49:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0B6BC6B007D; Fri, 19 Mar 2021 10:49:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0075.hostedemail.com [216.40.44.75]) by kanga.kvack.org (Postfix) with ESMTP id DED2F6B0073 for ; Fri, 19 Mar 2021 10:49:40 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 95DE89418 for ; Fri, 19 Mar 2021 14:49:40 +0000 (UTC) X-FDA: 77936907678.28.95FD082 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf01.hostedemail.com (Postfix) with ESMTP id 0D32C5001BD1 for ; Fri, 19 Mar 2021 14:49:36 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 7C3BDAC82; Fri, 19 Mar 2021 14:49:31 +0000 (UTC) Subject: Re: [PATCH v3 7/7] mm/mempolicy: Fix mpol_misplaced kernel-doc To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-mm@kvack.org, Mike Rapoport References: <20210225150642.2582252-1-willy@infradead.org> <20210225150642.2582252-8-willy@infradead.org> From: Vlastimil Babka Message-ID: Date: Fri, 19 Mar 2021 15:49:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210225150642.2582252-8-willy@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 0D32C5001BD1 X-Stat-Signature: u9fdcau7uhy6dwttax8hxm9fuk7rbnae Received-SPF: none (suse.cz>: No applicable sender policy available) receiver=imf01; identity=mailfrom; envelope-from=""; helo=mx2.suse.de; client-ip=195.135.220.15 X-HE-DKIM-Result: none/none X-HE-Tag: 1616165376-653667 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/25/21 4:06 PM, Matthew Wilcox (Oracle) wrote: > Sphinx interprets the Return section as a list and complains about it. > Turn it into a sentence and move it to the end of the kernel-doc to > fit the kernel-doc style. > > Signed-off-by: Matthew Wilcox (Oracle) > Acked-by: Mike Rapoport Acked-by: Vlastimil Babka > --- > Documentation/core-api/mm-api.rst | 1 + > mm/mempolicy.c | 11 ++++------- > 2 files changed, 5 insertions(+), 7 deletions(-) > > diff --git a/Documentation/core-api/mm-api.rst b/Documentation/core-api/mm-api.rst > index 201b5423303b..874ae1250258 100644 > --- a/Documentation/core-api/mm-api.rst > +++ b/Documentation/core-api/mm-api.rst > @@ -92,3 +92,4 @@ More Memory Management Functions > :export: > > .. kernel-doc:: mm/page_alloc.c > +.. kernel-doc:: mm/mempolicy.c > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > index 6d0fe85d4f8d..cd0295567a04 100644 > --- a/mm/mempolicy.c > +++ b/mm/mempolicy.c > @@ -2448,14 +2448,11 @@ static void sp_free(struct sp_node *n) > * @addr: virtual address where page mapped > * > * Lookup current policy node id for vma,addr and "compare to" page's > - * node id. > - * > - * Returns: > - * -1 - not misplaced, page is in the right node > - * node - node id where the page should be > - * > - * Policy determination "mimics" alloc_page_vma(). > + * node id. Policy determination "mimics" alloc_page_vma(). > * Called from fault path where we know the vma and faulting address. > + * > + * Return: -1 if the page is in a node that is valid for this policy, or a > + * suitable node ID to allocate a replacement page from. > */ > int mpol_misplaced(struct page *page, struct vm_area_struct *vma, unsigned long addr) > { >