From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B790C2BA19 for ; Wed, 15 Apr 2020 20:46:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2884520732 for ; Wed, 15 Apr 2020 20:46:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2884520732 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A67318E0048; Wed, 15 Apr 2020 16:46:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A175C8E0001; Wed, 15 Apr 2020 16:46:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9068C8E0048; Wed, 15 Apr 2020 16:46:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0215.hostedemail.com [216.40.44.215]) by kanga.kvack.org (Postfix) with ESMTP id 796DB8E0001 for ; Wed, 15 Apr 2020 16:46:43 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 38531180AD802 for ; Wed, 15 Apr 2020 20:46:43 +0000 (UTC) X-FDA: 76711273086.22.elbow49_5799bfd495938 X-HE-Tag: elbow49_5799bfd495938 X-Filterd-Recvd-Size: 9497 Received: from out30-43.freemail.mail.aliyun.com (out30-43.freemail.mail.aliyun.com [115.124.30.43]) by imf33.hostedemail.com (Postfix) with ESMTP for ; Wed, 15 Apr 2020 20:46:41 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R191e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e01422;MF=yang.shi@linux.alibaba.com;NM=1;PH=DS;RN=9;SR=0;TI=SMTPD_---0TveCydq_1586983596; Received: from US-143344MP.local(mailfrom:yang.shi@linux.alibaba.com fp:SMTPD_---0TveCydq_1586983596) by smtp.aliyun-inc.com(127.0.0.1); Thu, 16 Apr 2020 04:46:38 +0800 Subject: Re: [PATCHv3, RESEND 6/8] khugepaged: Allow to collapse PTE-mapped compound pages To: "Kirill A. Shutemov" , akpm@linux-foundation.org, Andrea Arcangeli Cc: Zi Yan , Ralph Campbell , John Hubbard , William Kucharski , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20200413125220.663-1-kirill.shutemov@linux.intel.com> <20200413125220.663-7-kirill.shutemov@linux.intel.com> From: Yang Shi Message-ID: Date: Wed, 15 Apr 2020 13:46:35 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20200413125220.663-7-kirill.shutemov@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/13/20 5:52 AM, Kirill A. Shutemov wrote: > We can collapse PTE-mapped compound pages. We only need to avoid > handling them more than once: lock/unlock page only once if it's present > in the PMD range multiple times as it handled on compound level. The > same goes for LRU isolation and putback. > > Signed-off-by: Kirill A. Shutemov > --- > mm/khugepaged.c | 99 ++++++++++++++++++++++++++++++++----------------- > 1 file changed, 65 insertions(+), 34 deletions(-) Acked-by: Yang Shi > > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > index f9864644c3b7..11d500396d85 100644 > --- a/mm/khugepaged.c > +++ b/mm/khugepaged.c > @@ -515,17 +515,30 @@ void __khugepaged_exit(struct mm_struct *mm) > > static void release_pte_page(struct page *page) > { > - dec_node_page_state(page, NR_ISOLATED_ANON + page_is_file_cache(page)); > + mod_node_page_state(page_pgdat(page), > + NR_ISOLATED_ANON + page_is_file_cache(page), > + -compound_nr(page)); > unlock_page(page); > putback_lru_page(page); > } > > -static void release_pte_pages(pte_t *pte, pte_t *_pte) > +static void release_pte_pages(pte_t *pte, pte_t *_pte, > + struct list_head *compound_pagelist) > { > + struct page *page, *tmp; > + > while (--_pte >= pte) { > pte_t pteval = *_pte; > - if (!pte_none(pteval) && !is_zero_pfn(pte_pfn(pteval))) > - release_pte_page(pte_page(pteval)); > + > + page = pte_page(pteval); > + if (!pte_none(pteval) && !is_zero_pfn(pte_pfn(pteval)) && > + !PageCompound(page)) > + release_pte_page(page); > + } > + > + list_for_each_entry_safe(page, tmp, compound_pagelist, lru) { > + list_del(&page->lru); > + release_pte_page(page); > } > } > > @@ -549,7 +562,8 @@ static bool is_refcount_suitable(struct page *page) > > static int __collapse_huge_page_isolate(struct vm_area_struct *vma, > unsigned long address, > - pte_t *pte) > + pte_t *pte, > + struct list_head *compound_pagelist) > { > struct page *page = NULL; > pte_t *_pte; > @@ -579,13 +593,21 @@ static int __collapse_huge_page_isolate(struct vm_area_struct *vma, > goto out; > } > > - /* TODO: teach khugepaged to collapse THP mapped with pte */ > + VM_BUG_ON_PAGE(!PageAnon(page), page); > + > if (PageCompound(page)) { > - result = SCAN_PAGE_COMPOUND; > - goto out; > - } > + struct page *p; > + page = compound_head(page); > > - VM_BUG_ON_PAGE(!PageAnon(page), page); > + /* > + * Check if we have dealt with the compound page > + * already > + */ > + list_for_each_entry(p, compound_pagelist, lru) { > + if (page == p) > + goto next; > + } > + } > > /* > * We can do it before isolate_lru_page because the > @@ -614,19 +636,15 @@ static int __collapse_huge_page_isolate(struct vm_area_struct *vma, > result = SCAN_PAGE_COUNT; > goto out; > } > - if (pte_write(pteval)) { > - writable = true; > - } else { > - if (PageSwapCache(page) && > - !reuse_swap_page(page, NULL)) { > - unlock_page(page); > - result = SCAN_SWAP_CACHE_PAGE; > - goto out; > - } > + if (!pte_write(pteval) && PageSwapCache(page) && > + !reuse_swap_page(page, NULL)) { > /* > - * Page is not in the swap cache. It can be collapsed > - * into a THP. > + * Page is in the swap cache and cannot be re-used. > + * It cannot be collapsed into a THP. > */ > + unlock_page(page); > + result = SCAN_SWAP_CACHE_PAGE; > + goto out; > } > > /* > @@ -638,16 +656,23 @@ static int __collapse_huge_page_isolate(struct vm_area_struct *vma, > result = SCAN_DEL_PAGE_LRU; > goto out; > } > - inc_node_page_state(page, > - NR_ISOLATED_ANON + page_is_file_cache(page)); > + mod_node_page_state(page_pgdat(page), > + NR_ISOLATED_ANON + page_is_file_cache(page), > + compound_nr(page)); > VM_BUG_ON_PAGE(!PageLocked(page), page); > VM_BUG_ON_PAGE(PageLRU(page), page); > > + if (PageCompound(page)) > + list_add_tail(&page->lru, compound_pagelist); > +next: > /* There should be enough young pte to collapse the page */ > if (pte_young(pteval) || > page_is_young(page) || PageReferenced(page) || > mmu_notifier_test_young(vma->vm_mm, address)) > referenced++; > + > + if (pte_write(pteval)) > + writable = true; > } > if (likely(writable)) { > if (likely(referenced)) { > @@ -661,7 +686,7 @@ static int __collapse_huge_page_isolate(struct vm_area_struct *vma, > } > > out: > - release_pte_pages(pte, _pte); > + release_pte_pages(pte, _pte, compound_pagelist); > trace_mm_collapse_huge_page_isolate(page, none_or_zero, > referenced, writable, result); > return 0; > @@ -670,13 +695,14 @@ static int __collapse_huge_page_isolate(struct vm_area_struct *vma, > static void __collapse_huge_page_copy(pte_t *pte, struct page *page, > struct vm_area_struct *vma, > unsigned long address, > - spinlock_t *ptl) > + spinlock_t *ptl, > + struct list_head *compound_pagelist) > { > + struct page *src_page, *tmp; > pte_t *_pte; > for (_pte = pte; _pte < pte + HPAGE_PMD_NR; > _pte++, page++, address += PAGE_SIZE) { > pte_t pteval = *_pte; > - struct page *src_page; > > if (pte_none(pteval) || is_zero_pfn(pte_pfn(pteval))) { > clear_user_highpage(page, address); > @@ -696,7 +722,8 @@ static void __collapse_huge_page_copy(pte_t *pte, struct page *page, > } else { > src_page = pte_page(pteval); > copy_user_highpage(page, src_page, address, vma); > - release_pte_page(src_page); > + if (!PageCompound(src_page)) > + release_pte_page(src_page); > /* > * ptl mostly unnecessary, but preempt has to > * be disabled to update the per-cpu stats > @@ -713,6 +740,11 @@ static void __collapse_huge_page_copy(pte_t *pte, struct page *page, > free_page_and_swap_cache(src_page); > } > } > + > + list_for_each_entry_safe(src_page, tmp, compound_pagelist, lru) { > + list_del(&src_page->lru); > + release_pte_page(src_page); > + } > } > > static void khugepaged_alloc_sleep(void) > @@ -971,6 +1003,7 @@ static void collapse_huge_page(struct mm_struct *mm, > struct page **hpage, > int node, int referenced, int unmapped) > { > + LIST_HEAD(compound_pagelist); > pmd_t *pmd, _pmd; > pte_t *pte; > pgtable_t pgtable; > @@ -1071,7 +1104,8 @@ static void collapse_huge_page(struct mm_struct *mm, > mmu_notifier_invalidate_range_end(&range); > > spin_lock(pte_ptl); > - isolated = __collapse_huge_page_isolate(vma, address, pte); > + isolated = __collapse_huge_page_isolate(vma, address, pte, > + &compound_pagelist); > spin_unlock(pte_ptl); > > if (unlikely(!isolated)) { > @@ -1096,7 +1130,8 @@ static void collapse_huge_page(struct mm_struct *mm, > */ > anon_vma_unlock_write(vma->anon_vma); > > - __collapse_huge_page_copy(pte, new_page, vma, address, pte_ptl); > + __collapse_huge_page_copy(pte, new_page, vma, address, pte_ptl, > + &compound_pagelist); > pte_unmap(pte); > __SetPageUptodate(new_page); > pgtable = pmd_pgtable(_pmd); > @@ -1193,11 +1228,7 @@ static int khugepaged_scan_pmd(struct mm_struct *mm, > goto out_unmap; > } > > - /* TODO: teach khugepaged to collapse THP mapped with pte */ > - if (PageCompound(page)) { > - result = SCAN_PAGE_COMPOUND; > - goto out_unmap; > - } > + page = compound_head(page); > > /* > * Record which node the original page is from and save this