From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 969ACC35240 for ; Sun, 2 Feb 2020 08:31:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3D99220838 for ; Sun, 2 Feb 2020 08:31:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=c-s.fr header.i=@c-s.fr header.b="jxSd4bcB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3D99220838 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=c-s.fr Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DB10F6B0628; Sun, 2 Feb 2020 03:31:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D89036B0629; Sun, 2 Feb 2020 03:31:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C78046B062A; Sun, 2 Feb 2020 03:31:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0163.hostedemail.com [216.40.44.163]) by kanga.kvack.org (Postfix) with ESMTP id B20276B0628 for ; Sun, 2 Feb 2020 03:31:25 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 574028248047 for ; Sun, 2 Feb 2020 08:31:25 +0000 (UTC) X-FDA: 76444517730.06.ocean23_2973338d55d42 X-HE-Tag: ocean23_2973338d55d42 X-Filterd-Recvd-Size: 6162 Received: from pegase1.c-s.fr (pegase1.c-s.fr [93.17.236.30]) by imf27.hostedemail.com (Postfix) with ESMTP for ; Sun, 2 Feb 2020 08:31:24 +0000 (UTC) Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 489PLc2Pfyz9tyWF; Sun, 2 Feb 2020 09:31:20 +0100 (CET) Authentication-Results: localhost; dkim=pass reason="1024-bit key; insecure key" header.d=c-s.fr header.i=@c-s.fr header.b=jxSd4bcB; dkim-adsp=pass; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id 0yWRy2TLi9QC; Sun, 2 Feb 2020 09:31:20 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 489PLc0zVpz9tyWB; Sun, 2 Feb 2020 09:31:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c-s.fr; s=mail; t=1580632280; bh=gJ+YBiU1siNA6yw0ERrSRXytsUyJ6J4mmY1g8irtvMg=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=jxSd4bcBMPwDDkQQtltYvbDM7RjmY7wn3YHePmJyrQoSpGxb+srr+7WWVT07acbk4 Gd8wx/ElVf48v1NQ7kacblPWNxOSr0bIjH1lQW4QiWnAuYKH9BZIwizDmpyvIglx32 bf4U9cZQC+HCcZh0MgO0YttEmPTxX2H/LjarVNYo= Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id E45E88B762; Sun, 2 Feb 2020 09:31:22 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id wqc16BLAbHuO; Sun, 2 Feb 2020 09:31:22 +0100 (CET) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id A80498B752; Sun, 2 Feb 2020 09:31:20 +0100 (CET) Subject: Re: [PATCH V12] mm/debug: Add tests validating architecture page table helpers To: Anshuman Khandual , linux-mm@kvack.org Cc: Andrew Morton , Vlastimil Babka , Greg Kroah-Hartman , Thomas Gleixner , Mike Rapoport , Jason Gunthorpe , Dan Williams , Peter Zijlstra , Michal Hocko , Mark Rutland , Mark Brown , Steven Price , Ard Biesheuvel , Masahiro Yamada , Kees Cook , Tetsuo Handa , Matthew Wilcox , Sri Krishna chowdary , Dave Hansen , Russell King - ARM Linux , Michael Ellerman , Paul Mackerras , Martin Schwidefsky , Heiko Carstens , "David S. Miller" , Vineet Gupta , James Hogan , Paul Burton , Ralf Baechle , "Kirill A . Shutemov" , Gerald Schaefer , Ingo Molnar , linux-snps-arc@lists.infradead.org, linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org References: <1580174873-18117-1-git-send-email-anshuman.khandual@arm.com> <68ed6488-aa25-ab41-8da6-f0ddeb15d52b@c-s.fr> <49754f74-53a7-0e4a-bb16-53617f8c902c@arm.com> <473d8198-3ac4-af3b-e2ec-c0698a3565d3@c-s.fr> From: Christophe Leroy Message-ID: Date: Sun, 2 Feb 2020 09:31:18 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Le 02/02/2020 =C3=A0 08:18, Anshuman Khandual a =C3=A9crit=C2=A0: > On 01/30/2020 07:43 PM, Christophe Leroy wrote: >> >> >> Le 30/01/2020 =C3=A0 14:04, Anshuman Khandual a =C3=A9crit=C2=A0: >>> >>> On 01/28/2020 10:35 PM, Christophe Leroy wrote: >> >>> >>>> I think we could make it standalone and 'default y if DEBUG_VM' inst= ead. >>> >>> Which will yield the same result like before but in a different way. = But >>> yes, this test could go about either way but unless there is a good e= nough >>> reason why change the current one. >> >> I think if we want people to really use it on other architectures it m= ust be possible to activate it without having to modify Kconfig. Otherwis= e people won't even know the test exists and the architecture fails the t= est. >> >> The purpose of a test suite is to detect bugs. If you can't run the te= st until you have fixed the bugs, I guess nobody will ever detect the bug= s and they will never be fixed. >> >> So I think: >> - the test should be 'default y' when ARCH_HAS_DEBUG_VM_PGTABLE is sel= ected >> - the test should be 'default n' when ARCH_HAS_DEBUG_VM_PGTABLE is not= selected, and it should be user selectable if EXPERT is selected. >> >> Something like: >> >> config DEBUG_VM_PGTABLE >> =C2=A0=C2=A0=C2=A0 bool "Debug arch page table for semantics complian= ce" if ARCH_HAS_DEBUG_VM_PGTABLE || EXPERT >> =C2=A0=C2=A0=C2=A0 depends on MMU >=20 > (ARCH_HAS_DEBUG_VM_PGTABLE || EXPERT) be moved along side MMU on the sa= me line ? Yes could also go along side MMU, or could be a depend by itself: depends on ARCH_HAS_DEBUG_VM_PGTABLE || EXPERT >=20 >> =C2=A0=C2=A0=C2=A0 default 'n' if !ARCH_HAS_DEBUG_VM_PGTABLE >> =C2=A0=C2=A0=C2=A0 default 'y' if DEBUG_VM >=20 > This looks good, at least until we get all platforms enabled. Will do a= ll these > changes along with s390 enablement and re-spin. Christophe