From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4325C433E0 for ; Tue, 4 Aug 2020 06:22:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D392C206F6 for ; Tue, 4 Aug 2020 06:22:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D392C206F6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2859D8D0125; Tue, 4 Aug 2020 02:22:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 20EDD8D0081; Tue, 4 Aug 2020 02:22:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0AFF98D0125; Tue, 4 Aug 2020 02:22:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0189.hostedemail.com [216.40.44.189]) by kanga.kvack.org (Postfix) with ESMTP id E69778D0081 for ; Tue, 4 Aug 2020 02:22:48 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id A2E79180AD807 for ; Tue, 4 Aug 2020 06:22:48 +0000 (UTC) X-FDA: 77111892816.16.paint16_400c2a926fa4 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id 75795100E6903 for ; Tue, 4 Aug 2020 06:22:48 +0000 (UTC) X-HE-Tag: paint16_400c2a926fa4 X-Filterd-Recvd-Size: 3594 Received: from out30-44.freemail.mail.aliyun.com (out30-44.freemail.mail.aliyun.com [115.124.30.44]) by imf39.hostedemail.com (Postfix) with ESMTP for ; Tue, 4 Aug 2020 06:22:47 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R291e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04394;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=19;SR=0;TI=SMTPD_---0U4j3PBv_1596522158; Received: from IT-FVFX43SYHV2H.local(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0U4j3PBv_1596522158) by smtp.aliyun-inc.com(127.0.0.1); Tue, 04 Aug 2020 14:22:39 +0800 Subject: Re: [PATCH v17 20/21] mm/pgdat: remove pgdat lru_lock To: Alexander Duyck Cc: Andrew Morton , Mel Gorman , Tejun Heo , Hugh Dickins , Konstantin Khlebnikov , Daniel Jordan , Yang Shi , Matthew Wilcox , Johannes Weiner , kbuild test robot , linux-mm , LKML , cgroups@vger.kernel.org, Shakeel Butt , Joonsoo Kim , Wei Yang , "Kirill A. Shutemov" , Rong Chen References: <1595681998-19193-1-git-send-email-alex.shi@linux.alibaba.com> <1595681998-19193-21-git-send-email-alex.shi@linux.alibaba.com> From: Alex Shi Message-ID: Date: Tue, 4 Aug 2020 14:22:22 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 X-Rspamd-Queue-Id: 75795100E6903 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: =E5=9C=A8 2020/8/4 =E4=B8=8A=E5=8D=886:45, Alexander Duyck =E5=86=99=E9=81= =93: > Just to correct a typo, I meant patch 17, not 18. in the comment below. >=20 >=20 > On Mon, Aug 3, 2020 at 3:42 PM Alexander Duyck > wrote: >> >> On Sat, Jul 25, 2020 at 6:00 AM Alex Shi = wrote: >>> >>> Now pgdat.lru_lock was replaced by lruvec lock. It's not used anymore= . >>> >>> Signed-off-by: Alex Shi >>> Cc: Andrew Morton >>> Cc: Konstantin Khlebnikov >>> Cc: Hugh Dickins >>> Cc: Johannes Weiner >>> Cc: linux-mm@kvack.org >>> Cc: linux-kernel@vger.kernel.org >>> Cc: cgroups@vger.kernel.org >> >> I really think this would be better just squashed into patch 18 >> instead of as a standalone patch since you were moving all of the >> locking anyway so it would be more likely to trigger build errors if >> somebody didn't move a lock somewhere that was referencing this. Thanks for comments! If someone changed the lru_lock between patch 17 and this, it would cause more troubles then build error here. :) so don't warries for that. But on the other side, I am so insist to have a ceremony to remove this l= ock... =20 >> >> That said this change is harmless at this point. >> >> Reviewed-by: Alexander Duyck Thanks a lot for review!