From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C214FC433DB for ; Tue, 12 Jan 2021 03:51:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 610EC229CA for ; Tue, 12 Jan 2021 03:51:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 610EC229CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CB2CE8D0066; Mon, 11 Jan 2021 22:51:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C62308D0051; Mon, 11 Jan 2021 22:51:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B77738D0066; Mon, 11 Jan 2021 22:51:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0004.hostedemail.com [216.40.44.4]) by kanga.kvack.org (Postfix) with ESMTP id 9E3F58D0051 for ; Mon, 11 Jan 2021 22:51:05 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 57E11180AD811 for ; Tue, 12 Jan 2021 03:51:05 +0000 (UTC) X-FDA: 77695747290.20.prose08_270e97927512 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id 3D4A2180C07A3 for ; Tue, 12 Jan 2021 03:51:05 +0000 (UTC) X-HE-Tag: prose08_270e97927512 X-Filterd-Recvd-Size: 2245 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Tue, 12 Jan 2021 03:51:04 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D3E7B101E; Mon, 11 Jan 2021 19:51:02 -0800 (PST) Received: from [192.168.0.130] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 142843F66E; Mon, 11 Jan 2021 19:50:57 -0800 (PST) Subject: Re: [PATCH V2 1/3] mm/hotplug: Prevalidate the address range being added with platform To: Oscar Salvador , David Hildenbrand Cc: linux-mm@kvack.org, akpm@linux-foundation.org, hca@linux.ibm.com, catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Vasily Gorbik , Will Deacon , Ard Biesheuvel , Mark Rutland References: <1608218912-28932-1-git-send-email-anshuman.khandual@arm.com> <1608218912-28932-2-git-send-email-anshuman.khandual@arm.com> <10e733fa-4568-d38f-9b95-2ccc5dc627b8@redhat.com> <20210111134303.GA3031@linux> From: Anshuman Khandual Message-ID: Date: Tue, 12 Jan 2021 09:21:18 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210111134303.GA3031@linux> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/11/21 7:13 PM, Oscar Salvador wrote: > On Mon, Jan 11, 2021 at 11:51:47AM +0100, David Hildenbrand wrote: >> AFAIKs, all memhp_get_pluggable_range() users pass "1". >> >> What about the "add_pages()-only" path? > > I guess you refer to memremap_pages(), right? Right, via pagemap_range(). > If so, moving the added memhp_range_allowed() check above the if-else might do > the trick > We had that code in the earlier version. But dropped it, as we did not want to add any new checks in the generic code. Can add it back if that is preferred.