From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AEF3C4BA24 for ; Thu, 27 Feb 2020 05:09:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A8D1424656 for ; Thu, 27 Feb 2020 05:09:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A8D1424656 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F29176B0003; Thu, 27 Feb 2020 00:09:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EB1C96B0005; Thu, 27 Feb 2020 00:09:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D53436B0006; Thu, 27 Feb 2020 00:09:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0177.hostedemail.com [216.40.44.177]) by kanga.kvack.org (Postfix) with ESMTP id B8B696B0003 for ; Thu, 27 Feb 2020 00:09:15 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id DD3898248076 for ; Thu, 27 Feb 2020 05:09:13 +0000 (UTC) X-FDA: 76534728186.28.clam85_165354b97a51e X-HE-Tag: clam85_165354b97a51e X-Filterd-Recvd-Size: 7267 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Thu, 27 Feb 2020 05:09:13 +0000 (UTC) Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 01R596KL063182 for ; Thu, 27 Feb 2020 00:09:12 -0500 Received: from e06smtp07.uk.ibm.com (e06smtp07.uk.ibm.com [195.75.94.103]) by mx0a-001b2d01.pphosted.com with ESMTP id 2ydqbtegbt-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 27 Feb 2020 00:09:11 -0500 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 27 Feb 2020 05:09:09 -0000 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp07.uk.ibm.com (192.168.101.137) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 27 Feb 2020 05:09:01 -0000 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 01R591Io53542972 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 27 Feb 2020 05:09:01 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EAA95A404D; Thu, 27 Feb 2020 05:09:00 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 417E3A4040; Thu, 27 Feb 2020 05:09:00 +0000 (GMT) Received: from ozlabs.au.ibm.com (unknown [9.192.253.14]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 27 Feb 2020 05:09:00 +0000 (GMT) Received: from [10.61.2.125] (haven.au.ibm.com [9.192.254.114]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by ozlabs.au.ibm.com (Postfix) with ESMTPSA id 2E3BFA01C0; Thu, 27 Feb 2020 16:08:55 +1100 (AEDT) Subject: Re: [PATCH v3 12/27] powerpc/powernv/pmem: Add register addresses & status values to the header To: "Alastair D'Silva" , alastair@d-silva.org Cc: "Aneesh Kumar K . V" , "Oliver O'Halloran" , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Frederic Barrat , Arnd Bergmann , Greg Kroah-Hartman , Dan Williams , Vishal Verma , Dave Jiang , Ira Weiny , Andrew Morton , Mauro Carvalho Chehab , "David S. Miller" , Rob Herring , Anton Blanchard , Krzysztof Kozlowski , Mahesh Salgaonkar , Madhavan Srinivasan , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Anju T Sudhakar , Hari Bathini , Thomas Gleixner , Greg Kurz , Nicholas Piggin , Masahiro Yamada , Alexey Kardashevskiy , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-nvdimm@lists.01.org, linux-mm@kvack.org References: <20200221032720.33893-1-alastair@au1.ibm.com> <20200221032720.33893-13-alastair@au1.ibm.com> From: Andrew Donnellan Date: Thu, 27 Feb 2020 16:08:58 +1100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200221032720.33893-13-alastair@au1.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 20022705-0028-0000-0000-000003DE5EF4 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 20022705-0029-0000-0000-000024A37CF0 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.572 definitions=2020-02-26_09:2020-02-26,2020-02-26 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 phishscore=0 impostorscore=0 suspectscore=0 adultscore=0 mlxscore=0 mlxlogscore=999 clxscore=1015 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2002270038 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 21/2/20 2:27 pm, Alastair D'Silva wrote: > From: Alastair D'Silva > > These values have been taken from the device specifications. > > Signed-off-by: Alastair D'Silva I've compared these values against the internal version of the device specifications that I have access to, and they appear to match. A few minor comments below, otherwise: Reviewed-by: Andrew Donnellan > +#define GLOBAL_MMIO_HCI_ACRW BIT_ULL(0) > +#define GLOBAL_MMIO_HCI_NSCRW BIT_ULL(1) > +#define GLOBAL_MMIO_HCI_AFU_RESET BIT_ULL(2) > +#define GLOBAL_MMIO_HCI_FW_DEBUG BIT_ULL(3) > +#define GLOBAL_MMIO_HCI_CONTROLLER_DUMP BIT_ULL(4) > +#define GLOBAL_MMIO_HCI_CONTROLLER_DUMP_COLLECTED BIT_ULL(5) > +#define GLOBAL_MMIO_HCI_REQ_HEALTH_PERF BIT_ULL(6) The labelling of some of these bits deviates from the standard abbreviations in the spec, which is fine I guess as these names are more descriptive, but maybe add a brief comment with the original abbreviation? > + > +#define ADMIN_COMMAND_HEARTBEAT 0x00u > +#define ADMIN_COMMAND_SHUTDOWN 0x01u > +#define ADMIN_COMMAND_FW_UPDATE 0x02u > +#define ADMIN_COMMAND_FW_DEBUG 0x03u > +#define ADMIN_COMMAND_ERRLOG 0x04u > +#define ADMIN_COMMAND_SMART 0x05u > +#define ADMIN_COMMAND_CONTROLLER_STATS 0x06u > +#define ADMIN_COMMAND_CONTROLLER_DUMP 0x07u > +#define ADMIN_COMMAND_CMD_CAPS 0x08u > +#define ADMIN_COMMAND_MAX 0x08u > + > +#define STATUS_SUCCESS 0x00 > +#define STATUS_MEM_UNAVAILABLE 0x20 There's also a "blocked on account of background task" code, 0x21. > +#define STATUS_BAD_OPCODE 0x50 > +#define STATUS_BAD_REQUEST_PARM 0x51 > +#define STATUS_BAD_DATA_PARM 0x52 > +#define STATUS_DEBUG_BLOCKED 0x70 > +#define STATUS_FAIL 0xFF > + > +#define STATUS_FW_UPDATE_BLOCKED 0x21 > +#define STATUS_FW_ARG_INVALID 0x51 > +#define STATUS_FW_INVALID 0x52 These status codes seem, from the specification, to correspond to the generic error codes above, so perhaps they're not needed. -- Andrew Donnellan OzLabs, ADL Canberra ajd@linux.ibm.com IBM Australia Limited