From: David Rientjes <rientjes@google.com>
To: Yafang Shao <laoar.shao@gmail.com>
Cc: pmladek@suse.com, willy@infradead.org,
andriy.shevchenko@linux.intel.com, david@redhat.com,
linmiaohe@huawei.com, vbabka@suse.cz, cl@linux.com,
penberg@kernel.org, iamjoonsoo.kim@lge.com,
akpm@linux-foundation.org, rostedt@goodmis.org,
sergey.senozhatsky@gmail.com, joe@perches.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/3] mm, slub: don't combine pr_err with INFO
Date: Wed, 17 Feb 2021 10:21:43 -0800 (PST) [thread overview]
Message-ID: <e5289046-1dc-e90-56d0-30dd63da93a@google.com> (raw)
In-Reply-To: <20210215155141.47432-3-laoar.shao@gmail.com>
On Mon, 15 Feb 2021, Yafang Shao wrote:
> It is strange to combine "pr_err" with "INFO", so let's remove the
> prefix completely.
> This patch is motivated by David's comment[1].
>
> - before the patch
> [ 8846.517809] INFO: Slab 0x00000000f42a2c60 objects=33 used=3 fp=0x0000000060d32ca8 flags=0x17ffffc0010200(slab|head)
>
> - after the patch
> [ 6343.396602] Slab 0x000000004382e02b objects=33 used=3 fp=0x000000009ae06ffc flags=0x17ffffc0010200(slab|head)
>
> [1]. https://lore.kernel.org/linux-mm/b9c0f2b6-e9b0-0c36-ebdd-2bc684c5a762@redhat.com/#t
>
> Suggested-by: Vlastimil Babka <vbabka@suse.cz>
> Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
> Acked-by: Vlastimil Babka <vbabka@suse.cz>
> Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reviewed-by: David Hildenbrand <david@redhat.com>
> Cc: Matthew Wilcox <willy@infradead.org>
Acked-by: David Rientjes <rientjes@google.com>
next prev parent reply other threads:[~2021-02-17 18:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-15 15:51 [PATCH v5 0/3] mm, vsprintf: dump full information of page flags in pGp Yafang Shao
2021-02-15 15:51 ` [PATCH v5 1/3] mm, slub: use pGp to print page flags Yafang Shao
2021-02-15 15:51 ` [PATCH v5 2/3] mm, slub: don't combine pr_err with INFO Yafang Shao
2021-02-17 18:21 ` David Rientjes [this message]
2021-02-15 15:51 ` [PATCH v5 3/3] vsprintf: dump full information of page flags in pGp Yafang Shao
2021-02-22 9:59 ` Yafang Shao
2021-02-22 12:38 ` Petr Mladek
2021-02-22 13:39 ` Matthew Wilcox
2021-03-03 15:43 ` Petr Mladek
2021-03-09 10:21 ` Petr Mladek
2021-02-23 1:10 ` Yafang Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5289046-1dc-e90-56d0-30dd63da93a@google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=cl@linux.com \
--cc=david@redhat.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=joe@perches.com \
--cc=laoar.shao@gmail.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).