From: Joe Perches <joe@perches.com>
To: Yafang Shao <laoar.shao@gmail.com>,
david@redhat.com, vbabka@suse.cz, cl@linux.com,
penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com,
akpm@linux-foundation.org, pmladek@suse.com,
rostedt@goodmis.org, sergey.senozhatsky@gmail.com,
andriy.shevchenko@linux.intel.com, linux@rasmusvillemoes.dk
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] printk: dump full information of page flags in pGp
Date: Wed, 27 Jan 2021 18:35:53 -0800 [thread overview]
Message-ID: <e5ea9e8b1190c2a397a1b84dd55bb9c706dc7058.camel@perches.com> (raw)
In-Reply-To: <20210128021947.22877-4-laoar.shao@gmail.com>
On Thu, 2021-01-28 at 10:19 +0800, Yafang Shao wrote:
> Currently the pGp only shows the names of page flags, rather than
> the full information including section, node, zone, last cpupid and
> kasan tag. While it is not easy to parse these information manually
> because there're so many flavors. Let's interpret them in pGp as well.
[]
> diff --git a/lib/vsprintf.c b/lib/vsprintf.c
[]
> @@ -1916,6 +1916,46 @@ char *format_flags(char *buf, char *end, unsigned long flags,
> return buf;
> }
>
> +struct page_flags_layout {
> + int width;
> + int shift;
> + int mask;
> + char *name;
> +};
> +
> +struct page_flags_layout pfl[] = {
static const struct page_flags_layout pfl[] = {
> + {SECTIONS_WIDTH, SECTIONS_PGSHIFT, SECTIONS_MASK, "Section "},
> + {NODES_WIDTH, NODES_PGSHIFT, NODES_MASK, "Node "},
> + {ZONES_WIDTH, ZONES_PGSHIFT, ZONES_MASK, "Zone "},
> + {LAST_CPUPID_WIDTH, LAST_CPUPID_PGSHIFT, LAST_CPUPID_MASK, "Lastcpupid "},
> + {KASAN_TAG_WIDTH, KASAN_TAG_PGSHIFT, KASAN_TAG_MASK, "Kasantag "},
> +};
> +
> +static
> +char *format_layout(char *buf, char *end, unsigned long flags)
poor name. perhaps format_page_flags
> +{
> + int i;
> +
> + for (i = 0; i < sizeof(pfl) / sizeof(struct page_flags_layout) && buf < end; i++) {
for (i = 0; i < ARRAY_SIZE(pfl) && buf < end; i++) {
> @@ -1929,7 +1969,7 @@ char *flags_string(char *buf, char *end, void *flags_ptr,
> switch (fmt[1]) {
> case 'p':
> flags = *(unsigned long *)flags_ptr;
> - /* Remove zone id */
> + buf = format_layout(buf, end, flags & ~((1UL << NR_PAGEFLAGS) - 1));
> flags &= (1UL << NR_PAGEFLAGS) - 1;
Perhaps store the bitshift into a temp and use the temp twice
foo = BIT(NR_PAGEFLAGS) - 1;
buf = format_layout(buf, end, flags & ~foo);
flags &= foo;
next prev parent reply other threads:[~2021-01-28 2:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 2:19 [PATCH 0/3] mm, printk: dump full information of page flags in pGp Yafang Shao
2021-01-28 2:19 ` [PATCH 1/3] mm, slub: use pGp to print page flags Yafang Shao
2021-01-28 10:23 ` Vlastimil Babka
2021-01-28 22:42 ` David Rientjes
2021-01-28 2:19 ` [PATCH 2/3] mm, slub: don't combine pr_err with INFO Yafang Shao
2021-01-28 10:35 ` Vlastimil Babka
2021-01-28 13:06 ` Yafang Shao
2021-01-28 2:19 ` [PATCH 3/3] printk: dump full information of page flags in pGp Yafang Shao
2021-01-28 2:35 ` Joe Perches [this message]
2021-01-28 7:42 ` Yafang Shao
2021-01-28 2:52 ` Miaohe Lin
2021-01-28 7:44 ` Yafang Shao
2021-01-28 10:42 ` Vlastimil Babka
2021-01-28 13:07 ` Yafang Shao
2021-01-28 12:11 ` Andy Shevchenko
2021-01-28 13:18 ` Yafang Shao
2021-01-28 14:50 ` Andy Shevchenko
2021-01-29 1:21 ` Yafang Shao
2021-01-28 12:12 ` [PATCH 0/3] mm, " Andy Shevchenko
2021-01-28 13:19 ` Yafang Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5ea9e8b1190c2a397a1b84dd55bb9c706dc7058.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=cl@linux.com \
--cc=david@redhat.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=laoar.shao@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@rasmusvillemoes.dk \
--cc=penberg@kernel.org \
--cc=pmladek@suse.com \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).