From: Marc Zyngier <maz@kernel.org>
To: Pavel Tatashin <pasha.tatashin@soleen.com>
Cc: jmorris@namei.org, sashal@kernel.org, ebiederm@xmission.com,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
corbet@lwn.net, catalin.marinas@arm.com, will@kernel.org,
linux-arm-kernel@lists.infradead.org, james.morse@arm.com,
vladimir.murzin@arm.com, matthias.bgg@gmail.com,
bhsharma@redhat.com, linux-mm@kvack.org, mark.rutland@arm.com,
steve.capper@arm.com, rfontana@redhat.com, tglx@linutronix.de,
selindag@gmail.com
Subject: Re: [PATCH v9 15/18] arm64: kexec: kexec EL2 vectors
Date: Wed, 29 Apr 2020 18:35:06 +0100 [thread overview]
Message-ID: <e5f1ee17f8e4ac3a5f5077d85318e0ed@kernel.org> (raw)
In-Reply-To: <20200326032420.27220-16-pasha.tatashin@soleen.com>
On 2020-03-26 03:24, Pavel Tatashin wrote:
> If we have a EL2 mode without VHE, the EL2 vectors are needed in order
> to switch to EL2 and jump to new world with hyperivsor privileges.
>
> Signed-off-by: Pavel Tatashin <pasha.tatashin@soleen.com>
> ---
> arch/arm64/include/asm/kexec.h | 5 +++++
> arch/arm64/kernel/asm-offsets.c | 1 +
> arch/arm64/kernel/machine_kexec.c | 5 +++++
> arch/arm64/kernel/relocate_kernel.S | 35 +++++++++++++++++++++++++++++
> 4 files changed, 46 insertions(+)
>
> diff --git a/arch/arm64/include/asm/kexec.h
> b/arch/arm64/include/asm/kexec.h
> index d944c2e289b2..0f758fd51518 100644
> --- a/arch/arm64/include/asm/kexec.h
> +++ b/arch/arm64/include/asm/kexec.h
> @@ -95,6 +95,7 @@ static inline void crash_post_resume(void) {}
> extern const unsigned long kexec_relocate_code_size;
> extern const unsigned char kexec_relocate_code_start[];
> extern const unsigned long kexec_kern_reloc_offset;
> +extern const unsigned long kexec_el2_vectors_offset;
> #endif
>
> /*
> @@ -104,6 +105,9 @@ extern const unsigned long kexec_kern_reloc_offset;
> * kernel, or purgatory entry address).
> * kern_arg0 first argument to kernel is its dtb address. The other
> * arguments are currently unused, and must be set to 0
> + * el2_vector If present means that relocation routine will go to EL1
> + * from EL2 to do the copy, and then back to EL2 to do the jump
> + * to new world.
> */
> struct kern_reloc_arg {
> phys_addr_t head;
> @@ -112,6 +116,7 @@ struct kern_reloc_arg {
> phys_addr_t kern_arg1;
> phys_addr_t kern_arg2;
> phys_addr_t kern_arg3;
> + phys_addr_t el2_vector;
> };
>
> #define ARCH_HAS_KIMAGE_ARCH
> diff --git a/arch/arm64/kernel/asm-offsets.c
> b/arch/arm64/kernel/asm-offsets.c
> index 448230684749..ff974b648347 100644
> --- a/arch/arm64/kernel/asm-offsets.c
> +++ b/arch/arm64/kernel/asm-offsets.c
> @@ -136,6 +136,7 @@ int main(void)
> DEFINE(KEXEC_KRELOC_KERN_ARG1, offsetof(struct kern_reloc_arg,
> kern_arg1));
> DEFINE(KEXEC_KRELOC_KERN_ARG2, offsetof(struct kern_reloc_arg,
> kern_arg2));
> DEFINE(KEXEC_KRELOC_KERN_ARG3, offsetof(struct kern_reloc_arg,
> kern_arg3));
> + DEFINE(KEXEC_KRELOC_EL2_VECTOR, offsetof(struct kern_reloc_arg,
> el2_vector));
> #endif
> return 0;
> }
> diff --git a/arch/arm64/kernel/machine_kexec.c
> b/arch/arm64/kernel/machine_kexec.c
> index ab571fca9bd1..bd398def7627 100644
> --- a/arch/arm64/kernel/machine_kexec.c
> +++ b/arch/arm64/kernel/machine_kexec.c
> @@ -84,6 +84,11 @@ int machine_kexec_post_load(struct kimage *kimage)
> kern_reloc_arg->head = kimage->head;
> kern_reloc_arg->entry_addr = kimage->start;
> kern_reloc_arg->kern_arg0 = kimage->arch.dtb_mem;
> + /* Setup vector table only when EL2 is available, but no VHE */
> + if (is_hyp_mode_available() && !is_kernel_in_hyp_mode()) {
> + kern_reloc_arg->el2_vector = __pa(reloc_code)
> + + kexec_el2_vectors_offset;
> + }
> kexec_image_info(kimage);
>
> return 0;
> diff --git a/arch/arm64/kernel/relocate_kernel.S
> b/arch/arm64/kernel/relocate_kernel.S
> index aa9f2b2cd77c..6fd2fc0ef373 100644
> --- a/arch/arm64/kernel/relocate_kernel.S
> +++ b/arch/arm64/kernel/relocate_kernel.S
> @@ -89,6 +89,38 @@ ENTRY(arm64_relocate_new_kernel)
> .ltorg
> END(arm64_relocate_new_kernel)
>
> +.macro el1_sync_64
> + br x4 /* Jump to new world from el2 */
> + .fill 31, 4, 0 /* Set other 31 instr to zeroes */
> +.endm
The common idiom to write this is to align the beginning of the
macro, and not to bother about what follows:
.macro whatever
.align 7
br x4
.endm
Specially given that 0 is an undefined instruction, and I really hate to
see
those in the actual text. On the contrary, .align generates NOPs.
> +
> +.macro invalid_vector label
> +\label:
> + b \label
> + .fill 31, 4, 0 /* Set other 31 instr to zeroes */
> +.endm
> +
> +/* el2 vectors - switch el2 here while we restore the memory image. */
> + .align 11
> +ENTRY(kexec_el2_vectors)
Please see commit 617a2f392c92 ("arm64: kvm: Annotate assembly using
modern
annoations"), and follow the same pattern.
> + invalid_vector el2_sync_invalid_sp0 /* Synchronous EL2t */
> + invalid_vector el2_irq_invalid_sp0 /* IRQ EL2t */
> + invalid_vector el2_fiq_invalid_sp0 /* FIQ EL2t */
> + invalid_vector el2_error_invalid_sp0 /* Error EL2t */
> + invalid_vector el2_sync_invalid_spx /* Synchronous EL2h */
> + invalid_vector el2_irq_invalid_spx /* IRQ EL2h */
> + invalid_vector el2_fiq_invalid_spx /* FIQ EL2h */
> + invalid_vector el2_error_invalid_spx /* Error EL2h */
> + el1_sync_64 /* Synchronous 64-bit EL1 */
> + invalid_vector el1_irq_invalid_64 /* IRQ 64-bit EL1 */
> + invalid_vector el1_fiq_invalid_64 /* FIQ 64-bit EL1 */
> + invalid_vector el1_error_invalid_64 /* Error 64-bit EL1 */
> + invalid_vector el1_sync_invalid_32 /* Synchronous 32-bit EL1 */
> + invalid_vector el1_irq_invalid_32 /* IRQ 32-bit EL1 */
> + invalid_vector el1_fiq_invalid_32 /* FIQ 32-bit EL1 */
> + invalid_vector el1_error_invalid_32 /* Error 32-bit EL1 */
> +END(kexec_el2_vectors)
Please write the vectors in 4 groups of 4, as this makes it a lot easier
to follow what is what.
> +
> .Lkexec_relocate_code_end:
> .org KEXEC_CONTROL_PAGE_SIZE
> .align 3 /* To keep the 64-bit values below naturally aligned. */
> @@ -102,3 +134,6 @@ kexec_relocate_code_size:
> .globl kexec_kern_reloc_offset
> kexec_kern_reloc_offset:
> .quad arm64_relocate_new_kernel - kexec_relocate_code_start
> +.globl kexec_el2_vectors_offset
> +kexec_el2_vectors_offset:
> + .quad kexec_el2_vectors - kexec_relocate_code_start
Thanks,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2020-04-29 17:35 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 3:24 [PATCH v9 00/18] arm64: MMU enabled kexec relocation Pavel Tatashin
2020-03-26 3:24 ` [PATCH v9 01/18] arm64: kexec: make dtb_mem always enabled Pavel Tatashin
2020-04-29 17:00 ` James Morse
2021-01-23 0:17 ` Pavel Tatashin
2020-03-26 3:24 ` [PATCH v9 02/18] arm64: hibernate: move page handling function to new trans_pgd.c Pavel Tatashin
2020-04-29 17:00 ` James Morse
2021-01-23 0:18 ` Pavel Tatashin
2020-03-26 3:24 ` [PATCH v9 03/18] arm64: trans_pgd: make trans_pgd_map_page generic Pavel Tatashin
2020-04-29 17:01 ` James Morse
2021-01-22 21:52 ` Pavel Tatashin
2020-03-26 3:24 ` [PATCH v9 04/18] arm64: trans_pgd: pass allocator trans_pgd_create_copy Pavel Tatashin
2020-04-29 17:01 ` James Morse
2021-01-23 0:20 ` Pavel Tatashin
2020-03-26 3:24 ` [PATCH v9 05/18] arm64: trans_pgd: pass NULL instead of init_mm to *_populate functions Pavel Tatashin
2020-04-29 17:01 ` James Morse
2021-01-23 0:22 ` Pavel Tatashin
2020-03-26 3:24 ` [PATCH v9 06/18] arm64: mm: Always update TCR_EL1 from __cpu_set_tcr_t0sz() Pavel Tatashin
2020-03-26 3:24 ` [PATCH v9 07/18] arm64: trans_pgd: hibernate: idmap the single page that holds the copy page routines Pavel Tatashin
2020-04-29 17:01 ` James Morse
2021-01-23 0:35 ` Pavel Tatashin
2020-03-26 3:24 ` [PATCH v9 08/18] arm64: kexec: move relocation function setup Pavel Tatashin
2020-04-29 17:01 ` James Morse
2021-01-23 1:01 ` Pavel Tatashin
2020-03-26 3:24 ` [PATCH v9 09/18] arm64: kexec: call kexec_image_info only once Pavel Tatashin
2020-04-29 17:01 ` James Morse
2020-03-26 3:24 ` [PATCH v9 10/18] arm64: kexec: cpu_soft_restart change argument types Pavel Tatashin
2020-04-29 17:01 ` James Morse
2021-01-23 1:14 ` Pavel Tatashin
2020-03-26 3:24 ` [PATCH v9 11/18] arm64: kexec: arm64_relocate_new_kernel clean-ups Pavel Tatashin
2020-05-07 16:22 ` James Morse
2020-03-26 3:24 ` [PATCH v9 12/18] arm64: kexec: arm64_relocate_new_kernel don't use x0 as temp Pavel Tatashin
2020-05-07 16:22 ` James Morse
2020-03-26 3:24 ` [PATCH v9 13/18] arm64: kexec: add expandable argument to relocation function Pavel Tatashin
2020-05-07 16:22 ` James Morse
2021-01-23 2:49 ` Pavel Tatashin
2020-03-26 3:24 ` [PATCH v9 14/18] arm64: kexec: offset for " Pavel Tatashin
2020-05-07 16:22 ` James Morse
2020-03-26 3:24 ` [PATCH v9 15/18] arm64: kexec: kexec EL2 vectors Pavel Tatashin
2020-04-29 17:35 ` Marc Zyngier [this message]
2021-01-25 19:07 ` Pavel Tatashin
2020-05-07 16:21 ` James Morse
2020-03-26 3:24 ` [PATCH v9 16/18] arm64: kexec: configure trans_pgd page table for kexec Pavel Tatashin
2020-05-07 16:22 ` James Morse
2020-03-26 3:24 ` [PATCH v9 17/18] arm64: kexec: enable MMU during kexec relocation Pavel Tatashin
2020-03-26 3:24 ` [PATCH v9 18/18] arm64: kexec: remove head from relocation argument Pavel Tatashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5f1ee17f8e4ac3a5f5077d85318e0ed@kernel.org \
--to=maz@kernel.org \
--cc=bhsharma@redhat.com \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=ebiederm@xmission.com \
--cc=james.morse@arm.com \
--cc=jmorris@namei.org \
--cc=kexec@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=pasha.tatashin@soleen.com \
--cc=rfontana@redhat.com \
--cc=sashal@kernel.org \
--cc=selindag@gmail.com \
--cc=steve.capper@arm.com \
--cc=tglx@linutronix.de \
--cc=vladimir.murzin@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).