From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: Anshuman Khandual <anshuman.khandual@arm.com>,
<linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Michal Hocko <mhocko@suse.com>, <linux-ia64@vger.kernel.org>,
<linux-sh@vger.kernel.org>, Peter Zijlstra <peterz@infradead.org>,
Catalin Marinas <catalin.marinas@arm.com>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
Will Deacon <will.deacon@arm.com>,
Paul Mackerras <paulus@samba.org>, <sparclinux@vger.kernel.org>,
"Stephen Rothwell" <sfr@canb.auug.org.au>,
<linux-s390@vger.kernel.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Michael Ellerman <mpe@ellerman.id.au>, <x86@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Matthew Wilcox <willy@infradead.org>,
Ingo Molnar <mingo@redhat.com>, James Hogan <jhogan@kernel.org>,
<linux-snps-arc@lists.infradead.org>,
Fenghua Yu <fenghua.yu@intel.com>,
Andrey Konovalov <andreyknvl@google.com>,
"Andy Lutomirski" <luto@kernel.org>,
Thomas Gleixner <tglx@synopsys.com>,
"Masami Hiramatsu" <masami.hiramatsu.pt@hitachi.com>
Subject: Re: [PATCH] mm: Generalize and rename notify_page_fault() as kprobe_page_fault()
Date: Thu, 13 Jun 2019 10:57:45 -0700 [thread overview]
Message-ID: <e5f45089-c3aa-4d78-2c8d-ed22f863d9ee@synopsys.com> (raw)
In-Reply-To: <1560420444-25737-1-git-send-email-anshuman.khandual@arm.com>
+CC Masami San
On 6/13/19 3:07 AM, Anshuman Khandual wrote:
> Questions:
>
> AFAICT there is no equivalent of erstwhile notify_page_fault() during page
> fault handling in arc and mips archs which can call this generic function.
> Please let me know if that is not the case.
For ARC do_page_fault() is entered for MMU exceptions (TLB Miss, access violations
r/w/x etc). kprobes uses a combination of UNIMP_S and TRAP_S instructions which
don't funnel into do_page_fault().
UINMP_S leads to
instr_service
do_insterror_or_kprobe
notify_die(DIE_IERR)
kprobe_exceptions_notify
arc_kprobe_handler
TRAP_S 2 leads to
EV_Trap
do_non_swi_trap
trap_is_kprobe
notify_die(DIE_TRAP)
kprobe_exceptions_notify
arc_post_kprobe_handler
But indeed we are *not* calling into kprobe_fault_handler() - from eithet of those
paths and not sure if the existing arc*_kprobe_handler() combination does the
equivalent in tandem.
-Vineet
next prev parent reply other threads:[~2019-06-13 17:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 10:07 [PATCH] mm: Generalize and rename notify_page_fault() as kprobe_page_fault() Anshuman Khandual
2019-06-13 17:57 ` Vineet Gupta [this message]
2019-06-18 15:56 ` Vineet Gupta
2019-06-20 7:19 ` Masami Hiramatsu
2019-06-13 20:04 ` Andrew Morton
2019-06-14 5:15 ` Anshuman Khandual
2019-06-29 14:50 ` Guenter Roeck
2019-06-30 4:41 ` Anshuman Khandual
2019-07-01 9:35 ` [DRAFT] mm/kprobes: Add generic kprobe_fault_handler() fallback definition Anshuman Khandual
2019-07-01 13:28 ` Guenter Roeck
2019-07-03 5:35 ` Anshuman Khandual
2019-07-03 12:59 ` Guenter Roeck
2019-07-03 14:11 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5f45089-c3aa-4d78-2c8d-ed22f863d9ee@synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=andreyknvl@google.com \
--cc=anshuman.khandual@arm.com \
--cc=catalin.marinas@arm.com \
--cc=dave.hansen@linux.intel.com \
--cc=fenghua.yu@intel.com \
--cc=jhogan@kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=luto@kernel.org \
--cc=mark.rutland@arm.com \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@synopsys.com \
--cc=will.deacon@arm.com \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).