From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D94EC47082 for ; Mon, 31 May 2021 21:13:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 75EBF6135B for ; Mon, 31 May 2021 21:13:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 75EBF6135B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CC1748D0001; Mon, 31 May 2021 17:13:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C98946B006C; Mon, 31 May 2021 17:13:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B12048D0001; Mon, 31 May 2021 17:13:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0118.hostedemail.com [216.40.44.118]) by kanga.kvack.org (Postfix) with ESMTP id 7A1446B0036 for ; Mon, 31 May 2021 17:13:37 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 905C098B9 for ; Mon, 31 May 2021 21:13:36 +0000 (UTC) X-FDA: 78202777632.17.FBF231A Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by imf20.hostedemail.com (Postfix) with ESMTP id EDED136D for ; Mon, 31 May 2021 21:13:20 +0000 (UTC) Received: by mail-pj1-f49.google.com with SMTP id m8-20020a17090a4148b029015fc5d36343so607296pjg.1 for ; Mon, 31 May 2021 14:13:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=LW0vl/hPnVGSly3VDkGIzhu2V9/k+bcQNfCUTpERlgM=; b=YWhF1lBk/tLmGWtD5cy8ck7UqSAiRSXGygv3obAjb1C3oRikFyW6m29zQJxQeMzorV N2QTxnSTXrYkgZS7lL3QkLFHjBEnmD45o4fvJGHwlyAAowgUvXGf0PEWnADScA6sBlBR cJrG87p6Fry51970S10NjqiSUuh+QZNkJpFHEw8b5BOnk//6FbnAxK3TBIpLe1QdaHUA UqM7KPQWZXaak6TQwY/XDDNYXDYnMqcc1Cwa78QBG937BZNzZyZ+LM/EEBbnb5uN/sU3 xnYbaPUPnoI6NphARwkya9+ZmxoHTL4kO+EbP2+PFsUcgXS3ENNB0e9l1WiRicW56kuL njxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=LW0vl/hPnVGSly3VDkGIzhu2V9/k+bcQNfCUTpERlgM=; b=NhaWGkfKdRTuKCJtlKuXq7EhxpVZqCvltNfDrelp3qsflwVvbPwAgeotIZJui8aOHT UNdehpbyNniS4UWTVjKUUbP56hvTQ4VH2R67MB4lMXQDCMH+llcYxMqkjej8sgN00vy5 LlLVVuOegakRBcpaahRxXJwfpEvvGaf1/CbIY8upuez6w0KgGB6G6pRysrHG7gGkp1gd 8/rDO4mqbpla6DnFbEjd+DqNgWslTIiLpVdSE7PY0Tz1ugYa8lTdaMZOBiz64s0lXJno GtwpMXZ6Os0q0L//4ymeLMZnaW7qgwAjY7iUhbrKqX1f+YJ1A8TnlfYOeF9LG9I827IK jVBw== X-Gm-Message-State: AOAM533238FwRDMD7eyQbY5aAjYwA19MAJHBltZif0La61QSfVa242hQ 2Lj2PZV07aMY+ExKEXLPgpU= X-Google-Smtp-Source: ABdhPJxCLtShnBPDLXPOGS1BZnwVS2Ie+0dADGTjOIXza/EKKNfRoepruWQQGHjOfOb9NJx3fP47sg== X-Received: by 2002:a17:90a:80c5:: with SMTP id k5mr1004969pjw.129.1622495615154; Mon, 31 May 2021 14:13:35 -0700 (PDT) Received: from [192.168.0.15] (c-73-158-171-241.hsd1.ca.comcast.net. [73.158.171.241]) by smtp.gmail.com with ESMTPSA id bv3sm501772pjb.1.2021.05.31.14.13.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 May 2021 14:13:34 -0700 (PDT) Subject: Re: Sealed memfd & no-fault mmap From: Ming Lin To: Hugh Dickins , Linus Torvalds , Simon Ser Cc: Peter Xu , "Kirill A. Shutemov" , Matthew Wilcox , Dan Williams , "Kirill A. Shutemov" , Will Deacon , Linux Kernel Mailing List , David Herrmann , "linux-mm@kvack.org" , Greg Kroah-Hartman , "tytso@mit.edu" References: <20210429154807.hptls4vnmq2svuea@box> <20210429183836.GF8339@xz-x1> <7718ec5b-0a9e-ffa6-16f2-bc0b6afbd9ab@gmail.com> <80c87e6b-6050-bf23-2185-ded408df4d0f@gmail.com> <36fc2485-11f1-5252-904d-f26b63a6cd58@gmail.com> Message-ID: Date: Mon, 31 May 2021 14:13:28 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <36fc2485-11f1-5252-904d-f26b63a6cd58@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-Rspamd-Queue-Id: EDED136D Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=YWhF1lBk; spf=pass (imf20.hostedemail.com: domain of minggr@gmail.com designates 209.85.216.49 as permitted sender) smtp.mailfrom=minggr@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam04 X-Stat-Signature: 4pra8cdjyyw39eahrrr3ku4eskfaxwpd X-HE-Tag: 1622495600-570311 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/29/2021 4:36 PM, Ming Lin wrote: > On 5/29/2021 1:15 PM, Hugh Dickins wrote: >=20 >> >> I believe the correct behaviour would be to unmap the nofault page >> then, allowing the proper page to be faulted in after.=C2=A0 That is >> certainly doable (the old mm/filemap_xip.c used to do so), but might >> get into some awkward race territory, with filesystem dependence >> (reminiscent of hole punch, in reverse).=C2=A0 shmem could operate tha= t >> way, and be the better for it: but I wouldn't want to add that, >> without also cleaning away all the shmem_recalc_inode() stuff. OK, I borrowed code from filemap_xip.c and implemented this behavior. Simon, Before I send out the patches for review, would you mind have a quick tes= t? https://github.com/minggr/linux, branch shmem_no_sigbus In Wayland compositors, you only need to pass in MAP_NOSIGBUS in mmap(). For example, //fd should be received from Wayland compositors client #define MAP_NOSIGBUS 0x200000 addr =3D mmap(NULL, size, PROT_READ, MAP_SHARED|MAP_NOSIGBUS, fd, offset) Thanks, Ming