From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4401C54FCB for ; Mon, 20 Apr 2020 13:58:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 536252070B for ; Mon, 20 Apr 2020 13:58:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fezp4Ucn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 536252070B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0226C8E0007; Mon, 20 Apr 2020 09:58:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F3B918E0003; Mon, 20 Apr 2020 09:58:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DDBB48E0007; Mon, 20 Apr 2020 09:58:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0105.hostedemail.com [216.40.44.105]) by kanga.kvack.org (Postfix) with ESMTP id C31C58E0003 for ; Mon, 20 Apr 2020 09:58:10 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 7C6B82470 for ; Mon, 20 Apr 2020 13:58:10 +0000 (UTC) X-FDA: 76728387540.09.snail71_d18f105ffa53 X-HE-Tag: snail71_d18f105ffa53 X-Filterd-Recvd-Size: 7887 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Mon, 20 Apr 2020 13:58:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587391089; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xUgf1dELTVkqbl5oz8lk6XQ7zC/RuDwFip+M0efFdJc=; b=fezp4UcnLOiAwNGjQ4oX63tLk2wtJmc/lUJKIWGuww8wBoQy59I5YcvzlgWs1QRTxJYK4L RQi1qkuIPQoJ4PdOTCK+AJWtDrq5bEV0WD1kszf0CVst92cloFucf3d7ZUIrV2+mqyk8V6 +m8tv/U8+XhXPaBJg1pmKBZc/SDKS44= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-198-PfqiXuyuPkeN__HhLkY-rQ-1; Mon, 20 Apr 2020 09:58:07 -0400 X-MC-Unique: PfqiXuyuPkeN__HhLkY-rQ-1 Received: by mail-wm1-f71.google.com with SMTP id v185so3532392wmg.0 for ; Mon, 20 Apr 2020 06:58:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xUgf1dELTVkqbl5oz8lk6XQ7zC/RuDwFip+M0efFdJc=; b=Qpey0kr6y7uaDWGBxgOA9KAGTrpSjKw0hXYKI+nG7qy5M29qeRPa7OIBBbNAMuJHSp roqHYBPJsmvXX0JbKmwg/wWq8H+1e9moTFas3D/fiScmNYgIabo2+InEf1SFWudGHD4N kOmHDDIhKF9tijBfWoTiR5kGras5BDhyq8SITShL/c4ZT/Yo7GekgorAthNQhCorQaq1 ds3HNDOMgsHQYPeKhsQa4BPWmAi3Eqp6fIJlA6CKnVNKSaV30WxCez4IG86tHbiwy17h LqphzFi9+QSg2QvB6ldaBgUFEe9eoi5z9/biXiEc9wWgQ5fMjRnyLcrxkVbEtad/NqvL E3iQ== X-Gm-Message-State: AGi0PubFUpC0bpNJUo7PvSSQsgu+BUfhAACSFbwf0O4ANIravTb061PG PRMWHA4wZTeWH7TYDrcofKGmSTm2C1olatTRSYv4EcBclGxVGVRm6wyHQEzbVOioNq+7U6XdGUF UP6zyQNKaKdo= X-Received: by 2002:adf:f343:: with SMTP id e3mr18183014wrp.51.1587391086599; Mon, 20 Apr 2020 06:58:06 -0700 (PDT) X-Google-Smtp-Source: APiQypKgfh4+u4HEj4PPYW/XSZ46PCQmhZFzPWrmjnxffDGdhSBfk7/303BzRADycOzBMc3ansohTA== X-Received: by 2002:adf:f343:: with SMTP id e3mr18182928wrp.51.1587391086383; Mon, 20 Apr 2020 06:58:06 -0700 (PDT) Received: from localhost.localdomain ([194.230.155.102]) by smtp.gmail.com with ESMTPSA id y18sm1584636wmc.45.2020.04.20.06.58.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Apr 2020 06:58:05 -0700 (PDT) From: Emanuele Giuseppe Esposito Subject: Re: [PATCH 4/8] fs: introduce simple_new_inode To: Greg Kroah-Hartman Cc: linux-nfs@vger.kernel.org, Paolo Bonzini , Jeremy Kerr , Arnd Bergmann , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Dennis Dalessandro , Mike Marciniszyn , Doug Ledford , Jason Gunthorpe , Frederic Barrat , Andrew Donnellan , Robert Richter , "Manoj N. Kumar" , "Matthew R. Ochs" , Uma Krishnan , "James E.J. Bottomley" , "Martin K. Petersen" , Felipe Balbi , Alexander Viro , Ian Kent , Joel Becker , Christoph Hellwig , "Rafael J. Wysocki" , Matthew Garrett , Ard Biesheuvel , Miklos Szeredi , Mike Kravetz , Mark Fasheh , Joseph Qi , Alexey Dobriyan , Luis Chamberlain , Kees Cook , Iurii Zaikin , Anton Vorontsov , Colin Cross , Tony Luck , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , John Fastabend , KP Singh , Hugh Dickins , Andrew Morton , "J. Bruce Fields" , Chuck Lever , Trond Myklebust , Anna Schumaker , "David S. Miller" , Jakub Kicinski , James Morris , "Serge E. Hallyn" , John Johansen , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, oprofile-list@lists.sf.net, linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org, linux-fsdevel@vger.kernel.org, autofs@vger.kernel.org, linux-efi@vger.kernel.org, linux-mm@kvack.org, ocfs2-devel@oss.oracle.com, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-security-module@vger.kernel.org References: <20200414124304.4470-1-eesposit@redhat.com> <20200414124304.4470-5-eesposit@redhat.com> <20200414130140.GD720679@kroah.com> Message-ID: Date: Mon, 20 Apr 2020 15:58:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200414130140.GD720679@kroah.com> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/14/20 3:01 PM, Greg Kroah-Hartman wrote: > On Tue, Apr 14, 2020 at 02:42:58PM +0200, Emanuele Giuseppe Esposito wrote: >> It is a common special case for new_inode to initialize the >> time to the current time and the inode to get_next_ino(). >> Introduce a core function that does it and use it throughout >> Linux. > > Shouldn't this just be called new_inode_current_time()? > > How is anyone going to remember what simple_new_inode() does to the > inode structure? I noticed that most functions in libfs.c are called "simple_*" when they do the right thing for the majority of simple use cases (e.g., simple_symlink_inode_operations or simple_dir_operations). I can certainly rename the function. Thank you for all the feedback, I will incorporate it and send a new patch series soon. Emanuele > >> --- a/fs/libfs.c >> +++ b/fs/libfs.c >> @@ -595,6 +595,18 @@ int simple_write_end(struct file *file, struct address_space *mapping, >> } >> EXPORT_SYMBOL(simple_write_end); >> >> +struct inode *simple_new_inode(struct super_block *sb) >> +{ >> + struct inode *inode = new_inode(sb); >> + if (inode) { >> + inode->i_ino = get_next_ino(); >> + inode->i_atime = inode->i_mtime = >> + inode->i_ctime = current_time(inode); >> + } >> + return inode; >> +} >> +EXPORT_SYMBOL(simple_new_inode);