On 18.08.2016 13:12, Vlastimil Babka wrote:
> On 18.8.2016 22:01, Ralf-Peter Rohbeck wrote:
>> On 17.08.2016 23:57, Vlastimil Babka wrote:
>>>>>> Hmm. I added linux-next git, fetched it etc but apparently I didn't check
>>>>>> out the right branch. Do you want next-20160817?
>>>>> Yes this one should be OK. It contains Vlastimil's patches.
>>>>>
>>>>> Thanks!
>>>> This has been working so far. I built a kernel successfully, with dd
>>>> writing to two drives. There were a number of messages in the trace pipe
>>>> but compaction/migration always succeeded it seems.
>>>> I'll run the big torture test overnight.
>>> Good news, thanks. Did you also apply Joonsoo's suggested removal of
>>> suitable_migration_target() check, or is this just the linux-next
>>> version with added trace_printk()/pr_info()?
>>>
>>> Vlastimil
>> Yes, that change was in my test with linux-next-20160817. Here's the diff:
>>
>> diff --git a/mm/compaction.c b/mm/compaction.c
>> index f94ae67..60a9ca2 100644
>> --- a/mm/compaction.c
>> +++ b/mm/compaction.c
>> @@ -1083,8 +1083,10 @@ static void isolate_freepages(struct
>> compact_control *cc)
>>                           continue;
>>
>>                   /* Check the block is suitable for migration */
>> +/*
>>                   if (!suitable_migration_target(page))
>>                           continue;
>> +*/
> OK, could you please also try if uncommenting the above still works without OOM?
> Or just plain linux-next-20160817, I guess we don't need the printk's to test
> this difference.
>
> Thanks a lot!
> Vlastimil
>
With the two lines back in I had OOMs again. See the attached logs.


Ralf-Peter


----------------------------------------------------------------------
The information contained in this transmission may be confidential. Any disclosure, copying, or further distribution of confidential information is not permitted unless such privilege is explicitly granted in writing by Quantum. Quantum reserves the right to have electronic communications, including email and attachments, sent across its networks filtered through anti virus and spam software programs and retain such messages in order to comply with applicable data security and retention requirements. Quantum is not responsible for the proper and complete transmission of the substance of this communication or for any delay in its receipt.