From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB1C7C433EF for ; Mon, 27 Jun 2022 08:32:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 411198E0001; Mon, 27 Jun 2022 04:32:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 397966B0072; Mon, 27 Jun 2022 04:32:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 239898E0001; Mon, 27 Jun 2022 04:32:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 11DC06B0071 for ; Mon, 27 Jun 2022 04:32:56 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id C254B60E3B for ; Mon, 27 Jun 2022 08:32:55 +0000 (UTC) X-FDA: 79623350310.14.A770BF6 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf13.hostedemail.com (Postfix) with ESMTP id 593FC2002A for ; Mon, 27 Jun 2022 08:32:54 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4LWgtW535ZzkWKZ; Mon, 27 Jun 2022 16:31:31 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 27 Jun 2022 16:32:48 +0800 Subject: Re: [PATCH v2 5/9] mm, hwpoison: make unpoison aware of raw error info in hwpoisoned hugepage To: Naoya Horiguchi , CC: Andrew Morton , David Hildenbrand , Mike Kravetz , Liu Shixin , Yang Shi , Oscar Salvador , Muchun Song , Naoya Horiguchi , References: <20220623235153.2623702-1-naoya.horiguchi@linux.dev> <20220623235153.2623702-6-naoya.horiguchi@linux.dev> From: Miaohe Lin Message-ID: Date: Mon, 27 Jun 2022 16:32:48 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20220623235153.2623702-6-naoya.horiguchi@linux.dev> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656318775; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AydzRRZHPMV0NnU092Yx9g5gpfEwFyRB4oKW+1n9BaY=; b=ukWtwnxIz12vgutHvHIDRyr6ry/+jB3EHU2qDNMYeWTbkblHBtHKVzWqjMkv+pilUOuD3O 7hF01yW3dSQIkF1fxXsPjf1IsUOaZBdVyVaJ3XqdI9SrlGkz2ZMW9Lew2/V/N+ygP+pu5X fxEw0bzNnGkVVlGThVKzcJLNHSVSLQE= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf13.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656318775; a=rsa-sha256; cv=none; b=aXvZPrRyIf50yH/vr/LQbGI7LgBkGhHW1t9IDthOjo3YE9sEvYBGU6a0wDq3DOZ0Gl2ziW e4WBCkkOBktIOmFwD6qVSz3RIg9ai5Z4jAaPgY2uVwq17TOo679859hoyukYoAXe1WMqEs 6VMQ9+8Xmtp5ULndTgNS4a5D04NDmbk= X-Rspamd-Queue-Id: 593FC2002A Authentication-Results: imf13.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf13.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: hwur59nd75em8dx3b5f1exnbmt6ktjp1 X-HE-Tag: 1656318774-214355 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/6/24 7:51, Naoya Horiguchi wrote: > From: Naoya Horiguchi > > Raw error info list needs to be removed when hwpoisoned hugetlb is > unpoisioned. And unpoison handler needs to know how many errors there > are in the target hugepage. So add them. > > Signed-off-by: Naoya Horiguchi snip > @@ -2255,7 +2275,7 @@ int unpoison_memory(unsigned long pfn) > unlock_mutex: > mutex_unlock(&mf_mutex); > if (!ret || freeit) { > - num_poisoned_pages_dec(); > + num_poisoned_pages_sub(count); IIUC, num_poisoned_pages will only be incremented once for hugetlb page. If many subpages are hwpoisoned, they will reach the "else if (res == -EHWPOISON)" path in try_memory_failure_hugetlb and thus num_poisoned_pages_inc is ignored. Maybe that should be changed so subpages can contribute to the num_poisoned_pages or should we just do num_poisoned_pages_dec here? Or am I miss something? Thanks! > unpoison_pr_info("Unpoison: Software-unpoisoned page %#lx\n", > page_to_pfn(p), &unpoison_rs); > } >