From: David Hildenbrand <david@redhat.com>
To: Peter Xu <peterx@redhat.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: Alistair Popple <apopple@nvidia.com>,
Andrew Morton <akpm@linux-foundation.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Matthew Wilcox <willy@infradead.org>,
John Hubbard <jhubbard@nvidia.com>,
Hugh Dickins <hughd@google.com>, Vlastimil Babka <vbabka@suse.cz>,
Yang Shi <shy828301@gmail.com>,
"Kirill A . Shutemov" <kirill@shutemov.name>
Subject: Re: [PATCH v3 2/4] mm: Rename zap_skip_check_mapping() to should_zap_page()
Date: Fri, 28 Jan 2022 09:16:07 +0100 [thread overview]
Message-ID: <eb415c6d-8ae3-1fa4-9c36-efe4231fd8ad@redhat.com> (raw)
In-Reply-To: <20220128045412.18695-3-peterx@redhat.com>
On 28.01.22 05:54, Peter Xu wrote:
> The previous name is against the natural way people think. Invert the meaning
> and also the return value. No functional change intended.
>
> Suggested-by: Hugh Dickins <hughd@google.com>
Could have sworn it was me :P
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2022-01-28 8:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-28 4:54 [PATCH v3 0/4] mm: Rework zap ptes on swap entries Peter Xu
2022-01-28 4:54 ` [PATCH v3 1/4] mm: Don't skip swap entry even if zap_details specified Peter Xu
2022-01-28 4:54 ` [PATCH v3 2/4] mm: Rename zap_skip_check_mapping() to should_zap_page() Peter Xu
2022-01-28 8:16 ` David Hildenbrand [this message]
2022-01-28 8:53 ` Peter Xu
2022-01-28 4:54 ` [PATCH v3 3/4] mm: Change zap_details.zap_mapping into even_cows Peter Xu
2022-01-28 9:03 ` David Hildenbrand
2022-01-28 9:17 ` Peter Xu
2022-01-28 9:18 ` David Hildenbrand
2022-01-28 4:54 ` [PATCH v3 4/4] mm: Rework swap handling of zap_pte_range Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb415c6d-8ae3-1fa4-9c36-efe4231fd8ad@redhat.com \
--to=david@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=hughd@google.com \
--cc=jhubbard@nvidia.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterx@redhat.com \
--cc=shy828301@gmail.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).