From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09066ECAAD3 for ; Mon, 19 Sep 2022 08:43:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B34D6B0074; Mon, 19 Sep 2022 04:43:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6634C940008; Mon, 19 Sep 2022 04:43:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5041C940007; Mon, 19 Sep 2022 04:43:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3DE386B0074 for ; Mon, 19 Sep 2022 04:43:30 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 134A61A03CD for ; Mon, 19 Sep 2022 08:43:30 +0000 (UTC) X-FDA: 79928196180.18.8AFEDA1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 891DA40004 for ; Mon, 19 Sep 2022 08:43:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663577009; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c68X5zyTPcgo56gf8lFXosz3ez64Ms9Dsywzzb9DBq4=; b=SJxs5dtcbl+YI/ghDfBgorOrzdvETmYIBw08TiseLpJYIvKLntY1Sh/Y899JOnMy7kEBFi 1WviIIMUBtZsvZfRB8ShEUlaINRGIcf4xC0XGL3csODFq0uc/AFSLXw/unCcBM2hkwdcjf V9/vNvHfg20x69svAv0HvNF9Ba+9pNs= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-438-13vCnldqNYutwp2cywOnFw-1; Mon, 19 Sep 2022 04:43:27 -0400 X-MC-Unique: 13vCnldqNYutwp2cywOnFw-1 Received: by mail-wr1-f71.google.com with SMTP id i29-20020adfa51d000000b00228fa8325c0so6298209wrb.15 for ; Mon, 19 Sep 2022 01:43:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date; bh=c68X5zyTPcgo56gf8lFXosz3ez64Ms9Dsywzzb9DBq4=; b=jyHqsOrB9S9Iauu27CWsPosNEDpiboWYhFRVKFQ1AJ2+faC0CxWas6Fbm3qJEGQdbI r6GBfcn5es9rT6fit22MR0D/P7+MU2zTYiIf4MDJPTqfWetJY1OPS5z0d+177acl+3i4 T+W3B+Cg1WToxrhhek/MjyiyZncpL3yQwbkWJt/9UuPthN3/cp7fQ2rDbjIqpaE+0j6z dLGJ4+nyJ6yae9prYua/lIGhMxWq7Ew8aHJN4RYGM1b8IgF5DNl1liCrb9+olAfXsXXR bMDZGDmtXngBhRMx1mUHjxv3wun9wxDJT08hAVWmXUtl2V5Ywyym6BO6q3AV20f9eRJz ZmRg== X-Gm-Message-State: ACrzQf0CpG5EmBAvJrZOFjirv8pcn0wV/do+AclQ6N7IWFbvD00kgOn6 GTqcAZAzVw+aYZhO4TfLKeoqyXsJ9zKY57ECUEHVMlm/sc1t9Zg/GEUaMY+aCQMH4JQ4le6zz4q QIRFsdHU2vE0= X-Received: by 2002:a05:600c:4e11:b0:3b4:91fd:d0c with SMTP id b17-20020a05600c4e1100b003b491fd0d0cmr11562112wmq.71.1663577006569; Mon, 19 Sep 2022 01:43:26 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6N7jj2hCArDkIS0hqCNfKGStr12fevzZwsYldSD36MylkUB8fFQzxSwsr4/3VsP5ZV8nEMQw== X-Received: by 2002:a05:600c:4e11:b0:3b4:91fd:d0c with SMTP id b17-20020a05600c4e1100b003b491fd0d0cmr11562098wmq.71.1663577006284; Mon, 19 Sep 2022 01:43:26 -0700 (PDT) Received: from ?IPV6:2003:cb:c703:c100:c136:f914:345f:f5f3? (p200300cbc703c100c136f914345ff5f3.dip0.t-ipconnect.de. [2003:cb:c703:c100:c136:f914:345f:f5f3]) by smtp.gmail.com with ESMTPSA id h22-20020a05600c2cb600b003b4868eb71bsm14009883wmc.25.2022.09.19.01.43.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Sep 2022 01:43:25 -0700 (PDT) Message-ID: Date: Mon, 19 Sep 2022 10:43:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH -next v2 1/5] docs: notifier-error-inject: fix non-working usage of negative values To: Akinobu Mita , Zhao Gongyi Cc: linux-doc@vger.kernel.org, LKML , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Jonathan Corbet , osalvador@suse.de, shuah@kernel.org References: <20220915085757.258608-1-zhaogongyi@huawei.com> <20220915085757.258608-2-zhaogongyi@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663577009; a=rsa-sha256; cv=none; b=o0Ap/2HHk65sO7zy2mo6VZk6ay/vsuCrwKrvAWi6OvdA8ICh37MPPktM5Grg0+fLf/XhmS JAy46MJJQ/MgeoklwaY5+gAZiA3wNy/YERinpL6rcF2ID8wiA4+ULPDpIv/B29pBKRxSsn 4lEddVR3sIZMO5f0tJGDjhphFS/EVys= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SJxs5dtc; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663577009; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=c68X5zyTPcgo56gf8lFXosz3ez64Ms9Dsywzzb9DBq4=; b=OtLbXDTtYt9YzSpgVWrN8DTrhx0fxBdFrCuOZB9BfANDwmF+YxVH6C9YeD0Trk+eZDaXlP iA0JAAW6VkhgKSTK857vY4h42I7WYeG93U7dA2sz+bGmIKg7oR+WuXEhQlL+Kok7nhiGQ2 H1AELer5ujfuwusxgNSIYhxya+F/pwc= X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 891DA40004 Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SJxs5dtc; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Stat-Signature: enzrtfmyw3zxiutyxmfmaerbzqdajsku X-HE-Tag: 1663577009-88317 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 17.09.22 07:39, Akinobu Mita wrote: > 2022年9月15日(木) 18:01 Zhao Gongyi : >> >> Fault injection uses debugfs in a way that the provided values via >> sysfs are interpreted as u64. Providing negative numbers results in >> an error: >> >> # cd sys/kernel/debug/notifier-error-inject/memory >> # echo -12 > actions/MEM_GOING_ONLINE/error >> -bash: echo: write error: Invalid argument >> >> Update the docs and examples to use "printf %#x " in these cases. > > I'd rather fix the notifier-error-inject module than change the user interface. > I'll send a patch, so could you check if that solves the problem. > That will also make patch #2 unnecessary, correct? -- Thanks, David / dhildenb