From: Tianyu Lan <ltykernel@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: kys@microsoft.com, haiyangz@microsoft.com,
sthemmin@microsoft.com, wei.liu@kernel.org, tglx@linutronix.de,
mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com,
arnd@arndb.de, akpm@linux-foundation.org, konrad.wilk@oracle.com,
hch@lst.de, m.szyprowski@samsung.com, robin.murphy@arm.com,
joro@8bytes.org, will@kernel.org, davem@davemloft.net,
kuba@kernel.org, jejb@linux.ibm.com, martin.petersen@oracle.com,
Tianyu Lan <Tianyu.Lan@microsoft.com>,
iommu@lists.linux-foundation.org, linux-arch@vger.kernel.org,
linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, linux-scsi@vger.kernel.org,
netdev@vger.kernel.org, vkuznets@redhat.com,
thomas.lendacky@amd.com, brijesh.singh@amd.com,
sunilmut@microsoft.com
Subject: Re: [Resend RFC PATCH V2 08/12] UIO/Hyper-V: Not load UIO HV driver in the isolation VM.
Date: Thu, 15 Apr 2021 21:09:55 +0800 [thread overview]
Message-ID: <eec53f89-4a18-39ce-aff8-c07be2ce3971@gmail.com> (raw)
In-Reply-To: <YHcOL+HlEoh5jPb8@kroah.com>
On 4/14/2021 11:45 PM, Greg KH wrote:
> On Wed, Apr 14, 2021 at 10:49:41AM -0400, Tianyu Lan wrote:
>> From: Tianyu Lan <Tianyu.Lan@microsoft.com>
>>
>> UIO HV driver should not load in the isolation VM for security reason.
>> Return ENOTSUPP in the hv_uio_probe() in the isolation VM.
>>
>> Signed-off-by: Tianyu Lan <Tianyu.Lan@microsoft.com>
>> ---
>> drivers/uio/uio_hv_generic.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/uio/uio_hv_generic.c b/drivers/uio/uio_hv_generic.c
>> index 0330ba99730e..678b021d66f8 100644
>> --- a/drivers/uio/uio_hv_generic.c
>> +++ b/drivers/uio/uio_hv_generic.c
>> @@ -29,6 +29,7 @@
>> #include <linux/hyperv.h>
>> #include <linux/vmalloc.h>
>> #include <linux/slab.h>
>> +#include <asm/mshyperv.h>
>>
>> #include "../hv/hyperv_vmbus.h"
>>
>> @@ -241,6 +242,10 @@ hv_uio_probe(struct hv_device *dev,
>> void *ring_buffer;
>> int ret;
>>
>> + /* UIO driver should not be loaded in the isolation VM.*/
>> + if (hv_is_isolation_supported())
>> + return -ENOTSUPP;
>> +
>> /* Communicating with host has to be via shared memory not hypercall */
>> if (!channel->offermsg.monitor_allocated) {
>> dev_err(&dev->device, "vmbus channel requires hypercall\n");
>> --
>> 2.25.1
>>
>
> Again you send out known-wrong patches?
>
> :(
>
Sorry for noise. Will fix this next version and I think we should make
sure user space driver to check data from host. This patch will be removed.
next prev parent reply other threads:[~2021-04-15 13:10 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 14:49 [Resend RFC PATCH V2 00/12] x86/Hyper-V: Add Hyper-V Isolation VM support Tianyu Lan
2021-04-14 14:49 ` [Resend RFC PATCH V2 01/12] x86/HV: Initialize GHCB page in Isolation VM Tianyu Lan
2021-04-14 14:49 ` [Resend RFC PATCH V2 02/12] x86/HV: Initialize shared memory boundary " Tianyu Lan
2021-04-14 14:49 ` [Resend RFC PATCH V2 05/12] HV: Add ghcb hvcall support for SNP VM Tianyu Lan
2021-04-14 14:49 ` [Resend RFC PATCH V2 06/12] HV/Vmbus: Add SNP support for VMbus channel initiate message Tianyu Lan
2021-04-15 18:52 ` Konrad Rzeszutek Wilk
2021-04-14 14:49 ` [Resend RFC PATCH V2 08/12] UIO/Hyper-V: Not load UIO HV driver in the isolation VM Tianyu Lan
2021-04-14 15:42 ` Christoph Hellwig
2021-04-14 15:45 ` Greg KH
2021-04-14 16:17 ` Stephen Hemminger
2021-04-15 12:54 ` Tianyu Lan
2021-04-15 13:09 ` Tianyu Lan [this message]
2021-04-14 14:49 ` [Resend RFC PATCH V2 11/12] HV/Netvsc: Add Isolation VM support for netvsc driver Tianyu Lan
2021-04-14 15:50 ` Christoph Hellwig
2021-04-15 8:39 ` Tianyu Lan
2021-04-14 14:49 ` [Resend RFC PATCH V2 12/12] HV/Storvsc: Add Isolation VM support for storvsc driver Tianyu Lan
2021-04-14 15:51 ` Christoph Hellwig
[not found] ` <20210414144945.3460554-4-ltykernel@gmail.com>
2021-04-14 15:40 ` [Resend RFC PATCH V2 03/12] x86/Hyper-V: Add new hvcall guest address host visibility support Christoph Hellwig
2021-04-15 8:13 ` Tianyu Lan
[not found] ` <20210414144945.3460554-5-ltykernel@gmail.com>
2021-04-14 15:41 ` [Resend RFC PATCH V2 04/12] HV: Add Write/Read MSR registers via ghcb Christoph Hellwig
2021-04-15 8:19 ` Tianyu Lan
2021-04-15 18:11 ` Konrad Rzeszutek Wilk
[not found] ` <20210414144945.3460554-11-ltykernel@gmail.com>
2021-04-14 15:47 ` [Resend RFC PATCH V2 10/12] HV/IOMMU: Add Hyper-V dma ops support Christoph Hellwig
2021-05-12 16:01 ` Tianyu Lan
2021-05-12 17:29 ` Robin Murphy
2021-05-13 3:19 ` Lu Baolu
[not found] ` <20210414144945.3460554-8-ltykernel@gmail.com>
2021-04-15 20:24 ` [Resend RFC PATCH V2 07/12] HV/Vmbus: Initialize VMbus ring buffer for Isolation VM Konrad Rzeszutek Wilk
2021-04-19 6:36 ` Christoph Hellwig
[not found] ` <20210414144945.3460554-10-ltykernel@gmail.com>
2021-04-15 20:28 ` [Resend RFC PATCH V2 09/12] swiotlb: Add bounce buffer remap address setting function Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eec53f89-4a18-39ce-aff8-c07be2ce3971@gmail.com \
--to=ltykernel@gmail.com \
--cc=Tianyu.Lan@microsoft.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=brijesh.singh@amd.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=hch@lst.de \
--cc=hpa@zytor.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jejb@linux.ibm.com \
--cc=joro@8bytes.org \
--cc=konrad.wilk@oracle.com \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-scsi@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=martin.petersen@oracle.com \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=sthemmin@microsoft.com \
--cc=sunilmut@microsoft.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=vkuznets@redhat.com \
--cc=wei.liu@kernel.org \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).