From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0C5FC2B9F7 for ; Wed, 26 May 2021 09:56:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 23C4B6128D for ; Wed, 26 May 2021 09:56:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 23C4B6128D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A68846B0036; Wed, 26 May 2021 05:56:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F0296B006E; Wed, 26 May 2021 05:56:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 842966B0070; Wed, 26 May 2021 05:56:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0195.hostedemail.com [216.40.44.195]) by kanga.kvack.org (Postfix) with ESMTP id 49C346B0036 for ; Wed, 26 May 2021 05:56:12 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id E0FD7758E for ; Wed, 26 May 2021 09:56:11 +0000 (UTC) X-FDA: 78182926542.01.3EF1240 Received: from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32]) by imf19.hostedemail.com (Postfix) with ESMTP id BF7A090009E2 for ; Wed, 26 May 2021 09:55:02 +0000 (UTC) Received: from dggems706-chm.china.huawei.com (unknown [172.30.72.60]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4FqmTT4mh4zmb9x; Wed, 26 May 2021 17:52:45 +0800 (CST) Received: from dggemx753-chm.china.huawei.com (10.0.44.37) by dggems706-chm.china.huawei.com (10.3.19.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Wed, 26 May 2021 17:55:06 +0800 Received: from [10.136.110.154] (10.136.110.154) by dggemx753-chm.china.huawei.com (10.0.44.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Wed, 26 May 2021 17:55:05 +0800 Subject: Re: [PATCH 10/13] f2fs: Convert to using invalidate_lock To: Jan Kara , CC: Christoph Hellwig , Dave Chinner , , Damien Le Moal , "Darrick J. Wong" , Jaegeuk Kim , Jeff Layton , Johannes Thumshirn , , , , , , Miklos Szeredi , Steve French , Ted Tso , Matthew Wilcox References: <20210525125652.20457-1-jack@suse.cz> <20210525135100.11221-10-jack@suse.cz> From: Chao Yu Message-ID: Date: Wed, 26 May 2021 17:55:05 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20210525135100.11221-10-jack@suse.cz> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.136.110.154] X-ClientProxiedBy: dggemx702-chm.china.huawei.com (10.1.199.49) To dggemx753-chm.china.huawei.com (10.0.44.37) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: BF7A090009E2 Authentication-Results: imf19.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=huawei.com; spf=pass (imf19.hostedemail.com: domain of yuchao0@huawei.com designates 45.249.212.32 as permitted sender) smtp.mailfrom=yuchao0@huawei.com X-Rspamd-Server: rspam04 X-Stat-Signature: uqtzo71w43iiawdrsm7qatr6eykc86z8 X-HE-Tag: 1622022902-582471 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2021/5/25 21:50, Jan Kara wrote: > Use invalidate_lock instead of f2fs' private i_mmap_sem. The intended > purpose is exactly the same. By this conversion we fix a long standing > race between hole punching and read(2) / readahead(2) paths that can > lead to stale page cache contents. > > CC: Jaegeuk Kim > CC: Chao Yu > CC: linux-f2fs-devel@lists.sourceforge.net > Signed-off-by: Jan Kara Acked-by: Chao Yu Thanks,