From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47FFFC3F2D1 for ; Thu, 5 Mar 2020 22:59:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EC73F20717 for ; Thu, 5 Mar 2020 22:59:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NMEURHwW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC73F20717 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9A6356B0005; Thu, 5 Mar 2020 17:59:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9563A6B0006; Thu, 5 Mar 2020 17:59:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 81D5E6B0007; Thu, 5 Mar 2020 17:59:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0182.hostedemail.com [216.40.44.182]) by kanga.kvack.org (Postfix) with ESMTP id 682266B0005 for ; Thu, 5 Mar 2020 17:59:06 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id ED1B0181AC9CB for ; Thu, 5 Mar 2020 22:59:05 +0000 (UTC) X-FDA: 76562825850.05.line55_1529cadee4118 X-HE-Tag: line55_1529cadee4118 X-Filterd-Recvd-Size: 5160 Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by imf22.hostedemail.com (Postfix) with ESMTP for ; Thu, 5 Mar 2020 22:59:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583449144; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+8u3vM6PQnQuPvjEEeU0bRf3qHrMtBcW7NxqS7AHxKQ=; b=NMEURHwWkATNdPIAZBKjwlVWXJ2v/Ba9JH+ezKpwsGCWCcw/w+Qd7QC453mFjXVLqIf8Fn whrjbY4/NZfC82lJ44J7X9/cy88fLkuQkwgxhzU02A7mxpNb9MFyJTF+HkJrdk3vJFTSkO zcgznkQLHgAl1RX38xOudX0xKXQd6l4= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-478-F9DGJDcvM1Cl2Qb9-KLSZg-1; Thu, 05 Mar 2020 17:59:03 -0500 X-MC-Unique: F9DGJDcvM1Cl2Qb9-KLSZg-1 Received: by mail-qt1-f198.google.com with SMTP id f25so124669qtp.12 for ; Thu, 05 Mar 2020 14:59:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=+8u3vM6PQnQuPvjEEeU0bRf3qHrMtBcW7NxqS7AHxKQ=; b=I0qUIg4RGOwhGY3rnpHticqoGsdR95uMlaVHF+G59qekJKGkeZRpI16NS5baczc16K 5ZZOP2Z4Cwi3qRN1SsA0fFmzjkiSfdEF2wAa9tH2WWs1DD6iYRFKra4epbPtF3VMx/U1 cZ+B3FRTPcBxSBYes/NtPlJ8neiBpsr9HYkivJOJWHnNnYZIKH1pczytcCQQKH4Cs9cE QGebAv9Bvdjkf695vJXwIT9pdUhhIwYqYmFy8R8W3tgXzwaV329q3VcWIH36wpcjCugt 2iM17YXqdiuoevoxHgmqq/4Xz5Fyb+Qu3uHEmTWbo7PmnNTonRv6TdnKI+tX0hHi3qcG LuoA== X-Gm-Message-State: ANhLgQ1SuBlmKjoFFXUppPfF6MWC5eUqpEGb75IV79A8nxyNRSGMTDWA RstSx/m4V3avSLa6JwgDQQLYZLAyqgfCRSgCS3cw++3KWNBA1Hi5OIdYk2K5ZoRut97yHa7KHyV HHGBPC7K0IEE= X-Received: by 2002:a0c:f503:: with SMTP id j3mr570797qvm.182.1583449142893; Thu, 05 Mar 2020 14:59:02 -0800 (PST) X-Google-Smtp-Source: ADFU+vv5bUiA1m0tKQOuWMX37igxok2zcMfLC2mZz/EhrU4qFpIpZIjTseHv0WaFfLwepFunmIgS9A== X-Received: by 2002:a0c:f503:: with SMTP id j3mr570788qvm.182.1583449142658; Thu, 05 Mar 2020 14:59:02 -0800 (PST) Received: from desoxy (c-24-61-245-152.hsd1.ma.comcast.net. [24.61.245.152]) by smtp.gmail.com with ESMTPSA id t13sm16198838qkm.60.2020.03.05.14.59.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2020 14:59:01 -0800 (PST) Message-ID: Subject: Re: [PATCH] mm/vmscan: Prioritize anonymous executable pages like we do file-backed From: Adam Jackson To: Shakeel Butt , Vlastimil Babka Cc: Linux MM , Johannes Weiner , Roman Gushchin , Joonsoo Kim , Michal Hocko , Mel Gorman Date: Thu, 05 Mar 2020 17:58:59 -0500 In-Reply-To: References: <20200304203235.3623103-1-ajax@redhat.com> <8b8420f9-12bc-b247-7727-f82038ffa6e7@suse.cz> User-Agent: Evolution 3.34.0 (3.34.0-1.fc31) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 2020-03-05 at 12:41 -0800, Shakeel Butt wrote: > Have you actually seen this issue (i.e. JIT code reclaimed and > thrashing) happening for real workloads? The mention of gnome-shell wasn't entirely an accident, it's largely written in javascript which is jit-compiled. Under sufficiently dire disk I/O conditions merely moving the cursor would lag. That ought to be impossible, because nothing in the cursor update path ought to be blocking on the disk and we believe the CPU scheduler to be competent. Plenty of bugs are contributing here, but among them yes the (jitted bits of the) cursor update code can get paged out while megabytes of file-backed text stay resident. It's certainly drowned out by the contribution of the plenty of other bugs involved, but still. > Originally this heuristic was added to protect executable file pages > from the streaming workloads. Now we have workingset detection for > file pages and there is ongoing work for adding that support for anon > pages, I am wondering if this specific heuristic is still helpful. Enh. I would tend to think that code is way more precious than data in terms of staying resident. If the working set detection works well enough to come to that conclusion on its own without explictly knowing about executable pages, that'd be awesome and I'd be entirely fine with removing even more of this heuristic. - ajax