From: "Shi, Yang" <yang.shi@linaro.org>
To: Michal Hocko <mhocko@kernel.org>
Cc: akpm@linux-foundation.org, iamjoonsoo.kim@lge.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linaro-kernel@lists.linaro.org
Subject: Re: [v2 PATCH] mm: move page_ext_init after all struct pages are initialized
Date: Fri, 20 May 2016 08:41:09 -0700 [thread overview]
Message-ID: <f0c27d67-3735-300b-76eb-e49d56ab7a10@linaro.org> (raw)
In-Reply-To: <20160520131649.GC5197@dhcp22.suse.cz>
On 5/20/2016 6:16 AM, Michal Hocko wrote:
> On Thu 19-05-16 15:13:26, Yang Shi wrote:
> [...]
>> diff --git a/init/main.c b/init/main.c
>> index b3c6e36..2075faf 100644
>> --- a/init/main.c
>> +++ b/init/main.c
>> @@ -606,7 +606,6 @@ asmlinkage __visible void __init start_kernel(void)
>> initrd_start = 0;
>> }
>> #endif
>> - page_ext_init();
>> debug_objects_mem_init();
>> kmemleak_init();
>> setup_per_cpu_pageset();
>> @@ -1004,6 +1003,8 @@ static noinline void __init kernel_init_freeable(void)
>> sched_init_smp();
>>
>> page_alloc_init_late();
>> + /* Initialize page ext after all struct pages are initializaed */
>> + page_ext_init();
>>
>> do_basic_setup();
>
> I might be missing something but don't we have the same problem with
> CONFIG_FLATMEM? page_ext_init_flatmem is called way earlier. Or
> CONFIG_DEFERRED_STRUCT_PAGE_INIT is never enabled for CONFIG_FLATMEM?
Yes, CONFIG_DEFERRED_STRUCT_PAGE_INIT depends on MEMORY_HOTPLUG which
depends on SPARSEMEM. So, this config is not valid for FLATMEM at all.
Thanks,
Yang
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-05-20 15:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-19 22:13 [v2 PATCH] mm: move page_ext_init after all struct pages are initialized Yang Shi
2016-05-20 13:16 ` Michal Hocko
2016-05-20 15:41 ` Shi, Yang [this message]
2016-05-23 7:31 ` Michal Hocko
2016-05-23 16:42 ` Shi, Yang
2016-05-23 18:04 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0c27d67-3735-300b-76eb-e49d56ab7a10@linaro.org \
--to=yang.shi@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).